[Bug 44483] New: 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Bug ID: 44483
           Summary: 7zip installer cannot start on wine 3.1
           Product: Wine
           Version: 3.1
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

On wine 3.1 7zip installer (versions 16.04, 17.01, 18.01 both32 and 64 bit)
cannot start.

excuting wine 7z1891.exe  wine return wth exit code -1.
Wine doesn't log anything (no err, warn or fixme).

It IS working with wine 3.0

Im currently doing a git bisect to see what commit intorduced the regression.

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

--- Comment #1 from Lorenzo Ferrillo  ---
Sorry it was supposed to be "wine 7z1801.exe"

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.7-zip.org/a/7z18
                   |                            |01.exe
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Fabian Maurer  ---
Confirming and adding download link.

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

--- Comment #3 from Lorenzo Ferrillo  ---
Bisect results:

662f727a7914fa1996c2fe19e2063a81fc079653 is the first bad commit
commit 662f727a7914fa1996c2fe19e2063a81fc079653
Author: Nikolay Sivov 
Date:   Thu Feb 1 10:09:05 2018 +0300

comctl32: Introduce Edit control.

Signed-off-by: Nikolay Sivov 
    Signed-off-by: Alexandre Julliard

:040000 040000 2a1f7bea9e3fa77a629b23f5bd69f32d1523d3b5
b22c25bdebd40c56edcf83090cf0f8d248412d38 M      dlls

I could however not test if reverting this commit on git HEAD actually work.
There are conflicts during revert and git is extremly unhelpful to understand
which the conflicts are

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

--- Comment #4 from Nikolay Sivov  ---
Hi, Lorenzo.

Thanks for the report and bisecting. This is already fixed in git, commit
0de689f41560208bbc14fb1a6b9f7dfe154326c1. Please retest with latest wine-git.

Relevant log part is:

---
002e:trace:win:WIN_CreateWindowEx L"" L"Edit"->L"6.0.2600.2982!Edit"
ex=00000204 style=50010080 12,34 228x23 parent=0x1007c menu=0x6f inst=0x400000
params=(nil)
002e:trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE WS_TABSTOP
00000080
002e:trace:win:dump_window_styles exstyle: WS_EX_NOPARENTNOTIFY
WS_EX_CLIENTEDGE
002e:warn:win:create_window_handle error 6 creating window
---

The issue is that redirection is applied but implementation module is not
loaded yet -> class is not registered -> window creation fails. In case of this
installer failure to create dialog control most likely is fatal.

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

--- Comment #5 from Lorenzo Ferrillo  ---
Confirm that the  0de689f41560208bbc14fb1a6b9f7dfe154326c1 commit fix this
issue

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |662f727a7914fa1996c2fe19e20
                   |                            |63a81fc079653

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |0de689f41560208bbc14fb1a6b9
                   |                            |f7dfe154326c1

--- Comment #6 from Nikolay Sivov  ---
Marking fixed.

[Bug 44483] 7zip installer cannot start on wine 3.1

https://bugs.winehq.org/show_bug.cgi?id=44483

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 3.2.