[Bug 22021] New: Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Summary: Switching pages in ElsterFormular 2009/2010 needs much
                    time
           Product: Wine
           Version: unspecified
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

As summary says switching pages in ElsterFormular 2009/2010 needs much time.

ElsterFormular is a app for German tax payers which is the only free app for
annual income tax return and only supports "the evil OS" (political reasons?).

It seems to be based on Qt.

Test case with translation:
1. wine ~/.wine/drive_c/Programme/ElsterFormular/bin/elfostarter.exe (default)
2. Menu Datei -> Neu (File -> New)
3. Privatperson -> Einkommensteuererklärung (private individual -> income tax
return) on the left
4. Hauptvordruck -> Seite 1 is automatically loading (needs long time)
5. Hauptvordruck -> Seite 2 on the left (needs also long time for loading)
6. and so on - also when you load a previous

Hauptvordruck -> Seite 1 == main form -> page 1

You can download it for free here (only available in German):
https://download.elster.de/download/2009/ElsterFormular2009-Setup.exe

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor

--- Comment #1 from Jeff Zaroyko   2010-03-12 15:47:30 ---
not major: http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity

Please specify which Wine version you are using.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Johannes Obermayr  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.40

--- Comment #2 from Johannes Obermayr   2010-03-12 16:00:00 ---
1.1.40 snapshot 20100306:
http://download.opensuse.org/repositories/Emulators:/Wine/openSUSE_11.2/i586...

It is also with previous:
see http://bugs.winehq.org/show_bug.cgi?id=21497#c10

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

M. Link  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from M. Link   2010-05-03 13:45:13 ---
I confirm this bug,
Ubuntu Lucid Lynx (10.04) with wine1.1.43-0ubuntu1~lucidppa4
Elsterformular 11.4.1
Opening new pages causes big delay as well as switching from one input-line to
another.

Regards,
Matthias

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Christoph Bauer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Christoph Bauer   2010-05-05 08:21:12 ---
It's also visible on debian. With strace I see a lot of
calls to

--- SIGSEGV (Segmentation fault) @ 0 (0) ---
open("/usr/bin/../share/wine/fonts/vgasys.fon", O_RDONLY|O_LARGEFILE) = 31
open("/usr/bin/../share/wine/fonts/vgasys.fon", O_RDONLY|O_LARGEFILE) = 31
open("/usr/bin/../share/wine/fonts/vgasys.fon", O_RDONLY|O_LARGEFILE) = 31
open("/usr/bin/../share/wine/fonts/vgasys.fon", O_RDONLY|O_LARGEFILE) = 31

(I filter for open calls). I guess under native windows, the font file
is cached internally somehow.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Christoph Bauer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Christoph Bauer   2010-05-11 10:45:14 ---
*** This bug has been confirmed by popular vote. ***

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #6 from Christoph Bauer   2010-05-11 12:20:06 ---
With WINEDBG=+font I see a lot of "not in cache" messages for the SYSTEM font.

I looked in dlls/gdi32/freetype.c:find_in_cache(). I guess the function
i called with can_use_bitmap = FALSE. (Unfortunatly wine doesn't compile
on my system (debian amd64. I tried "linux32 tools/wineinstall". So I
cannot debug it really.)

Furthermore I suspect, that the cache list of fonts grows very large. 
After some time you can't work with elster anymore. See add_to_cache. 
I guess the font vgasys.fon is added several times to the list, but cannot
be used, because of the can_use_bitmap flag.

I deleted now my vagsys.fon file and run winetricks tahoma. The idea is
to use only TTF fonts. Then the value of can_use_bitmap is ignored
in find_in_cache().

And hooray! Elster is with this workaround very fast.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #7 from Johannes Obermayr   2010-05-11 12:42:21 ---
Thanks Christoph.

sudo rm /usr/share/wine/fonts/vgasys.fon

is enough for a extreme speedup on openSUSE ...

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #8 from Dan Kegel   2010-05-12 03:45:05 ---
Created an attachment (id=27887)
 --> (http://bugs.winehq.org/attachment.cgi?id=27887)
Possible fix

Does the attached patch also help?

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #9 from Johannes Obermayr   2010-05-21 15:24:47 ---
(In reply to comment #8)
> Does the attached patch also help?

My experience with 1.1.44.20100520:

unpatched: 9 - 12 seconds after load dialog disappears

patched: same time

removed vgasys.fon: 4 - 6 seconds

So your patch does not help.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #10 from Marcus Meissner   2010-07-16 13:58:07 ---
Created an attachment (id=29633)
 --> (http://bugs.winehq.org/attachment.cgi?id=29633)
0011-gdi32-do-not-add-already-cached-fonts-to-the-cache.patch

first patch

This checks the cache before adding the bitmap font anew without the
conditrional can_use_bitmap.

it reduces page flip time from 10 to 5 seconds for me.

It still accesses the disk like totally mad during this 5 seconds.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #11 from Marcus Meissner   2010-07-16 14:22:50 ---
debugging further.

it seems to decide to use vgasys.fon as selected font.
This is named "System"

but create_child_font_list() suddenly finds tahoma.ttf which is also listed
as "System" font.

confusion results I think.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #12 from Marcus Meissner   2010-07-18 16:01:01 ---
i meanwhile think my patch is wrong, as it does not cache
stuff in "can_use_bitmap=TRUE" case at all. :/

the speedup is curious.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

--- Comment #13 from Marcus Meissner   2010-07-18 16:36:04 ---
fixme:font:WineEngCreateFontInstance cache length now 4325 entries

... something is bad however.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27887|0                           |1
        is obsolete|                            |
  Attachment #29633|0                           |1
        is obsolete|                            |
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #14 from Marcus Meissner   2010-07-19 17:53:58 ---
Created an attachment (id=29715)
 --> (http://bugs.winehq.org/attachment.cgi?id=29715)
0011-gdi32-rebuild-font-hash-after-matrix-change

nearly correct fix.

also submitted to wine-patches

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
            Version|1.1.40                      |1.2
         Resolution|                            |FIXED
   Target Milestone|---                         |1.2.x

--- Comment #15 from Marcus Meissner   2010-07-21 11:03:55 ---
fixed in GIT master.

asking for 1.2.x stable inclusion too:

sha1 2f7ec73adde1a87f788eebcf66ec8dd16bf9109f

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.2                         |1.1.40

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2010-07-30 12:57:52 ---
Closing bugs fixed in 1.3.0.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

http://bugs.winehq.org/show_bug.cgi?id=22021

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.x                       |---

--- Comment #17 from Alexandre Julliard  2010-10-08 10:41:06 CDT ---
Removing 1.2.x milestone from bugs fixed in 1.2.1.

[Bug 22021] Switching pages in ElsterFormular 2009/2010 needs much time

https://bugs.winehq.org/show_bug.cgi?id=22021

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2f7ec73adde1a87f788eebcf66e
                   |                            |c8dd16bf9109f
                 CC|                            |[e-mail]