[Bug 20991] New: EnumRfc1766_create return values

http://bugs.winehq.org/show_bug.cgi?id=20991

Summary: EnumRfc1766_create return values
           Product: Wine
           Version: 1.1.34
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: mlang
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

EnumRfc1766_create is supposed to return HRESULT values, but returns FALSE in
one case (dlls/mlang/mlang.c:2517) - this should be changed to S_FALSE I guess.

On the other hand the return values of the function are evaluated with the
FAILED macro (see mlang.c:1250) and S_FALSE does not count as failed - so
probably both unsuccessful returns (lines 2504 and 2517) should be E_FAIL?

[Bug 20991] EnumRfc1766_create return values

http://bugs.winehq.org/show_bug.cgi?id=20991

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Juan Lang   2009-12-11 09:26:18 ---
Good catch.  I'd suggest E_OUTOFMEMORY for line 2504.  Line 2517 could be
E_FAIL, I suppose, or you could extend enum_locales_data and enum_locales_proc
to store a more appropriate error code, E_OUTOFMEMORY in case memory allocation
fails (line 2464), and something else if it couldn't be parsed (line 2471.)

Feel free to send a patch.

[Bug 20991] EnumRfc1766_create return values

http://bugs.winehq.org/show_bug.cgi?id=20991

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Juan Lang   2009-12-14 09:57:14 ---
Fixed by commit 3fa550b5325a6ff19c8eb435d2f4ce025eb8d97a.  Thanks!

[Bug 20991] EnumRfc1766_create return values

http://bugs.winehq.org/show_bug.cgi?id=20991

--- Comment #3 from Gregor Schneider   2009-12-14 12:14:35 ---
Thanks for your help!

[Bug 20991] EnumRfc1766_create return values

http://bugs.winehq.org/show_bug.cgi?id=20991

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2009-12-18 13:08:15 ---
Closing bugs fixed in 1.1.35.