https://bugs.winehq.org/show_bug.cgi?id=56102
Bug ID: 56102 Summary: Comdlg32/Color - Out of bound value is used Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comdlg32 Assignee: [email protected] Reporter: [email protected] Distribution: ---
- Set HSV to max value by typing 999 - Automatically sets to 239, 240, 240 Scenario 1 : - Click on the 2D spectrum - Lum gets to 999 => should stay to 240 Scenario 2 : - Click on right ribbon - H & S gets to 999 and ribbon gets crazy
Faulty code is CC_CheckDigitsInEdit where the raw value is returned even when exceeding max value
if (value > maxval) /* build a new string */ { sprintf(buffer, "%d", maxval); result = 2; }
should be replaced by
if (value > maxval) /* build a new string */ { value = maxval; sprintf(buffer, "%d", maxval); result = 2; }
https://bugs.winehq.org/show_bug.cgi?id=56102
Fabian Maurer [email protected] changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected]
--- Comment #1 from Fabian Maurer [email protected] --- Is there a test program for this?
https://bugs.winehq.org/show_bug.cgi?id=56102
--- Comment #2 from KRosUser [email protected] --- Created attachment 76526 --> https://bugs.winehq.org/attachment.cgi?id=76526 color picker bug in Wine 9.9
https://bugs.winehq.org/show_bug.cgi?id=56102
--- Comment #3 from KRosUser [email protected] --- ReactOS mspaint (eg https://jira.reactos.org/browse/CORE-19402 ) in Wine 9.9 (see screenshot) or any sample app that would open commdlg colorpicker and then following scenarion below.
https://bugs.winehq.org/show_bug.cgi?id=56102
Fabian Maurer [email protected] changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |9.9 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords| |download, source
--- Comment #4 from Fabian Maurer [email protected] --- Thanks, merge request created: https://gitlab.winehq.org/wine/wine/-/merge_requests/5756
Please feel free to ping/CC me on similar issues if you want help having some change upstreamed.
https://bugs.winehq.org/show_bug.cgi?id=56102
--- Comment #5 from KRosUser [email protected] --- OK thanks !
https://bugs.winehq.org/show_bug.cgi?id=56102
Ken Sharp [email protected] changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |8d2977ec12e234880199bc07daf | |49870d0aa64ec Resolution|--- |FIXED
--- Comment #6 from Ken Sharp [email protected] --- Change merged. https://gitlab.winehq.org/wine/wine/-/commit/8d2977ec12e234880199bc07daf4987...
https://bugs.winehq.org/show_bug.cgi?id=56102
Alexandre Julliard [email protected] changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard [email protected] --- Closing bugs fixed in 9.17.