http://bugs.winehq.org/show_bug.cgi?id=29750
Bug #: 29750 Summary: Spotify crash when I use the search box Product: Wine Version: 1.3.37 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: mathdabomb@gmail.com Classification: Unclassified
Created attachment 38606 --> http://bugs.winehq.org/attachment.cgi?id=38606 wine log file
When I search an song or a artist with the search box, when the result is displyed on the Spotify screen, It crash.
Spotify version : 0.8.1.76.g4773b858
http://bugs.winehq.org/show_bug.cgi?id=29750
mathdabomb mathdabomb@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal
--- Comment #1 from mathdabomb mathdabomb@gmail.com 2012-01-30 13:03:39 CST --- When I select artists, most popular song or songs ==> no problem. When I select playlists and All results ==> Crash
http://bugs.winehq.org/show_bug.cgi?id=29750
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Spotify crash when I use |Spotify crashes when |the search box |searching song or artist | |with the search box
http://bugs.winehq.org/show_bug.cgi?id=29750
Jan-Peter Nilsson peppe@bsnet.se changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |peppe@bsnet.se
--- Comment #2 from Jan-Peter Nilsson peppe@bsnet.se 2012-02-18 04:27:15 CST --- Hi
With a recent update of Spotify I also hit this problem.
After some debugging it turns out that the reason is that Spotify have started sending queries to api.facebook.com and the winhttp callbacks RESOLVING_NAME/NAME_RESOLVED/CONNECTING_TO_SERVER/CONNECTED_TO_SERVER does not contain the context given to WinHttpSendRequest(). So instead of the expected context value Spotify gets 0 and tries to use that.
Setting request->hdr.context directly in WinHttpSendRequest() resolves the problem for me.
Based on the traces it seems likely that a few other Spotify bugs share the same root cause. Bug 29784 - Spotify collapse at starting Bug 27476 - Spotify Crashes On Log In Bug 27820 - Spotify 0.5.44 crashes when the contact list is displayed Bug 27742 - Spotify: Random Page Faults
I am however not seeing those bugs myself, probably due to having an old Spotify account that is not connected to facebook.
http://bugs.winehq.org/show_bug.cgi?id=29750
--- Comment #3 from Jan-Peter Nilsson peppe@bsnet.se 2012-02-18 04:28:51 CST --- Created attachment 38941 --> http://bugs.winehq.org/attachment.cgi?id=38941 winhttp: Make WinHttpSendRequest set the context on the request handle
http://bugs.winehq.org/show_bug.cgi?id=29750
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |adys.wh@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29750
--- Comment #4 from Hans Leidekker hans@meelstraat.net 2012-02-18 05:03:52 CST --- (In reply to comment #3)
Created attachment 38941 [details] winhttp: Make WinHttpSendRequest set the context on the request handle
send_request already sets the context, but too late. You should instead move the assignment in send_request to before the open_connection call.
http://bugs.winehq.org/show_bug.cgi?id=29750
--- Comment #5 from Jan-Peter Nilsson peppe@bsnet.se 2012-02-18 06:49:58 CST --- (In reply to comment #4)
send_request already sets the context, but too late. You should instead move the assignment in send_request to before the open_connection call.
True, thank you for pointing that out.
http://bugs.winehq.org/show_bug.cgi?id=29750
Jan-Peter Nilsson peppe@bsnet.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #38941|0 |1 is obsolete| |
--- Comment #6 from Jan-Peter Nilsson peppe@bsnet.se 2012-02-18 06:53:52 CST --- Created attachment 38943 --> http://bugs.winehq.org/attachment.cgi?id=38943 winhttp: Set the context on the request handle earlier
http://bugs.winehq.org/show_bug.cgi?id=29750
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |winhttp
--- Comment #7 from Hans Leidekker hans@meelstraat.net 2012-02-18 08:57:08 CST --- (In reply to comment #6)
Created attachment 38943 [details] winhttp: Set the context on the request handle earlier
Yep, please send it to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=29750
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3de7348f72e28b2744032b6eb83 | |795163ee386ed Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #8 from Hans Leidekker hans@meelstraat.net 2012-02-20 13:25:53 CST --- Fixed, thanks.
http://bugs.winehq.org/show_bug.cgi?id=29750
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2012-02-24 12:49:11 CST --- Closing bugs fixed in 1.4-rc5.
-
wine-bugs＠winehq.org