[Bug 16838] New: 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

Summary: 'make install' broken on BSD
           Product: Wine
           Version: 1.1.12
          Platform: PC
        OS/Version: OpenBSD
            Status: NEW
          Keywords: patch, source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

/usr/bin/install -c   acledit.dll.so /usr/local/lib/wine/acledit.dll.so
/usr/bin/install -c   activeds.dll.so /usr/local/lib/wine/activeds.dll.so
/usr/bin/install -c  -m 644  libactiveds.$(IMPLIBEXT)
/usr/local/lib/wine/libactiveds.$(IMPLIBEXT)
/bin/sh: IMPLIBEXT: not found
/bin/sh: IMPLIBEXT: not found
install: libactiveds.: No such file or directory
*** Error code 71

Stop in /home/austin/wine-git/dlls/activeds (line 435 of Makefile).
*** Error code 1

Stop in /home/austin/wine-git/dlls (line 614 of Makefile).
*** Error code 1

Stop in /home/austin/wine-git (line 326 of Makefile).

I see this in both OpenBSD and PC-BSD.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #1 from Austin English   2009-02-19 12:26:46 ---
Seems to be a problem with BSD make. Using 'gmake install' instead works fine.

Still annoying, since BSD make works otherwise.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

sebastian  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sebastia@l00-bugdead-
                   |                            |prods.de

--- Comment #2 from sebastian   2009-02-19 15:07:24 ---
using gmake, installation actually stops here:

gmake[1]: Leaving directory
`/usr/ports/emulators/wine/w-wine-1.1.15/wine-1.1.15/tools'
./tools/mkinstalldirs -m 755
/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/local/share/aclocal
mkdir
/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/local/share/aclocal
chmod 755
/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/local/share/aclocal
install -c -o root -g bin -m 444  ./aclocal.m4
/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/ports/emulators/wine/w-wine-1.1.15/fake-i386/usr/local/share/aclocal/wine.m4
Makefile:43: *** missing separator.  Stop.
*** Error code 2

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #3 from Austin English   2009-02-20 10:38:42 ---
This is on PC-BSD with GNU make 3.81.

I'd already done ./configure && make depend && make with BSD make, as well as
an attempted make install with BSD make.

Didn't test Net/OpenBSD.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Alexandre Julliard   2009-02-26 13:02:28 ---
Hopefully fixed by a67d80b4a6107f7301f399f1b14d19e277fa022c.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #5 from Austin English   2009-02-26 13:24:18 ---
Created an attachment (id=19678)
 --> (http://bugs.winehq.org/attachment.cgi?id=19678)
make log

Doesn't look like it here.

Ran:
# gmake uninstall

To be sure we had a clean slate.

Then
# make install
to use BSD make, but no dice.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #6 from Austin English   2009-02-26 13:24:38 ---
Reopening.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #7 from Alexandre Julliard   2009-02-26 13:32:24 ---
OK that's a different issue, it tries to build install from install.c. Sounds
like that make is seriously brain-damaged.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #8 from Austin English   2009-02-26 13:34:07 ---
(In reply to comment #7)
> OK that's a different issue, it tries to build install from install.c. Sounds
> like that make is seriously brain-damaged.

Perhaps a sanity check in configure is needed? Or start requiring GNU make?

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #9 from Alexandre Julliard   2009-02-26 13:45:28 ---
(In reply to comment #8)
> Perhaps a sanity check in configure is needed? Or start requiring GNU make?

There shouldn't be any reason to require GNU make, most makes handle this just
fine, this one is clearly broken. What's the exact version you are using?

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #10 from Austin English   2009-02-26 13:55:13 ---
(In reply to comment #9)
> (In reply to comment #8)
> > Perhaps a sanity check in configure is needed? Or start requiring GNU make?
>
> There shouldn't be any reason to require GNU make, most makes handle this just
> fine, this one is clearly broken. What's the exact version you are using?

make -v ; make -V ; make --version don't specify a version.

man make doesn't either, only says FreeBSD 7.0.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #11 from Austin English   2009-03-02 20:38:32 ---
FWIW:
http://www.freebsd.org/cgi/man.cgi?query=make&sektion=1

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Alexandre Julliard   2009-03-03 12:21:17 ---
Looks like a target without source confuses it. I added a workaround.

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

--- Comment #13 from Austin English   2009-03-03 13:22:39 ---
(In reply to comment #12)
> Looks like a target without source confuses it. I added a workaround.

Yes sir. Works fine now. Thanks!

[Bug 16838] 'make install' broken on BSD

http://bugs.winehq.org/show_bug.cgi?id=16838

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard   2009-03-13 11:15:43 ---
Closing bugs fixed in 1.1.17.