[Bug 41837] New: Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

Bug ID: 41837
           Summary: Way of the Samurai 4 has black blocks in the main menu
                    without native d3dx9
           Product: Wine
           Version: 1.9.24
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3dx9
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 56261
  --> https://bugs.winehq.org/attachment.cgi?id=56261
Wine 1.9.24 without "winetricks d3dx9"

I have a 32-bit Windows XP prefix in Wine 1.9.24 with the following overrides
installed via winetricks:

amstream
quartz
devenum
wmp9
physx
d3dcompiler_43

(These winetricks are required to even be able to start the game...)

If I do not run the command "winetricks d3dx9" then the main menu has black
blocks in the main menu.

I've tried installing the individual d3dx9 dlls ( d3dx9_36, d3dx9_26, d3dx9_43,
d3dx9_39, d3dx9_42, d3dx9_35, d3dx9_31, d3dx9_28) that are available to install
via winetricks but none of those helped.

Terminal output without "winetricks d3dx9" being ran has been attached.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

--- Comment #1 from [e-mail] ---
Created attachment 56262
  --> https://bugs.winehq.org/attachment.cgi?id=56262
Main menu without "winetricks d3dx9"

Main menu before I ran the "winetricks d3dx9" command.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

--- Comment #2 from [e-mail] ---
Created attachment 56263
  --> https://bugs.winehq.org/attachment.cgi?id=56263
Main menu after "winetricks d3dx9"

After I ran the "winetricks d3dx9" command the main menu looks as it should.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
For Paul Gofman,

Can you take a look at the terminal output and let me know if this bug is
related to any d3dx9 base effect issues? Also, let me know if you need more
info on this bug :)

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
(In reply to fjfrackiewicz from comment #3)
> For Paul Gofman,
>
> Can you take a look at the terminal output and let me know if this bug is
> related to any d3dx9 base effect issues? Also, let me know if you need more
> info on this bug :)

Have you tried more recent wine? The log I looked is from old wine, some of
those messages if not all shouldnt be printed at all.

I think you need wine-git in this case. I don't have this game. can you provide
more up to date log?

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

--- Comment #5 from Paul Gofman  ---
Created attachment 58082
  --> https://bugs.winehq.org/attachment.cgi?id=58082
Add 'log' preshader opcode.

(In reply to winetest from comment #4)
> Have you tried more recent wine? The log I looked is from old wine, some of
> those messages if not all shouldnt be printed at all.
>
> I think you need wine-git in this case. I don't have this game. can you
> provide more up to date log?

Besides the problems that should go away with the current git, the log
indicates a missing preshader opcode which is not there yet. If anyone minds
testing that, I am attaching the patch (on top of the current git) which adds
the missing opcode. I was going to suggest that upstream regardless at some
point, testing this patch now will just indicate if this is the only remaining
problem here or there are some others.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

--- Comment #6 from [e-mail] ---
(In reply to Paul Gofman from comment #5)
> Created attachment 58082 [details]
> Add 'log' preshader opcode.
>
> (In reply to winetest from comment #4)
> > Have you tried more recent wine? The log I looked is from old wine, some of
> > those messages if not all shouldnt be printed at all.
> >
> > I think you need wine-git in this case. I don't have this game. can you
> > provide more up to date log?
>
> Besides the problems that should go away with the current git, the log
> indicates a missing preshader opcode which is not there yet. If anyone minds
> testing that, I am attaching the patch (on top of the current git) which
> adds the missing opcode. I was going to suggest that upstream regardless at
> some point, testing this patch now will just indicate if this is the only
> remaining problem here or there are some others.

Hi Paul,

Thank you for looking into the issue :)

My test of your patch will be slightly delayed for a couple of reasons:

1. Way of the Samurai 4 now requires an unimplemented function in Wine 2.7 in
d3dx9_38 ( see bug 22682 )

2. I've ran into an issue with winegstreamer that I am currently attempting to
resolve on my end as somewhere along the line there have been additional plug
ins or something added along the line. Right now, I am updating everything
Gstreamer-related on my system before filing a bug.

Once I get everything done in item #2, I'll test your patch :)

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22682

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Gijs Vermeulen  ---
Should be fixed by:
https://source.winehq.org/git/wine.git/commit/651e8bfaee90870d430a7fb045382a...

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

--- Comment #8 from Paul Gofman  ---
(In reply to Gijs Vermeulen from comment #7)
> Should be fixed by:
> https://source.winehq.org/git/wine.git/commit/
> 651e8bfaee90870d430a7fb045382a803037c260

According to comment #6, it should be not exactly fixed but rather become a
duplicate of bug #22682 (which is staged though).

I suppose it was not crashing on D3DXGetShaderInputSemantics with older Wine
because GetPassDesc was not returning any shaders (setting NULLs in structure).
Now when it returns shaders the game wants to know their input semantics.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

--- Comment #9 from Gijs Vermeulen  ---
(In reply to Paul Gofman from comment #8)
> (In reply to Gijs Vermeulen from comment #7)
> > Should be fixed by:
> > https://source.winehq.org/git/wine.git/commit/
> > 651e8bfaee90870d430a7fb045382a803037c260
>
> According to comment #6, it should be not exactly fixed but rather become a
> duplicate of bug #22682 (which is staged though).
>
> I suppose it was not crashing on D3DXGetShaderInputSemantics with older Wine
> because GetPassDesc was not returning any shaders (setting NULLs in
> structure). Now when it returns shaders the game wants to know their input
> semantics.

I see, thanks for the explanation :)

As soon as someone confirms, this could be marked as a dupe then :)

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |651e8bfaee90870d430a7fb0453
                   |                            |82a803037c260
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Matteo Bruni  ---
As far as I understand, this bug is fixed. Next bug for this game is bug 22682.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 2.9.

[Bug 41837] Way of the Samurai 4 has black blocks in the main menu without native d3dx9

https://bugs.winehq.org/show_bug.cgi?id=41837
Bug 41837 depends on bug 22682, which changed state.

Bug 22682 Summary: Multiple games need function d3dx9_36.dll.D3DXGetShaderInputSemantics (Far Cry 2/3, Avatar, Faery: Legends of Avalon, Civilization 4, Deathspank, Of Orcs and Men)
https://bugs.winehq.org/show_bug.cgi?id=22682

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |RESOLVED
         Resolution|---                         |FIXED