[Bug 13823] New: Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Summary: Bad region repaint
           Product: Wine
           Version: 1.0-rc4
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I'm using an ERP client that works quite well with Wine 0.9.46. 
After that version something is changed and background windows does not
correctly redraws when you close the top one.
The app uses MDI windows, so all child windows are in the main frame window
context. If you close a top level child window the back one does not redraw
itself.
It seems that invalidate regions are changed after the 0.9.46 version(an
optimization?), resulting in a wrong paint area.
Thanks,
Simone Tregnago

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdi32                       |-unknown

--- Comment #1 from Dmitry Timoshkov   2008-06-10 06:47:37 ---
Please perform a regression test as outlined here:

http://wiki.winehq.org/RegressionTesting

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #2 from Austin English   2008-12-08 04:21:21 ---
Abandoned.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Austin English   2008-12-08 04:23:20 ---
Closing.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Simone Tregnago  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simonetregnago@grivaonline.c
                   |                            |om
             Status|CLOSED                      |UNCONFIRMED
         Resolution|ABANDONED                   |

--- Comment #4 from Simone Tregnago   2008-12-18 05:56:00 ---
Sorry for the last delay, I've not seen your request about regression
testing.
Now, after a lot of compiling, I've found the patch that caused the bug:

b90baa11276d06531390c14912622a850cf52286 is first bad commit
commit b90baa11276d06531390c14912622a850cf52286
Author: Alexandre Julliard 
Date:   Tue Jan 22 20:30:04 2008 +0100

winex11: Properly invalidate moved child windows instead of forcing
SWP_NOCOPYBITS.

Add a move_window_bits() function where the missing functionality of
    moving the window contents should go.

:040000 040000 9ff1e8612e8dbf21927347a385d825f0e9f724d7
fe3bbe881555dc068c4d5d0addd228140f38408f M      dlls

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Simone Tregnago  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
          Component|-unknown                    |winex11.drv
     Ever Confirmed|0                           |1

--- Comment #5 from Damjan Jovanovic   2008-12-18 14:13:11 ---
Seems reasonable, confirming, setting component.

Does this still happen with wine 1.1.10?

Also is there a demo version of this software? If not, are you willing to test
some patches?

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #6 from Simone Tregnago   2008-12-19 03:28:25 ---
Yes, 1.1.10 is also affected.

It's a client/server ERP, so it's difficult to organize a demo version.
It's certainly easier if you could send me patches to test.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #7 from Damjan Jovanovic   2008-12-19 11:03:34 ---
Ok, go to commit f1a0348b4e17170a9e6406869fbbd3db8b368597 (git reset --hard
f1a0348b4e17170a9e6406869fbbd3db8b368597) and verify that version redraws fine:
that's just before the bad commit. If it doesn't, let me know.

I will next be attaching a series of patches. Test each one individually (ie.
remove all previous ones before trying each one) and report which ones work and
which don't. You only need to compile and install winex11.drv after each patch.
They all apply to f1a0348b4e17170a9e6406869fbbd3db8b368597, not to the latest
Git or anything like that.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #8 from Damjan Jovanovic   2008-12-19 11:04:55 ---
Created an attachment (id=18071)
 --> (http://bugs.winehq.org/attachment.cgi?id=18071)
patch 1

First patch to test. Others coming later.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #9 from Simone Tregnago   2008-12-22 07:59:08 ---
Thanks Damjan,
I've tried the f1a0348b4e17170a9e6406869fbbd3db8b368597 with the first patch.
The windows redraws correctly (before and after the patch)

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #10 from Simone Tregnago   2009-02-27 05:00:15 ---
Damjan, any news? Could you send me other patches to try with?

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #11 from Damjan Jovanovic   2009-04-11 07:07:28 ---
Created an attachment (id=20379)
 --> (http://bugs.winehq.org/attachment.cgi?id=20379)
patch 2

Ok, try this patch from the same Git version
(f1a0348b4e17170a9e6406869fbbd3db8b368597).

(Sorry for taking so long, I've been busy).

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #12 from Simone Tregnago   2009-04-14 04:46:18 ---
(In reply to comment #11)
> Created an attachment (id=20379)

--> (http://bugs.winehq.org/attachment.cgi?id=20379) [details]
> patch 2
>
> Ok, try this patch from the same Git version
> (f1a0348b4e17170a9e6406869fbbd3db8b368597).
>
> (Sorry for taking so long, I've been busy).

I've tried the second patch.
The windows redraws correctly (before and after the patch)

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

--- Comment #13 from Austin English   2009-10-12 14:55:41 ---
Is this still an issue in current (1.1.31 or newer) wine?

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #14 from Austin English   2010-05-19 16:26:38 ---
Is this still an issue in current (1.1.44 or newer) wine?

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |b90baa11276d06531390c149126
                   |                            |22a850cf52286

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from joaopa  2011-12-28 18:35:07 CST ---
No answer since 2 years and no demo available. This bug could be closed as
ABANDONED.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Abandoned?
                 CC|                            |[e-mail]

--- Comment #16 from Frédéric Delanoy  2012-02-01 07:40:17 CST ---
Does it still occur in current wine (1.4-rc1 or later)?

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Abandoned?                  |
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |ABANDONED

--- Comment #17 from Jerome Leclanche  2012-02-01 09:44:44 CST ---
Resolving abandoned. Please report with wine-1.4-rc1 or newer if you want to
reopen this.

[Bug 13823] Bad region repaint

http://bugs.winehq.org/show_bug.cgi?id=13823

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Jerome Leclanche  2012-02-01 09:44:51 CST ---
Closing