[Bug 16536] New: EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Summary: EVE Online: incorrect object selection size, regression
           Product: Wine
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Current wine version re-introduced issue #14245. Refer to its description for
additional info on bug. Commit that broke correct selection size:

0dc0444c14c34cf90aba8b8a1af401571c959ccd is first bad commit
commit 0dc0444c14c34cf90aba8b8a1af401571c959ccd
Author: Stefan Dösinger 
Date:   Mon Dec 15 19:14:15 2008 +0100

wined3d: Reinstall the G16R16F format surface load fixup.

We cannot remove this because we still have to load the surface as
    RGB. The shader may take care of setting the blue channel to 1.0 now,
    but we still get the red and green channels loaded incorrectly if we
    don't insert a blue channel before loading.

:040000 040000 e480f62a88bf8f22b400c9bcafd63ba0da9e1227
0929cdef27cdc2d41c140ce52d6d09d65799a940 M      dlls

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Anton Vorobyov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Anton Vorobyov   2008-12-16 17:07:21 ---
Uhm, forgot to add Stefan's email. Looping him in.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Anton Vorobyov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.eve-online.com/
           Keywords|                            |download, regression

--- Comment #2 from Anton Vorobyov   2008-12-16 17:10:43 ---
Updated metadata.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #3 from Anton Vorobyov   2008-12-16 17:31:15 ---
Just noticed, wine writes following line to output on each right-click
triggering context menu of object:

fixme:d3d_surface:surface_download_data Read back converted textures
unsupported, format=WINED3DFMT_G16R16

Adding direct link to re-introduced issue for everybody's convenience:

http://bugs.winehq.org/show_bug.cgi?id=14245

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Francesco Munda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Francesco Munda   2008-12-17 06:02:39 ---
*** This bug has been confirmed by popular vote. ***

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #5 from Stefan Dösinger   2008-12-17 06:52:06 ---
It kinda surprises me that this bug could ever be seen fixed. The patch that
"fixed" this problem supposedly caused eve to crash on startup...

The patch itself isn't wrong, it just brings up an existing bug somewhere else.
It probably was hidden because G16R16 was broken without that patch

The "fixme:d3d_surface:surface_download_data Read back converted textures
unsupported, format=WINED3DFMT_G16R16" sounds like a good starting point here.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #6 from Anton Vorobyov   2008-12-17 07:01:30 ---
I didn't track down commit that fixed issue, could you tell me which one - just
interesting.

As for crash on startup - i really don't know about which issue you're talking,
never got these (EVE on my rig sometimes just silently dies on startup when
splash screen is shown, but it occurs every now and then without any noticeable
dependencies).

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #7 from Stefan Dösinger   2008-12-17 07:07:13 ---
The patch log mentions a commit that introduced a regression.

The crash only occurred with the premium client, but it was clearly a bug in
the original patch.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #8 from Anton Vorobyov   2008-12-17 07:16:21 ---
Currently i'm looking for commit that fixed bug 14245, will that help? :)

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #9 from Anton Vorobyov   2008-12-17 08:11:13 ---
e04556bb166804edc5c6cb16e6001b25aab9563e is commit that temporarily fixed bug
14245
commit e04556bb166804edc5c6cb16e6001b25aab9563e
Author: Stefan Dösinger 
Date:   Wed Dec 3 14:53:43 2008 +0100

wined3d: Fix D3DFMT_R32F, R16F, G16R16F, ... in the pixel shader.

This allows us to drop the load time conversion and the clear
    readback hack and replaces it with a color fixup in the fixed
    function pipeline replacement.

:040000 040000 9b0bf9d78dc4786c9fc888e784e2b33dd05986d0
f83edfc8c1ff69e2f23372cfa472205f681cbade M      dlls

Between these to commits (e04556bb166804edc5c6cb16e6001b25aab9563e ...
0dc0444c14c34cf90aba8b8a1af401571c959ccd), when everything was okay from
player's perspective, wine didn't write

fixme:d3d_surface:surface_download_data Read back converted textures
unsupported, format=WINED3DFMT_G16R16

into console when clicking on some objects (e.g. player's ship).

So yep, it seems you're right, eve/wine used some fallback mechanism, and
G16R16 format was broken between these commits...

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

rig0r  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #10 from rig0r   2009-02-09 12:02:52 ---
I would like to add that when wine outputs the

fixme:d3d_surface:surface_download_data Read back converted textures
unsupported, format=WINED3DFMT_G16R16

message to the console, the game freezes for about half a second.

This only seems to happen around large objects like stations and gates.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #11 from Anton Vorobyov   2009-02-13 13:15:39 ---
Preliminary testing shows that issue is should be gone with following expansion
(Apocrypha), at least when scene 2 is enabled.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

--- Comment #12 from rig0r   2009-02-14 13:47:13 ---
(In reply to comment #11)
> Preliminary testing shows that issue is should be gone with following expansion
> (Apocrypha), at least when scene 2 is enabled.

I was unable to reproduce this, I still get the errors and hickups with the
latest test client on Sisi with scene 2 enabled.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Florent  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Florent   2009-03-07 02:53:57 ---
Hello

I use Gentoo amd64 "stable" freshly compiled.

I confirm that the problem is present in wine 1.1.12 (compiled with Gentoo
ebuild)
I've tried 1.1.16 too and same problem happen 
Same in 1.1.0 ...

Anyway it is playable .. need to zoom out and then click away from the station
...

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Anton Vorobyov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Anton Vorobyov   2009-03-14 16:10:00 ---
Resolved on eve's side.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |ABANDONED

--- Comment #15 from Vitaliy Margolen   2009-03-15 12:04:10 ---
That's not fixed.

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Vitaliy Margolen   2009-03-15 12:04:34 ---
Closing

[Bug 16536] EVE Online: incorrect object selection size, regression

http://bugs.winehq.org/show_bug.cgi?id=16536

rig0r  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |