[Bug 55268] New: user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55268

Bug ID: 55268
           Summary: user32:cursoricon - LoadImageA() fails in
                    test_monochrome_icon() on Windows 8+
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]

user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+:

cursoricon.c:2853: monochrome, bitmap info
cursoricon.c:2917: Test failed: LoadImage() failed with 0.

See https://test.winehq.org/data/patterns.html#user32:cursoricon

The call below has been failing systematically on Windows 8+ for more than 8
months:

handle = LoadImageA(NULL, "icon.ico", IMAGE_ICON, 0, 0,
LR_LOADFROMFILE);
        ok(handle != NULL ||
           broken(use_core_info && handle == NULL), /* Win 8, 10 */
           "LoadImage() failed with %lu.\n", GetLastError());

So on Windows 8+ we expect to get NULL only if use_core_info is true but in
fact we get NULL even if it is false. That makes this test pretty pointless.

[Bug 55268] user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55268

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase
                 CC|                            |[e-mail]

[Bug 55268] user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55268

Jeff Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jeff Smith  ---
Based on current test results, it appears 'core' was broken even in Win 7, and
what quit working with Win 8 is 'monochrome'.  The combination "colored, bitmap
info" is the only one that still works in Win 8+.

It seems
  broken(use_core_info && handle == NULL), /* Win 8, 10 */
should be
  broken((use_core_info || monochrome) && handle == NULL), /* Win 8, 10 */

That said, if it has been this way consistently since Win 8, should we
re-evaluate marking it broken?

[Bug 55268] user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55268

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from François Gouget  ---
I think it should be considered normal behavior. So the check should be
something like this?

ok(handle != NULL ||
     (use_core_info || monochrome) && handle == NULL), /* Win 8, 10 */
     ...

[Bug 55268] user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55268

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0ab411a047b7c12abfa8906da87
                   |                            |b410ef29f013c
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #3 from Rémi Bernon  ---
Fixed with 0ab411a047b7c12abfa8906da87b410ef29f013c.

[Bug 55268] user32:cursoricon - LoadImageA() fails in test_monochrome_icon() on Windows 8+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55268

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 9.1.