[Bug 13819] New: Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Summary: Wrong codepage used for console output
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

To reproduce this problem, run the following command (that's assuming you have
a UTF-8 xterm, otherwise replace UTF-8 with ISO-8859-1 or the appropriate
encoding):

LANG=fr_FR.UTF-8 ./programs/start/start /help

You will notice that all the accentuated characters are missing. This is
because start.c converts the Unicode resource string to the
GetConsoleOutputCP() encoding in the output() function. I think that's correct
but GetConsoleOutputCP() systematically return "850" as the codepage, even if I
change the [Nls\Codepage]/OEM value in the registry.

One hack to fix this is to replace the GetConsoleOutputCP() call with CP_UNIXCP
but I guess that would be wrong in the case where we're running in the Wine
console.

So I think that when the console is a regular Unix terminal
GetConsoleOutputCP() should return the CP_UNIXCP codepage.

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]-
                   |                            |berlin.de

--- Comment #1 from François Gouget   2008-06-12 04:42:49 ---
*** Bug 13862 has been marked as a duplicate of this bug. ***

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Austin English   2008-10-24 10:37:03 ---
*** Bug 15736 has been marked as a duplicate of this bug. ***

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #3 from Austin English   2009-01-20 02:39:11 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Zhenya  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Zhenya   2009-06-12 08:14:22 ---
Is this a bug? I think, this is a feature.

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

--- Comment #5 from François Gouget   2009-06-12 10:10:26 ---
> Is this a bug? I think, this is a feature.

How so?

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

--- Comment #6 from Andrew Zabolotny   2009-06-15 03:58:16 ---
This is a case of program generating incorrect results in a perfectly valid
situation, so I'd classify this as a bug.

Perhaps GetConsoleOutputCP() should call some method of the driver, and let the
driver decide what's the correct console codepage. I have the same bug with my
linux console using UTF-8 (or CP1251) and GetConsoleOutputCP() returning 866,
so any cyrillic output I see is in incorrect encoding (just run 'wine cmd').

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Dmitry Timoshkov   2009-06-18 22:17:22 ---
*** Bug 10425 has been marked as a duplicate of this bug. ***

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |t

--- Comment #8 from Jörg Höhle   2009-12-17 12:53:51 ---
Dmitry Timoshkov pointed me to this code page issue.  I've extracted out of bug
#19253, comment #1 the following issue that I believe is close enough to the
present one not to merit its own bug page:

Code pages or rather Umlauts are handled inconsistently between
a) wine cmd /c help
b) wine readme.txt # assuming this file exists
   wine: Fehlerhaftes EXE-Format f<?>r Z:...\readme.txt

Using LANG=de_DE.UTF-8 in gnome-terminal in Ubuntu Intrepid with wine-1.1.34.

Invoking them in an Emacs shell buffer reveals what's actually output:
a) 129 for ü in the cmd help page (DOS CP850),
b) 252 for ü in case b) (CP1252/ISO Latin).

In a gnome-terminal, depending on your settings, you'll see as Umlaut either a
strange character with a question mark inside, or simply a blank.

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Dmitry Timoshkov   2010-02-16 03:31:34 ---
*** Bug 13189 has been marked as a duplicate of this bug. ***

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

--- Comment #10 from Luca Bennati   2010-02-16 04:00:45 ---
Finally found the bug for this problem
Still an issue in wine-1.1.38-219-g438ad93

I want to ask since i don't really know this code, how much is difficult this
task? If not so much, could it be done before 1.2?

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Eric Pouech  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Eric Pouech  2010-09-01 14:43:16 CDT ---
some evolutions of console management have found their way into git tree (and
are said to fix this one)
please retest
A+

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Frédéric Delanoy  2010-09-01 17:44:30 CDT ---
(In reply to comment #11)
> some evolutions of console management have found their way into git tree (and
> are said to fix this one)
> please retest
> A+

Now works.

Thanks

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #13 from Wylda  2010-09-01 18:43:54 CDT ---

Reported fixed.

[Bug 13819] Wrong codepage used for console output

http://bugs.winehq.org/show_bug.cgi?id=13819

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  2010-09-03 14:05:06 CDT ---
Closing bugs fixed in 1.3.2.