https://bugs.winehq.org/show_bug.cgi?id=50464
Bug ID: 50464 Summary: Process Hacker 3.x needs ntdll.dll.RtlGetFullPathName_UEx Product: Wine Version: 6.0-rc5 Hardware: x86-64 URL: https://ci.appveyor.com/api/buildjobs/9slxi3pkcyxcd2kf /artifacts/processhacker-3.0.3701-bin.zip OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: the.ideals@gmail.com Distribution: ---
wine: Call from 7BC2AEFA to unimplemented function ntdll.dll.RtlGetFullPathName_UEx, aborting
sha1sum processhacker-3.0.3701-bin.zip 8192c09315794887e144b6e499588fb633923bae processhacker-3.0.3701-bin.zip
du -sh processhacker-3.0.3701-bin.zip 6.1M processhacker-3.0.3701-bin.zip
https://github.com/processhacker/processhacker/search?q=RtlGetFullPathName_U...
RtlGetFullPathName_UEx( _In_ PCWSTR FileName, _In_ ULONG BufferLength, _Out_writes_bytes_(BufferLength) PWSTR Buffer, _Out_opt_ PWSTR *FilePart, _Out_opt_ ULONG *BytesRequired );
https://bugs.winehq.org/show_bug.cgi?id=50464
John the.ideals@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source
https://bugs.winehq.org/show_bug.cgi?id=50464
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 CC| |zzhang@codeweavers.com Status|UNCONFIRMED |NEW
--- Comment #1 from Zhiyi Zhang zzhang@codeweavers.com --- Confirmed with wine 6.0 rc5. Should be pretty easy to fix with RtlGetFullPathName_U already implemented.
https://bugs.winehq.org/show_bug.cgi?id=50464
dmex dmex04@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmex04@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=50464
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net URL|https://ci.appveyor.com/api |https://web.archive.org/web |/buildjobs/9slxi3pkcyxcd2kf |/20210804232817/https://ci. |/artifacts/processhacker-3. |appveyor.com/api/buildjobs/ |0.3701-bin.zip |13enx0gti83o5h2r/artifacts/ | |processhacker-3.0.4234-bin. | |zip
https://bugs.winehq.org/show_bug.cgi?id=50464
Ben Shefte shefben@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shefben@gmail.com
--- Comment #2 from Ben Shefte shefben@gmail.com --- Created attachment 71563 --> https://bugs.winehq.org/attachment.cgi?id=71563 ntdll_fullpathname_stubs.patch
I made the stub for the UEx version, it just points to RtlGetFullPathName_U and returns NTSTATUS. Some of the patch is from reactos
https://bugs.winehq.org/show_bug.cgi?id=50464
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Please don't copy code from ReactOS.
https://bugs.winehq.org/show_bug.cgi?id=50464
--- Comment #4 from Ben Shefte shefben@gmail.com --- my bad, this isn't a copy/paste thing; I should have said I used reactos's function as a reference, but it is otherwise done by me, with what little code there is in this patch.
https://bugs.winehq.org/show_bug.cgi?id=50464
Ben Shefte shefben@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #71563|0 |1 is obsolete| |
--- Comment #5 from Ben Shefte shefben@gmail.com --- Created attachment 71567 --> https://bugs.winehq.org/attachment.cgi?id=71567 ntdll_RtlGetCurrentUmsThread_stub.patch
Fixed a few booboo's with the return type
https://bugs.winehq.org/show_bug.cgi?id=50464
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- You should not look at ReactOS code at all, a lot of it is reverse-engineered using methods that are not appropriate for Wine. It's not a usable source of information for us.
https://bugs.winehq.org/show_bug.cgi?id=50464
--- Comment #7 from Ben Shefte shefben@gmail.com --- I'm a little confused with what you are saying. The WineHQ wiki says for obvious reasons: don't look at or use any leaked code. Understandable, especially because its illegal. The wiki also says Google is our friend.
But from what I read; ReactOS was within legal limits with its work.. The articles I have read could be wrong i guess. I also was under the impression both Wine and ReactOS worked closely together.
But that leads me to an interesting problem/question: How could wine have gotten as far as it has without ANY disassembly? I know ms documentation gives SOME information. But If everyone was being honest; how many of the patches people add are not from disassembled code?
My thing is, if I use information from some place; I add the URL to my patches. How many of the people who submit patches do the same? i.e. Link to the things they referenced? Very little from what I have seen on https://source.winehq.org/patches/
It is the exact reason I wont submit patches through there, I feel as though everything I do will get shot down; so I just wait for someone else to submit a patch that is up to standards there.
I understand The legal implications to it, but I am confused at where the line is drawn when it comes to looking for information on google (which your WIKI does recommend) and how you can be certain some code you find is not disassembled (I'm not talking about code that is mostly inline (dis)assembly for obvious reasons)
I just want the WIKI to be MUCH more definitive/precise on what IS and IS NOT allowed.
-
WineHQ Bugzilla