[Bug 18162] New: dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

Summary: dlls/comctl32/tests/treeview.c: value computed is not
                    used
           Product: Wine
           Version: 1.1.19
          Platform: PC
        OS/Version: NetBSD
            Status: NEW
          Keywords: patch, source
          Severity: minor
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=20628)
 --> (http://bugs.winehq.org/attachment.cgi?id=20628)
patch

gcc -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC -Wall
-pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wpointer-arith -I/usr/pkg/include -I/usr/include
-I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include
-I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include  -o
treeview.o treeview.c
treeview.c: In function 'TestCallback':
treeview.c:279: warning: value computed is not used
treeview.c:304: warning: value computed is not used
treeview.c:313: warning: value computed is not used
treeview.c:322: warning: value computed is not used
treeview.c: In function 'TestExpandInvisible':
treeview.c:769: warning: value computed is not used

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

--- Comment #1 from Nikolay Sivov   2009-05-22 18:22:00 ---
(In reply to comment #0)
> treeview.c:279: warning: value computed is not used

It's better to use it. I mean add tests for return values.

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

--- Comment #2 from Austin English   2009-05-22 22:52:32 ---
(In reply to comment #1)
> (In reply to comment #0)
> > treeview.c:279: warning: value computed is not used
>
> It's better to use it. I mean add tests for return values.

Of course, feel free to send a patch doing so :-).

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

--- Comment #3 from Nikolay Sivov   2009-05-23 05:56:26 ---
Created an attachment (id=21257)
 --> (http://bugs.winehq.org/attachment.cgi?id=21257)
Patch to test return values

Does this help?

BTW, is it a gcc flags warning (I'm not very familiar with it) or something
NetBSD specific?

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

--- Comment #4 from Nikolay Sivov   2009-05-25 11:10:03 ---
Fix committed:

http://source.winehq.org/git/wine.git/?a=commit;h=4db999ebdf0d27bc124636dd2a...

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

--- Comment #5 from Austin English   2009-05-26 10:21:49 ---
(In reply to comment #4)
> Fix committed:
>
> http://source.winehq.org/git/wine.git/?a=commit;h=4db999ebdf0d27bc124636dd2a...

I'll try to get NetBSD up to test. I don't think it recognizes the wireless
card in that computer, but I'll see what I can do.

Feel free to close if you think it's fixed, I'll reopen if not.

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

--- Comment #6 from Nikolay Sivov   2009-05-26 10:30:19 ---
(In reply to comment #5)
> Feel free to close if you think it's fixed, I'll reopen if not.

We do not hurry, don't we? Just test it when you'll be able to.

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21257|0                           |1
        is obsolete|                            |

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Austin English   2009-05-28 22:01:08 ---
(In reply to comment #6)
> (In reply to comment #5)
> > Feel free to close if you think it's fixed, I'll reopen if not.
>
> We do not hurry, don't we? Just test it when you'll be able to.

Yep, works great, thanks!

I don't think it's anything NetBSD specific, but FWIW:
austin987$ gcc -v
Using built-in specs.
Target: i386--netbsdelf
Configured with: /usr/src/tools/gcc/../../gnu/dist/gcc4/configure
--enable-long-long --disable-multilib --enable-threads --disable-symvers
--build=x86_64-unknown-netbsd4.99.72 --host=i386--netbsdelf
--target=i386--netbsdelf --enable-__cxa_atexit
Thread model: posix
gcc version 4.1.3 20080704 prerelease (NetBSD nb2 20081120)

cc -m32 -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC
-Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wpointer-arith -I/usr/pkg/include -I/usr/include
-I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -O2 -I/usr/pkg/include
-I/usr/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include  -o
treeview.o treeview.c

[Bug 18162] dlls/comctl32/tests/treeview.c: value computed is not used

http://bugs.winehq.org/show_bug.cgi?id=18162

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2009-06-05 12:46:18 ---
Closing bugs fixed in 1.1.23.