[Bug 33892] New: major bugfix in IRecordInfoImpl_RecordCopy

http://bugs.winehq.org/show_bug.cgi?id=33892

Bug #: 33892
           Summary: major bugfix in IRecordInfoImpl_RecordCopy
           Product: Wine
           Version: 1.6-rc3
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: oleaut32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

the following function in oleaut32/recinfo.c

static HRESULT WINAPI IRecordInfoImpl_RecordCopy(IRecordInfo *iface, PVOID
pvExisting, PVOID pvNew)

needs to copy stuff from pvExisting to pvNew, however it was doing the
opposite!
The fix is simple, just do:

memcpy(pvNew, pvExisting, This->size);

[Bug 33892] Bug in IRecordInfoImpl_RecordCopy

http://bugs.winehq.org/show_bug.cgi?id=33892

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|major bugfix in             |Bug in
                   |IRecordInfoImpl_RecordCopy  |IRecordInfoImpl_RecordCopy
           Severity|major                       |normal

[Bug 33892] Bug in IRecordInfoImpl_RecordCopy

http://bugs.winehq.org/show_bug.cgi?id=33892

--- Comment #1 from Austin English  2013-06-26 13:15:45 CDT ---
Please send a patch. See http://wiki.winehq.org/SubmittingPatches for more
info.

[Bug 33892] Bug in IRecordInfoImpl_RecordCopy

http://bugs.winehq.org/show_bug.cgi?id=33892

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Alistair Leslie-Hughes  2013-09-08 05:34:22 CDT ---
Can you please resend your patch to the mailing list?

[Bug 33892] Bug in IRecordInfoImpl_RecordCopy

http://bugs.winehq.org/show_bug.cgi?id=33892

--- Comment #3 from Rosen Diankov  2013-09-08 05:44:22 CDT ---
it's right here:

http://www.winehq.org/pipermail/wine-patches/2013-June/125059.html

[Bug 33892] Bug in IRecordInfoImpl_RecordCopy

http://bugs.winehq.org/show_bug.cgi?id=33892

--- Comment #4 from Nikolay Sivov  2013-09-08 06:02:44 CDT ---
(In reply to comment #3)
> it's right here:
>
> http://www.winehq.org/pipermail/wine-patches/2013-June/125059.html

Please resend it in git diff format, and add test case. If you don't have time
for this please say so, this way your find will be less likely lost.

[Bug 33892] IRecordInfo::RecordCopy() is broken

http://bugs.winehq.org/show_bug.cgi?id=33892

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Summary|Bug in                      |IRecordInfo::RecordCopy()
                   |IRecordInfoImpl_RecordCopy  |is broken
     Ever confirmed|0                           |1

--- Comment #5 from Nikolay Sivov  ---
Proposed patch is broken too, not that horribly, but still not what we need.
I'm working on a proper fix.

[Bug 33892] IRecordInfo::RecordCopy() is broken

http://bugs.winehq.org/show_bug.cgi?id=33892

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |60252ea65bbdf991938d919cd4c
                   |                            |734809fb899bf
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Nikolay Sivov  ---
This is improved with 60252ea65bbdf991938d919cd4c734809fb899bf.

[Bug 33892] IRecordInfo::RecordCopy() is broken

https://bugs.winehq.org/show_bug.cgi?id=33892

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.12.