http://bugs.winehq.org/show_bug.cgi?id=17205
Summary: MessageBoxes doesn't have the copy(Ctrl-C) feature which exists on Windows. Product: Wine Version: 1.1.14 Platform: Other OS/Version: other Status: UNCONFIRMED Severity: trivial Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: diaasami@gmail.com
Created an attachment (id=19116) --> (http://bugs.winehq.org/attachment.cgi?id=19116) Source of a simple app that shows a messagebox
On Windows, When pressing Ctrl-C with a standard messagebox focused, the caption and contents are copied to the clipboard(as text), this doesn't happen with Wine's messageboxes.
When running the attached application and pressing Ctrl-C with the messagebox focused on Windows, the following is copied into the clipboard: --------------------------- Caption --------------------------- Test --------------------------- OK ---------------------------
http://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #1 from Diaa Sami diaasami@gmail.com 2009-01-30 22:37:04 --- Created an attachment (id=19117) --> (http://bugs.winehq.org/attachment.cgi?id=19117) Compiled exe for the sample app
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |diaasami@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19116|application/octet-stream |text/plain mime type| |
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source
http://bugs.winehq.org/show_bug.cgi?id=17205
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #2 from Dan Kegel dank@kegel.com 2009-01-31 08:21:31 --- Hi Diaa, can you add code to your testcase to automatically send the copy command to the messagebox and verify that the text appears in the clipboard? Then we can add it to the wine conformance test suite.
http://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #3 from Diaa Sami diaasami@gmail.com 2009-01-31 08:22:59 --- Ok, I may implement the missing functionality as well.
http://bugs.winehq.org/show_bug.cgi?id=17205
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|source |download, testcase
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19116|0 |1 is obsolete| |
--- Comment #4 from Diaa Sami diaasami@gmail.com 2009-02-02 01:09:22 --- Created an attachment (id=19202) --> (http://bugs.winehq.org/attachment.cgi?id=19202) Test case for the MessageBox copy feature
I've added code that converts the previous simple application to a test case as required. Tell me if anything else is needed.
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19117|0 |1 is obsolete| |
--- Comment #5 from Diaa Sami diaasami@gmail.com 2009-02-02 01:10:25 --- Created an attachment (id=19203) --> (http://bugs.winehq.org/attachment.cgi?id=19203) compiled exe for the attached test case
http://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #6 from Diaa Sami diaasami@gmail.com 2009-02-02 01:12:13 --- (From update of attachment 19203) It succeeds for me on Windows XP
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://msdn.microsoft.com/en | |-us/magazine/cc302329.aspx
--- Comment #7 from Diaa Sami diaasami@gmail.com 2009-02-02 01:18:01 --- According to http://msdn.microsoft.com/en-us/magazine/cc302329.aspx, this should work in Windows 2000 as well.
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor
http://bugs.winehq.org/show_bug.cgi?id=17205
Diaa Sami diaasami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|MessageBoxes doesn't have |MessageBoxes doesn't have |the copy(Ctrl-C) feature |the copy(Ctrl-C) feature |which exists on Windows. |
http://bugs.winehq.org/show_bug.cgi?id=17205
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv@dawncrow.de Ever Confirmed|0 |1
--- Comment #8 from André H. nerv@dawncrow.de 2010-02-14 14:41:03 --- still present in Wine-1.1.38
http://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #9 from André H. nerv@dawncrow.de 2012-06-19 15:08:22 CDT --- still present in Wine-1.5.6
https://bugs.winehq.org/show_bug.cgi?id=17205
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |imwellcushtymelike@gmail.co | |m
--- Comment #10 from Ken Sharp imwellcushtymelike@gmail.com --- Is this still an issue in Wine 1.7.45 or later? CTRL+C works in some applications at least.
https://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #11 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Ken Sharp from comment #10)
Is this still an issue in Wine 1.7.45 or later?
Obviously yes, it is.
CTRL+C works in some applications at least.
Support for Ctrl+C in MessageBox is still not implemented.
https://bugs.winehq.org/show_bug.cgi?id=17205
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com
https://bugs.winehq.org/show_bug.cgi?id=17205
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pastas4@gmail.com
--- Comment #12 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- *** Bug 30909 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #13 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Created attachment 56408 --> https://bugs.winehq.org/attachment.cgi?id=56408 Simple Patch
https://bugs.winehq.org/show_bug.cgi?id=17205
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #14 from winetest@luukku.com --- (In reply to Alistair Leslie-Hughes from comment #13)
Created attachment 56408 [details] Simple Patch
Merges cleanly against wine 2.0.rc2. Also results working testcase that's attached here.
https://bugs.winehq.org/show_bug.cgi?id=17205
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/user32-msgbox-Su | |pport-WM_COPY-mesg Status|NEW |STAGED
https://bugs.winehq.org/show_bug.cgi?id=17205
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #15 from Fabian Maurer dark.shadow4@web.de --- Marked as staging, but using wine-staging-4.0-rc4, it still doesn't work for me.
https://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #16 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- (In reply to Fabian Maurer from comment #15)
Marked as staging, but using wine-staging-4.0-rc4, it still doesn't work for me.
I've updated this patchset, please try again.
https://bugs.winehq.org/show_bug.cgi?id=17205
--- Comment #17 from Fabian Maurer dark.shadow4@web.de --- Thanks, works now with latest staging.
https://bugs.winehq.org/show_bug.cgi?id=17205
Gabriel Ivăncescu gabrielopcode@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gabrielopcode@gmail.com
--- Comment #18 from Gabriel Ivăncescu gabrielopcode@gmail.com --- Created attachment 64606 --> https://bugs.winehq.org/attachment.cgi?id=64606 Make the hook local to the Message Box's thread
I think the second patch in the series is wrong (the one that sets the hook). It installs a global hook, and I doubt that's what we want. The problem is that it can lead to random crashes in other applications in the same wineprefix. This has been very hard to track down, because it happens randomly, but every time it happened when a message box was created.
Mind you, this happens in *another* application in the same prefix. e.g. a message box pops up in a text editor to ask you to confirm exiting without saving, and this leads to a crash in an app in the background! (in the same wineprefix).
Is there a reason the hook is global? If not, please update the second patch in wine-staging by applying this attached patch on top of it.
After applying this patch I haven't got any random crashes for hours now, so I'm 99% sure it was this global hook messing something up.
https://bugs.winehq.org/show_bug.cgi?id=17205
VZ vz-wine@zeitlins.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vz-wine@zeitlins.org
--- Comment #19 from VZ vz-wine@zeitlins.org --- Just for the reference, there is also my alternative patch implementing the same functionality in a slightly different way at https://source.winehq.org/patches/data/176909
Unfortunately the discussion on wine-devel didn't really reach any conclusion, so I don't know what to do about it, but if anybody else wants to take [any parts of] this patch, please feel free to do so.