[Bug 31706] New: Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

Bug #: 31706
           Summary: Sacred Underworld: Some models glow like a Christmas
                    tree
           Product: Wine
           Version: 1.5.13
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 41683
  --> http://bugs.winehq.org/attachment.cgi?id=41683
picture of a glowing model

Steps to reproduce:
1. Install the game
2. Patch the game (2.28)
3. Start a new game (Underworld)
4. Select a character
5. Talk to the first npc and wait, till the bug show up

The bug will show up several times in game, specifically when wearing some
special armor. The game uses ddraw.

This was tested on (it also happens with LIBGL_ALWAYS_SOFTWARE):
OpenGL renderer string: Gallium 0.4 on AMD RV710
OpenGL version string: 2.1 Mesa 8.0.3
OpenGL shading language version string: 1.20

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

--- Comment #1 from Henri Verbeet  2012-09-15 05:13:12 CDT ---
My first guess would be some kind of texturing issue. Do you know if this is a
regression? Also, does this have a demo?

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

--- Comment #2 from Rico  2012-09-15 06:54:01 CDT ---
Created attachment 41685
  --> http://bugs.winehq.org/attachment.cgi?id=41685
Savegame where the bug is visible

As far as I tested (till wine 1.2), it's not a regression.

The demo has the same problem ( e.g.
www.4players.de/services/downloadmanager/download.php?action=start_now&DOWNLOADID=6104
), attached is a save where the bug shows up. The save was cheated together to
get a combination of the required items. Install the demo, extract the save
into the folder "save" in the games directory. Start the game and load the
save.

Make sure you are working around bug 31406 (using a patched libxcb).

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |www.4players.de/services/do
                   |                            |wnloadmanager/download.php?
                   |                            |action=start_now&DOWNLOADID
                   |                            |=6104

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                 CC|                            |[e-mail]

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

--- Comment #3 from Rico  2012-10-06 06:22:06 CDT ---
Created attachment 41984
  --> http://bugs.winehq.org/attachment.cgi?id=41984
Hack to show if the model is glowing.

This patch adds a check to predict if the model glows. Maybe there is a special
handling needed?

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

--- Comment #4 from Henri Verbeet  2012-10-06 14:10:06 CDT ---
(In reply to comment #3)
> This patch adds a check to predict if the model glows. Maybe there is a special
> handling needed?

Quite possible. The FVF having position data is probably not very surprising,
and a FVF with diffuse data but no normals isn't that unusual by itself either,
but it may be worth a look to see if lighting is enabled or not when those
draws happen. I think lighting without normals may be slightly different
between OpenGL and ddraw.

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

--- Comment #5 from Rico  2012-11-27 14:18:25 CST ---
Created attachment 42646
  --> http://bugs.winehq.org/attachment.cgi?id=42646
+d3d,+ddraw log difference between glow/normal

Attached are two logs, one where the model glows and the same log part where
the model is rendered correctly.

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Rico  2013-02-11 11:56:19 CST ---
Fixed by commit d7e5189cc25f40ca2630f39b663b6497dcffe33a.

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |d7e5189cc25f40ca2630f39b663
                   |                            |b6497dcffe33a

[Bug 31706] Sacred Underworld: Some models glow like a Christmas tree

http://bugs.winehq.org/show_bug.cgi?id=31706

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2013-02-15 14:31:01 CST ---
Closing bugs fixed in 1.5.24.