[Bug 36357] New: valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

Bug ID: 36357
           Summary: valgrind shows a leak in dswave/tests/dswave.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: directx-dsound
          Assignee: [e-mail]
          Reporter: [e-mail]

==22533== 24 bytes in 1 blocks are definitely lost in loss record 156 of 566
==22533==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==22533==    by 0x5DC1E5A: create_dswave (dswave.c:730)
==22533==    by 0x5DC2670: WaveCF_CreateInstance (dswave_main.c:97)
==22533==    by 0x4CB14DD: CoCreateInstance (unknwn.h:226)
==22533==    by 0x4B48E2E: func_dswave (dswave.c:57)
==22533==    by 0x4B49F8C: run_test (test.h:584)
==22533==    by 0x4B4A37A: main (test.h:654)
==22533==

[Bug 36357] valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

--- Comment #1 from Austin English  ---
Also
==13572== 28 bytes in 1 blocks are possibly lost in loss record 173 of 600
==13572==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==13572==    by 0x4E52BB8: apartment_getclassobject (compobj.c:526)
==13572==    by 0x4E55FC6: get_inproc_class_object (compobj.c:2894)
==13572==    by 0x4E58D2F: CoGetClassObject (compobj.c:3032)
==13572==    by 0x4E594B7: CoCreateInstance (compobj.c:3197)
==13572==    by 0x4A54D3C: func_dswave (dswave.c:30)
==13572==    by 0x4A55F8C: run_test (test.h:584)
==13572==    by 0x4A5637A: main (test.h:654)
==13572==

[Bug 36357] valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36357] valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|directx-dsound              |directx-dmusic

--- Comment #2 from Michael Stefaniuc  ---
Austin, this should be fixed by 834a92cc8be784453e37958e2608ef91480db196
I mean the issue from comment 1, no clue where the second one comes from.

[Bug 36357] valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

--- Comment #3 from Michael Stefaniuc  ---
Ok, I think I know where the other comes from:
create_dswave() was leaking memory on CoCreateInstance failure aka when the
test was requesting an unsupported IID. That was fixed in the same series but
in the previous patch aka 5843a1a00207e25959d35d3f94e2cfe89d2d6af2.

[Bug 36357] valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |5843a1a00207e25959d35d3f94e
                   |                            |2cfe89d2d6af2
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
(In reply to Michael Stefaniuc from comment #3)
> Ok, I think I know where the other comes from:
> create_dswave() was leaking memory on CoCreateInstance failure aka when the
> test was requesting an unsupported IID. That was fixed in the same series
> but in the previous patch aka 5843a1a00207e25959d35d3f94e2cfe89d2d6af2.

Thanks, marking fixed.

[Bug 36357] valgrind shows a leak in dswave/tests/dswave.c

https://bugs.winehq.org/show_bug.cgi?id=36357

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.47.