[Bug 11699] New: Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

Summary: Acecad tablet not recognised as a tablet
           Product: Wine
           Version: 0.9.56.
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wintab32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=10919)
 --> (http://bugs.winehq.org/attachment.cgi?id=10919)
The important bit of WINEDEBUG=+wintab32

Running Photoshop CS2, my Acecad tablet works only as a mouse, ie. it has no
pressure sensitivity. I've tried different xorg configurations with no change.

Pressure sensitivity works in Krita, but not in Gimp -- probably a
misconfiguration.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Dan Kegel   2008-03-13 10:58:55 ---
Try this patch:
http://winehq.org/pipermail/wine-patches/2008-March/051454.html
See also bug 12005

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #2 from Niels   2008-03-15 06:53:36 ---
The patch doesn't solve the problem.

As far as I can read the code, there are two problems:

- The type of my tablet device is determined by the name I've given it in my
xorg.conf and by the hardware device name. Since none of those contain
"stylus", the device isn't recognised as a stylus and
cursor->TYPE==CSR_TYPE_PEN is FALSE.

- My device have only 3 axis, so 0 valid devices are returned.

After changing the name in xorg.conf and the test to Val->num_axes >= 3,
Photoshop fails to load.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #3 from Niels   2008-03-15 06:55:52 ---
Created an attachment (id=11398)
 --> (http://bugs.winehq.org/attachment.cgi?id=11398)
Photoshop failing after mangling wintab.c

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from John Klehm   2008-05-23 07:41:53 ---
Can you try the patch attached to bug 12005
(http://bugs.winehq.org/attachment.cgi?id=13231) and let me know if that works
for you?  I have a feeling these two bugs are related.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #5 from Dan Kegel   2008-05-23 09:58:42 ---
What model tablet is this?  Got a link to a description?

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #6 from Niels   2008-05-24 14:39:04 ---
I can't try the patch right now, but with rc2 and a fresh install of Photoshop
CS2 trial I get this error: Unable to continue because of a hardware or system
error. Sorry, but this error is unrecoverable.

lsusb for the device is:

Bus 005 Device 003: ID 0460:0004 Ace Cad Enterprise Co., Ltd
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               1.00
  bDeviceClass            0 (Defined at Interface level)
  bDeviceSubClass         0
  bDeviceProtocol         0
  bMaxPacketSize0         8
  idVendor           0x0460 Ace Cad Enterprise Co., Ltd
  idProduct          0x0004
  bcdDevice            0.10
  iManufacturer           1 ACECAD
  iProduct                2 USB Graphics Tablet
  iSerial                 0
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength           34
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0
    bmAttributes         0x80
      (Bus Powered)
    MaxPower              100mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           1
      bInterfaceClass         3 Human Interface Device
      bInterfaceSubClass      1 Boot Interface Subclass
      bInterfaceProtocol      2 Mouse
      iInterface              0
        HID Device Descriptor:
          bLength                 9
          bDescriptorType        33
          bcdHID               1.10
          bCountryCode            0 Not supported
          bNumDescriptors         1
          bDescriptorType        34 Report
          wDescriptorLength     106
         Report Descriptors:
           ** UNAVAILABLE **
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0008  1x 8 bytes
        bInterval              10
Device Status:     0x0000
  (Bus Powered)

It looks like this:
http://www.dansdata.com/flair.htm

I think there may be two similar models, one called "flair" the other one not.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #7 from Dan Kegel   2008-05-24 18:03:15 ---
That Photoshop CS2 error is probably because you
didn't have a font installed.  Check out the appdb.

Thanks for the tablet info.  I wonder if this unit
http://www.amazon.com/Solidtek-GT-302SU-Acecad-3x2-75-inch-Graphics/dp/B000S...
uses the same driver.  I bet it does...

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #8 from Niels   2008-05-25 01:56:11 ---
Unplugging the tablet doesn't help with the error, that's true. But I do have
Times installed.

The driver for this tablet was originally an external project, but is now part
of the kernel. Here's the old page: http://acecad.sourceforge.net/

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #9 from Dan Kegel   2008-05-25 03:51:54 ---
Re the photoshop error: please try with a clean .wine directory
and do
  rm winetricks
  wget http://kegel.com/wine/winetricks
  sh winetricks corefonts
before installing Photoshop.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #10 from Niels   2008-05-25 05:17:12 ---
Right, OK, with corefonts installed in Wine (as well as in my Linux system),
Photoshop starts fine. But there's still (with rc2) no pressure sensitivity,
and that's surely because of "warn:wintab32:X11DRV_LoadTabletInfo Did not find
a valid stylus cursor with >= 5 axes, returning 0 valid devices.".

I'll try the patch later, thanks.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #11 from Niels   2008-05-25 09:12:51 ---
The patch apparently doesn't apply cleanly to current git.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #12 from John Klehm   2008-05-25 14:01:39 ---
(In reply to comment #11)
> The patch apparently doesn't apply cleanly to current git.

Really? It seems to apply cleanly for me.

I made a new branch from master which is at
3c1c6172779510a7ed693d922fb3061948999ea1 (Release 1.0-rc2) and did a
git apply patch.txt 
no errors

and then I compiled and got no errors.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #13 from Niels   2008-05-25 14:43:30 ---
With 3c1c6172779510a7ed693d922fb3061948999ea1 I get:

Adds trailing whitespace.
0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:18: *
Adds trailing whitespace.
0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:19: *  
Reference linuxwacom driver project wcmCommon.c function
Adds trailing whitespace.
0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:20: *   idtotype
for a much larger list of CSR_TYPE.
Adds trailing whitespace.
0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:21: *
Adds trailing whitespace.
0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:22: *  
http://linuxwacom.cvs.sourceforge.net/linuxwacom/linuxwacom-prod/src/xdrv/wc...
error: patch failed: dlls/winex11.drv/wintab.c:212
error: dlls/winex11.drv/wintab.c: patch does not apply

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #14 from John Klehm   2008-05-25 16:34:52 ---
(In reply to comment #13)
> With 3c1c6172779510a7ed693d922fb3061948999ea1 I get:
>
> Adds trailing whitespace.
> 0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:18: *
> Adds trailing whitespace.
> 0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:19: *  
> Reference linuxwacom driver project wcmCommon.c function
> Adds trailing whitespace.
> 0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:20: *   idtotype
> for a much larger list of CSR_TYPE.
> Adds trailing whitespace.
> 0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:21: *
> Adds trailing whitespace.
> 0001-winex11.drv-Place-tablet-cursors-in-proper-slot.patch.txt:22: *  
> http://linuxwacom.cvs.sourceforge.net/linuxwacom/linuxwacom-prod/src/xdrv/wc...
> error: patch failed: dlls/winex11.drv/wintab.c:212
> error: dlls/winex11.drv/wintab.c: patch does not apply

Yup, I see it now. The problem seems to be that when I do a 
git format-patch --keep-subject origin 
the generated patch file has trailing white space on some lines (lines that no
changes were made on!?!?)  I'm not sure why this is yet as the trailing
whitespace isn't in my tree, it just shows up in the generated patch file.

Hrmmm.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #15 from John Klehm   2008-05-25 23:41:03 ---
What version of git are you using?

No manner of trickery seems to be able to make the patch not apply in git
1.5.5.1.  Perhaps that version is more flexible with regards to whitespace?

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #16 from John Klehm   2008-05-25 23:42:25 ---
P.S the trailing white space comes from origin not from my changes FWIW.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #17 from John Klehm   2008-05-26 01:52:16 ---
Created an attachment (id=13345)
 --> (http://bugs.winehq.org/attachment.cgi?id=13345)
Place tablet cursors in proper slots based on type

I finally got my laptop back and tried it with git 1.5.4.3 and can confirm the
non applyingness.  I was able to apply the version I posted up at klehm.net
with git 1.5.4.3:  by doing a 
wget http://klehm.net/wine/temp.txt 
and then a 
git apply temp.txt

I am going to test with 1.5.4.3 by downloading it from this bugs attachment
next and report back.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #18 from John Klehm   2008-05-26 02:01:43 ---
Ahh ok the issue seems to be solved now.

I'm still not entirely certain how the first patch went awry with git 1.5.4.3
but I can confirm that the the place tablet cursors patch attached to this bug
will apply with 1.5.4.3 and 1.5.5.1.

So if you get a chance try the new
attachment(http://bugs.winehq.org/attachment.cgi?id=13345) and let me know if
it fixes things up for you.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #19 from Niels   2008-05-26 10:32:01 ---
My git is version 1.5.3.7, which is the newest in Gentoo stable amd64.

The new patch applied fine, Photoshop started fine and the mouse worked. The
moment I put the pen to the tablet, Photoshop crashed. Log attached.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #20 from Niels   2008-05-26 10:34:28 ---
Created an attachment (id=13353)
 --> (http://bugs.winehq.org/attachment.cgi?id=13353)
Crash after applying patch

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #21 from John Klehm   2008-05-26 11:25:31 ---
(In reply to comment #20)
> Created an attachment (id=13353)

--> (http://bugs.winehq.org/attachment.cgi?id=13353) [details]
> Crash after applying patch

Weird, I can't get that at all on my wacom tpc.

Thanks for the first log, it'd be really usefull to get a wintab trace log
though too, it'll help show why the context isn't being initialized correctly
and then showing up as the crash in ScaleForContext.

You can generate these by doing:

WINEDEBUG="+wintab32" wine "c:\path\to\photoshop.exe" &> photoshop_trace.log

where pathtophotoshop is the real path

Thanks!

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #22 from Niels   2008-05-26 11:49:27 ---
Created an attachment (id=13358)
 --> (http://bugs.winehq.org/attachment.cgi?id=13358)
More detailed crash log

Log as requested.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #23 from John Klehm   2008-05-26 12:22:33 ---
Created an attachment (id=13359)
 --> (http://bugs.winehq.org/attachment.cgi?id=13359)
Detect acecade tablet as stylus device

Ahh thanks a lot for the log, made it real easy to see where the bug was. =)

This patch will make sure wintab sees acecad tablets as a device that it can
use to initialize the context. You won't get the context crash you got last
time with this patch.

Try this patch in conjunction with the place tablet cursor patch and let me
know how things work.  If you are still having problems then another wintab
trace log just like you just gave me would be great.  Thanks!

As a note to myself:  Wintab should bail out and report no devices if it
doesn't find a device to initialize the context. It should print a fixme with
the device name and tell user to report to wine-devel or winehq bugs. This
would be much better than crashing with a halfway detected device.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13359|Detect acecade tablet as    |Detect acecad tablet as
        description|stylus device               |stylus device

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13359|0                           |1
        is obsolete|                            |

--- Comment #24 from John Klehm   2008-05-26 13:05:58 ---
Created an attachment (id=13362)
 --> (http://bugs.winehq.org/attachment.cgi?id=13362)
uncorrupted version of patch

Hrmm I think I found out why some patches dont apply of mine, winscp seems to
corrupt some of them.  I've downgraded to the stable version hopefully things
will be fixed now.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13362|0                           |1
        is obsolete|                            |

--- Comment #25 from John Klehm   2008-05-26 13:09:38 ---
Created an attachment (id=13363)
 --> (http://bugs.winehq.org/attachment.cgi?id=13363)
winscp transfer in binary mode version of patch

Hrmm last version was still bunk.  Sorry for all the noise I just need to
figure out wth is going on with winscp.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #26 from John Klehm   2008-05-26 13:14:37 ---
Ok the winscp transfer in binary mode version of the "Detect acecad tablet as
stylus device" patch successfully applied for me.  Give 'er a try and let me
know how it goes.

Sorry again for all the noise,   I guess maybe when I upgraded to the new
version of winscp it changed the default to text mode?  Oh well hopefully fixed
for the future now.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #27 from Niels   2008-05-26 13:19:16 ---
With patches 13345 and 13363 pressure sensitivy works in Photoshop! Thank you
so much for looking into this!

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

--- Comment #28 from John Klehm   2008-05-26 13:24:17 ---
Awesome! =) Thanks for being so quick with the logs, helps a ton. :D

Can you resolve the bug to fixed then?

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

Niels  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #29 from Niels   2008-05-26 13:35:15 ---
Done!

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #30 from James Hawkins   2008-05-26 14:02:27 ---
A bug isn't fixed until the patches are committed.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1

--- Comment #31 from John Klehm   2008-05-31 10:53:38 ---
Taking the bug so I can mark it fix when my patch gets committed =P.  If that's
not what I'm supposed to do let me know, I'm a bugzilla noob.

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]
             Status|ASSIGNED                    |NEW

--- Comment #32 from John Klehm   2008-05-31 10:55:15 ---
It didn't reassign to me. I guess I have to explicitly set it. Sorry for the
noise. =/

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

John Klehm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #33 from John Klehm   2008-06-20 11:57:13 ---
Committed today:
http://source.winehq.org/git/wine.git/?a=commit;h=70cf762d31ac76c2b6b8cdd99e...

[Bug 11699] Acecad tablet not recognised as a tablet

http://bugs.winehq.org/show_bug.cgi?id=11699

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #34 from Alexandre Julliard   2008-06-27 09:58:44 ---
Closing bugs fixed in 1.1.0.