http://bugs.winehq.org/show_bug.cgi?id=28562
Bug #: 28562 Summary: Plastic Animation Paper 4.0 doesn't start Product: Wine Version: 1.3.28 Platform: x86 URL: http://www.plasticanimationpaper.dk/files/pap_v4_0.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-ddraw AssignedTo: wine-bugs@winehq.org ReportedBy: gyebro69@gmail.com CC: stefandoesinger@gmx.at Classification: Unclassified Regression SHA1: 8e79a7e6644fd6f1e0cfeb8b826e683d171d723a
Created attachment 36686 --> http://bugs.winehq.org/attachment.cgi?id=36686 plain terminal output
Users reported in the WineHQ forum that the application refuses to start in a recent Wine. http://forum.winehq.org/viewtopic.php?t=12970
Indeed, Plastic Animation Paper 4.0 is showing an error message when launching with 1.3.29: 'Fatal error Unable to set up graphics mode, graphics card must be capable of running 800x600'.
Actually, this is a regression, which happened between 1.3.27 and 1.3.28. The problem with bisecting is that that the application is broken between these 2 commits: http://source.winehq.org/git/wine.git/commit/76fecde8fb2d335e4855bec6d36ffe1... and http://source.winehq.org/git/wine.git/commit/8e79a7e6644fd6f1e0cfeb8b826e683...
That was bug #28259, affecting several apps/games.
If I apply the patch (in commit [76fecde8fb2d335e4855bec6d36ffe16cbed04f3]) on [8e79a7e6644fd6f1e0cfeb8b826e683d171d723a] then I receive the same error message that the application produces in current git.
So I think the offending commit, preventing PAP 4.0 from starting, should be
8e79a7e6644fd6f1e0cfeb8b826e683d171d723a is the first bad commit commit 8e79a7e6644fd6f1e0cfeb8b826e683d171d723a Author: Stefan Dösinger stefan@codeweavers.com Date: Sat Sep 3 21:06:11 2011 +0200
ddraw: Add some NULL pointer tests.
:040000 040000 91eec493c175fa65b5564a00127fa2e387b26f0d 25adf271715f048af26ebeba0626e0ac65ff2b71 M dlls
Added Stefan to CC. I must also add that prior to 1.3.23, the application produces the same error message on startup. So it only works between 1.3.23 and 1.3.28. PAP 4.0 is now freeware.
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #1 from GyB gyebro69@gmail.com 2011-10-03 10:26:50 CDT --- Created attachment 36687 --> http://bugs.winehq.org/attachment.cgi?id=36687 +ddraw,+msgbox log
http://bugs.winehq.org/show_bug.cgi?id=28562
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #2 from Stefan Dösinger stefandoesinger@gmx.at 2011-10-03 10:39:37 CDT --- Downloading the app at the moment, I'll have a look.
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #3 from Stefan Dösinger stefandoesinger@gmx.at 2011-10-03 11:09:08 CDT --- Created attachment 36691 --> http://bugs.winehq.org/attachment.cgi?id=36691 Change only pixelformat and surface data in SetSurfaceDesc
This is a hack that gets the app working for me. I don't know how it worked in the past, SetSurfaceDesc has been misbehaving since it exists.
This patch changes SetSurfaceDesc according to what msdn says - it only allows setting the pixelformat and lpSurface members. The problem the app encountered was that the pitch was also overwritten by data passed in by the app. This patch obviously needs a few tests to confirm that the change is correct.
http://bugs.winehq.org/show_bug.cgi?id=28562
Stefan Dösinger stefandoesinger@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #36691|0 |1 is obsolete| |
--- Comment #4 from Stefan Dösinger stefandoesinger@gmx.at 2011-10-03 11:10:46 CDT --- Created attachment 36692 --> http://bugs.winehq.org/attachment.cgi?id=36692 Change only pixelformat and surface data in SetSurfaceDesc
Same patch again with a compile error fixed
http://bugs.winehq.org/show_bug.cgi?id=28562
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=28562
david rylleman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rylleman@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #5 from GyB gyebro69@gmail.com 2011-10-09 01:47:13 CDT --- The patch (applied on wine-1.3.29-274-gc9a8d3b) fixed the startup problem here as well.
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #6 from david rylleman@gmail.com 2011-11-17 01:23:35 CST --- I still have this issue with Wine 1.3.32
http://bugs.winehq.org/show_bug.cgi?id=28562
Stefan Dösinger stefan@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c3d6061593601463ac96d632956 | |b645c4c6342c2 Status|UNCONFIRMED |RESOLVED CC| |stefan@codeweavers.com Resolution| |FIXED
--- Comment #7 from Stefan Dösinger stefan@codeweavers.com 2011-11-17 03:28:37 CST --- This should be fixed by c3d6061593601463ac96d632956b645c4c6342c2, which was committed after Wine 1.3.32.
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #8 from david rylleman@gmail.com 2011-11-17 03:32:46 CST --- Ok, thank you, I'll wait a little then. I misunderstood the post above mine, I thought the patch was included in wine-1.3.29-274-gc9a8d3b and above. I realise now that it was not.
http://bugs.winehq.org/show_bug.cgi?id=28562
--- Comment #9 from Stefan Dösinger stefan@codeweavers.com 2011-11-17 04:21:03 CST --- Nah, when I posted the earlier post the patch was just attached to the bug report and wasn't even in git. Now it is in git, the next unstable release is scheduled for Friday.
http://bugs.winehq.org/show_bug.cgi?id=28562
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2011-11-18 13:04:22 CST --- Closing bugs fixed in 1.3.33.
http://bugs.winehq.org/show_bug.cgi?id=28562
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d
-
wine-bugs＠winehq.org