https://bugs.winehq.org/show_bug.cgi?id=57521
Bug ID: 57521 Summary: Some control text colors are always black when theming is enabled Product: Wine Version: 10.0-rc1 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: stefan@codeweavers.com Distribution: ---
Created attachment 77564 --> https://bugs.winehq.org/attachment.cgi?id=77564 Red/Green text with theming enabled
I recently tried to adapt light.msstyles into a dark style theme. Among the issues I ran into is that when theming is enabled, some controls always have black text regardless of what's set in the registry. As far as I can see this applies to Buttons, Static controls, tabulars, but possibly others too.
The issue isn't obvious with light.msstyles because it sets the colors in question to black anyhow.
I'm attaching two screenshots that try to illustrate the issue - In both cases I have set "window text" to green and "control text" (aka "ButtonText" in the registry) to red. You can see that it is followed differently when theming is on vs off.
I don't think the particular colors are taken out of the png resources in the .msstyles DLL since they affect text.
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #1 from Stefan Dösinger stefan@codeweavers.com --- Created attachment 77565 --> https://bugs.winehq.org/attachment.cgi?id=77565 Red/Green text without theming
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #2 from Stefan Dösinger stefan@codeweavers.com --- Created attachment 77566 --> https://bugs.winehq.org/attachment.cgi?id=77566 Attempted hack
Here's my attempt to hack the static control into submission. It quickly turned out to be wrong since it overrides colors set via WM_CTLCOLORSTATIC - e.g. the Red "Wine" text in the winecfg about page loses its custom color.
I tried to follow the path of the registry colors through the WM_CTLCOLORSTATIC and similar messages but failed to do so while sitting in the airplane.
https://bugs.winehq.org/show_bug.cgi?id=57521
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang@codeweavers.com
--- Comment #3 from Zhiyi Zhang zzhang@codeweavers.com --- Generally, text colors are specified in the [SysMetrics] section in light.rc, for example, see "System colors". Then for individual controls, there is the "TextColor" property, for example, "TextColor = 0 0 0" in "[Button.Groupbox]". Properties are also inherited from parents. So if "[Button.Commandlink(Hot)]" doesn't specify a TextColor, then it will search "[Button.Commandlink]" and then "[Button]".
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #4 from Zhiyi Zhang zzhang@codeweavers.com --- Created attachment 77572 --> https://bugs.winehq.org/attachment.cgi?id=77572 changing groupbox text color
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #5 from Stefan Dösinger stefan@codeweavers.com --- Thanks for the explanation - I am getting somewhere:
Adding "[Button]\r\n" "TextColor = 0 255 0\r\n"
To my dark.rc file makes checkbox text green - there's no text color definition for [Button.Checkbox], but other button types override the parent. Obviously setting a TextColor for Button.Checkbox also works, although my feeling is that we should push a few colors up in the hierarchy.
I haven't found a control type that changes the text color of static controls. I tried adding a [Static] entry, but no luck. Adding a TextColor entry in [SysMetrics] didn't help either. Manipulating the SysMetrics section was my first attempt.
Is there a way to retrieve a list of control classes (I guess it is somewhat related to the files in dlls/comctl32) and subclasses?
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #6 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to Stefan Dösinger from comment #5)
Thanks for the explanation - I am getting somewhere:
Adding "[Button]\r\n" "TextColor = 0 255 0\r\n"
To my dark.rc file makes checkbox text green - there's no text color definition for [Button.Checkbox], but other button types override the parent. Obviously setting a TextColor for Button.Checkbox also works, although my feeling is that we should push a few colors up in the hierarchy.
I haven't found a control type that changes the text color of static controls. I tried adding a [Static] entry, but no luck. Adding a TextColor entry in [SysMetrics] didn't help either. Manipulating the SysMetrics section was my first attempt.
I don't think static control has a theme class. It uses WM_CTLCOLORSTATIC to paint its background but I don't see a way to change its text color. I am not sure Windows provides a way for that. Maybe it uses COLOR_WINDOWTEXT or COLOR_BTNTEXT in system metrics. Try changing system metrics on Windows.
Is there a way to retrieve a list of control classes (I guess it is somewhat related to the files in dlls/comctl32) and subclasses?
Yes. Please see dlls/uxtheme/stylemap.c:1412 mapClass and https://learn.microsoft.com/en-us/windows/win32/controls/parts-and-states. I don't think there is a static control class though.
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #7 from Zhiyi Zhang zzhang@codeweavers.com ---
I don't think static control has a theme class. It uses WM_CTLCOLORSTATIC to paint its background but I don't see a way to change its text color. I am not sure Windows provides a way for that. Maybe it uses COLOR_WINDOWTEXT or COLOR_BTNTEXT in system metrics. Try changing system metrics on Windows.
Changing WindowText in light.rc changes the text color for static controls. It's from the WM_CTLCOLORSTATIC handling by dlls/win32u/defwnd.c:2320 handle_control_color(). Specifically, the "NtGdiGetAndSetDCDword( hdc, NtGdiSetTextColor, get_sys_color( COLOR_WINDOWTEXT ), NULL );".
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #8 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to Zhiyi Zhang from comment #7)
Changing WindowText in light.rc changes the text color for static controls. It's from the WM_CTLCOLORSTATIC handling by dlls/win32u/defwnd.c:2320 handle_control_color(). Specifically, the "NtGdiGetAndSetDCDword( hdc, NtGdiSetTextColor, get_sys_color( COLOR_WINDOWTEXT ), NULL );".
This also means that the text color of static controls is determined by the parent window's response to WM_CTLCOLORSTATIC. So if there is an application that handles WM_CTLCOLORSTATIC and sets the text color to black. You will get a black text in the static control regardless of the value of COLOR_WINDOWTEXT. This is also why some win32/GDI applications always have black text even though dark mode is enabled on Windows.
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #9 from Zhiyi Zhang zzhang@codeweavers.com --- https://gist.github.com/rounk-ctrl/b04e5622e30e0d62956870d5c22b7017 has some helpful tips to enable dark mode.
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #10 from Stefan Dösinger stefan@codeweavers.com --- Created attachment 77724 --> https://bugs.winehq.org/attachment.cgi?id=77724 Make uxtheme set the text color
This change to uxtheme allows me to change the colors of the static labels without breaking winecfg's custom WM_CTLCOLORSTATIC handling in the about dialog.
However, on IRC you said
eh, UXTHEME_DefDlgProc() shouldn't touch text color though.
Why do you think it shouldn't touch the color? As far as I can see the equivalent code in default_window_proc in win32u/defwnd.c does set the text color (line 2339 in the current git code):
NtGdiGetAndSetDCDword( hdc, NtGdiSetTextColor, get_sys_color( COLOR_WINDOWTEXT ), NULL );
And indeed, making UXTHEME_DefDlgProc call DefWindowProcW(), which is does if theming is disabled, does apply COLOR_WINDOWTEXT color to static controls.
I'd find it odd if pretty much every control text can be changed, but not static controls. If this is guarded by a light-or-dark-theme switch that would realistically either make them black or white with no way to customize them.
https://bugs.winehq.org/show_bug.cgi?id=57521
--- Comment #11 from Zhiyi Zhang zzhang@codeweavers.com --- (In reply to Stefan Dösinger from comment #10)
Created attachment 77724 [details] Make uxtheme set the text color
However, on IRC you said
eh, UXTHEME_DefDlgProc() shouldn't touch text color though.
Why do you think it shouldn't touch the color? As far as I can see the equivalent code in default_window_proc in win32u/defwnd.c does set the text color (line 2339 in the current git code):
[00:18:41] <stefand> so winecfg does mess with WM_CTLCOLORSTATIC (I noticed that fairly early) [00:19:12] <stefand> changing the case IDC_ABT_PANEL_TEXT / IDC_ABT_LICENSE_TEXT etc to default: makes some more text blue, but not everything [00:19:50] <zhiyi> that's because winecfg is a dialog. See UXTHEME_DefDlgProc(). [00:20:06] <stefand> it seems that returning FALSE from DlgProc doesn't do what I intuitively expect it to do [00:22:32] <zhiyi> eh, UXTHEME_DefDlgProc() shouldn't touch text color though.
I was referring to "makes some more text blue, but not everything" is not from UXTHEME_DefDlgProc() because of no SetTextColor() call in UXTHEME_DefDlgProc(). Now that I think about this. UXTHEME_DefDlgProc() should probably change the text color as well. Your patch looks good at first glance. Please add some tests in test_EnableThemeDialogTexture() to verify it.
-
WineHQ Bugzilla