[Bug 12572] New: resedit tree control background not drawn

List overview All Threads

newer

older

[Bug 3260] Get Starforce copy...

[Bug 6716] Database box is not...

wine-bugs＠winehq.org

14 Apr 2008 14 Apr '08

4:20 a.m.

http://bugs.winehq.org/show_bug.cgi?id=12572

Summary: resedit tree control background not drawn Product: Wine Version: CVS/GIT Platform: Other URL: http://www.resedit.net/ OS/Version: other Status: NEW Keywords: download Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com

(I used the Unicode version, if it matters.) Play around with resedit a bit; the tree control in the upper left doesn't draw its background.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

3 Jun 3 Jun

2 p.m.

New subject: [Bug 12572] resedit 1.4.1 tree control background not drawn

http://bugs.winehq.org/show_bug.cgi?id=12572

Dan Kegel dank@kegel.com changed:

--- Comment #1 from Dan Kegel dank@kegel.com 2008-06-03 09:00:22 --- I think the version tested was resedit 1.4.1. Don't have that around anymore; I've written the author to see if he does.

With resedit 1.4.3, behavior seems to be worse, the app crashes:

Unhandled exception: page fault on read access to 0x28ec83e5 in 32-bit code (0x28ec83e5). Backtrace: =>1 0x28ec83e5 (0x0032f3e0) 2 0x7e86cc54 on_progress_proc+0x34(binding=0x1424b8, t=0x142490) [dlls/urlmon/binding.c:1110] in urlmon (0x0032f400) 3 0x7e86c67e notif_wnd_proc+0x5e(hwnd=0x10080, msg=0x465, wParam=0x0, lParam=) [dlls/urlmon/binding.c:185] in urlmon (0x0032f420) 4 0x7ed545ba WINPROC_wrapper+0x1a() in user32 (0x0032f450) 5 0x7ed54c9e call_window_proc+0x6e(hwnd=, msg=0x465, wp=0x0, lp=0x1424b8, result=0x32f500, arg=0x7e86c620) [dlls/user32/winproc.c:457] in user32 (0x0032f490) 6 0x7ed5a071 WINPROC_call_window+0xd1(hwnd=, msg=0x465, wParam=0x0, lParam=0x1424b8, result=0x32f500, unicode=0x1, mapping=0x4) [dlls/user32/winproc.c:2207] in user32 (0x0032f4d0) 7 0x7ed1c9d6 DispatchMessageW+0x96(msg=) [dlls/user32/message.c:3096] in user32 (0x0032f510) 8 0x7eceac20 DIALOG_DoDialogBox+0x1b0(hwnd=, owner=0x60028) [dlls/user32/dialog.c:784] in user32 (0x0032f570)

This could also be due to a change in Wine, so I tried old versions of Wine, but they all crash like this on resedit 1.4.3. Simplest conclusion is that it's new behavior in resedit 1.4.3, hopefully I can verify that soon.

wine-bugs＠winehq.org

26 Dec 26 Dec

6:31 p.m.

New subject: [Bug 12572] resedit 1.4.1 tree control background not drawn

http://bugs.winehq.org/show_bug.cgi?id=12572

--- Comment #2 from Austin English austinenglish@gmail.com 2008-12-26 12:31:31 --- 1.4.4.13 doesn't crash. The resources area has a blank background, and no treeview in it.

wine-bugs＠winehq.org

6:32 p.m.

New subject: [Bug 12572] resedit 1.4.1 tree control background not drawn

http://bugs.winehq.org/show_bug.cgi?id=12572

--- Comment #3 from Austin English austinenglish@gmail.com 2008-12-26 12:32:27 --- Err, spoke to soon. The treeview shows up after a few redraws. No background though.

wine-bugs＠winehq.org

19 Jan 19 Jan

9:15 p.m.

New subject: [Bug 12572] resedit 1.4.1 tree control background not drawn

http://bugs.winehq.org/show_bug.cgi?id=12572

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified

--- Comment #4 from Austin English austinenglish@gmail.com 2009-01-19 15:15:31 --- Removing deprecated CVS/GIT version tag. Please retest in current git. If the bug is still present in today's wine, but was not present in some earlier version of wine, please update version field to earliest known version of wine that had the bug. Thanks!

wine-bugs＠winehq.org

26 Jul 26 Jul

8:46 p.m.

New subject: [Bug 12572] resedit 1.4.1 tree control background not drawn

http://bugs.winehq.org/show_bug.cgi?id=12572

Nikolay Sivov bunglehead@gmail.com changed:

--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2009-07-26 15:46:52 --- Just retested with wine-1.1.26-232-g39876f4. Redrawing problems are still here.

Native comctl32 is a workaround.

wine-bugs＠winehq.org

16 Oct 16 Oct

10:54 p.m.

New subject: [Bug 12572] resedit 1.4.1 tree control background not drawn

http://bugs.winehq.org/show_bug.cgi?id=12572

--- Comment #6 from Nikolay Sivov bunglehead@gmail.com 2009-10-16 17:54:37 --- Created an attachment (id=24174) --> (http://bugs.winehq.org/attachment.cgi?id=24174) treeview background fill fix

Hi, Dan.

I think I found after several hours a reason while background isn't updated.

For subclassed controls (like in this application) it's ok not to forward WM_ERASEBKGND to original window procedure, instead only WM_PAINT is forwarded with NULL wParam which leads to BeginPaint/EndPaint sequence. After that returned PAINTSTRUCT contains not zero fErase field - it means we need to fill background before making main WM_PAINT painting.

This fact currently is completely ignored for Wine common controls:

http://bugs.winehq.org/show_bug.cgi?id=11424 http://bugs.winehq.org/show_bug.cgi?id=12123

These seem to be duplicates actually.

Same behaviour should logically apply to ListView and others:

http://bugs.winehq.org/show_bug.cgi?id=6716

Please test this patch on current wine-1.1.31-272-g8c743cb. For me it fixes at least this application.