[Bug 30641] New: wine silently replaces requests for thexture formats not supported by hardware with invalid requests

http://bugs.winehq.org/show_bug.cgi?id=30641

Bug #: 30641
           Summary: wine silently replaces requests for thexture formats
                    not supported by hardware with invalid requests
           Product: Wine
           Version: 1.5.1
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

When running a d3d application using s3tc on drivers that don't have support
for that texture format wine gives lots of complaints like:

err:d3d_surface:surface_allocate_surface >>>>>>>>>>>>>>>>> GL_INVALID_VALUE
(0x501) from glTexImage2D @ surface.c / 2566
err:d3d_surface:surface_upload_data >>>>>>>>>>>>>>>>> GL_INVALID_ENUM (0x500)
from glTexSubImage2D @ surface.c / 2349

GL trace shows:

37923 glTexImage2D(target = GL_TEXTURE_2D, level = 0, internalformat = GL_ZERO,
width = 64, height = 64, border = 0, format = GL_ZERO, type = GL_ZERO, pixels =
NULL)
37923: warning: glGetError(glTexImage2D) = GL_INVALID_VALUE

This is totally useless and bogus.

1) no message is logged about the application using a format that is not
supported.

2) bogus format is used instead so nobody outside of wine can figure out WTF it
is the application tried to do that did not work.

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

http://bugs.winehq.org/show_bug.cgi?id=30641

Michal Suchanek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wine silently replaces      |wine silently replaces
                   |requests for thexture       |requests for d3d texture
                   |formats not supported by    |formats not supported by
                   |hardware with invalid       |hardware with invalid
                   |requests                    |requests

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

http://bugs.winehq.org/show_bug.cgi?id=30641

--- Comment #1 from Henri Verbeet  2012-05-12 03:52:48 CDT ---
It's a bit more complicated than that, but yes, we should reject creation of
surfaces with unsupported formats, and probably print something to the winediag
channel for s3tc in particular.

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

http://bugs.winehq.org/show_bug.cgi?id=30641

--- Comment #2 from Austin English  ---
No winediag error yet, still present.

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

https://bugs.winehq.org/show_bug.cgi?id=30641

--- Comment #3 from Henri Verbeet  ---
(In reply to Austin English from comment #2)
> No winediag error yet, still present.

How did you verify that? We should be rejecting creation of resources with
unsupported formats now.

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

https://bugs.winehq.org/show_bug.cgi?id=30641

--- Comment #4 from Austin English  ---
(In reply to Henri Verbeet from comment #3)
> (In reply to Austin English from comment #2)
> > No winediag error yet, still present.
>
> How did you verify that? We should be rejecting creation of resources with
> unsupported formats now.

Sorry, that was unclear. I grepped for winediag error messages, didn't see a
related one.

Is this fixed then?

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

https://bugs.winehq.org/show_bug.cgi?id=30641

--- Comment #5 from Austin English  ---
This is your friendly reminder that there has been no bug activity for over a
year. Is this still an issue in current (1.7.51 or newer) wine?

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

https://bugs.winehq.org/show_bug.cgi?id=30641

--- Comment #6 from Matteo Bruni  ---
(In reply to Austin English from comment #4)
> (In reply to Henri Verbeet from comment #3)
> > (In reply to Austin English from comment #2)
> > > No winediag error yet, still present.
> >
> > How did you verify that? We should be rejecting creation of resources with
> > unsupported formats now.
>
> Sorry, that was unclear. I grepped for winediag error messages, didn't see a
> related one.
>
> Is this fixed then?

I think it's probably fixed but actually retesting would be nice.

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

https://bugs.winehq.org/show_bug.cgi?id=30641

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #7 from Austin English  ---
(In reply to Matteo Bruni from comment #6)
> (In reply to Austin English from comment #4)
> > (In reply to Henri Verbeet from comment #3)
> > > (In reply to Austin English from comment #2)
> > > > No winediag error yet, still present.
> > >
> > > How did you verify that? We should be rejecting creation of resources with
> > > unsupported formats now.
> >
> > Sorry, that was unclear. I grepped for winediag error messages, didn't see a
> > related one.
> >
> > Is this fixed then?
>
> I think it's probably fixed but actually retesting would be nice.

It would be nice, but it's been 3 years, so let's assume it's been fixed. If a
dev disagrees, I'm also fine with RESOLVED ABANDONED ;)

[Bug 30641] wine silently replaces requests for d3d texture formats not supported by hardware with invalid requests

https://bugs.winehq.org/show_bug.cgi?id=30641

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 3.14.