http://bugs.winehq.org/show_bug.cgi?id=26044
Summary: atl/atl_ax tests show several valgrind warnings Product: Wine Version: 1.3.13 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: atl AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Most seem related to:
Conditional jump or move depends on uninitialised value(s) at USER_SetWindowPos (winpos.c:2039) by SetWindowPos (winpos.c:2141) by activate_inplace (oleobject.c:148) by OleObject_DoVerb (oleobject.c:454) by IOCS_Init (atl_ax.c:919) by IOCS_Create (atl_ax.c:952) by AtlAxAttachControl (atl_ax.c:1091) by test_AtlAxAttachControl (atl_ax.c:96) by func_atl_ax (atl_ax.c:127) by run_test (test.h:556) by main (test.h:624) Uninitialised value was created by a stack allocation at IOCS_Init (atl_ax.c:911)
there's also: 64 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by IOCS_Create (atl_ax.c:934) by AtlAxAttachControl (atl_ax.c:1091) by test_AtlAxAttachControl (atl_ax.c:96) by func_atl_ax (atl_ax.c:127) by run_test (test.h:556) by main (test.h:624)
64 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by IOCS_Create (atl_ax.c:934) by AtlAxAttachControl (atl_ax.c:1091) by test_AtlAxAttachControl (atl_ax.c:109) by func_atl_ax (atl_ax.c:127) by run_test (test.h:556) by main (test.h:624)
and perhaps a few more. I'll attach the full log.
http://bugs.winehq.org/show_bug.cgi?id=26044
--- Comment #1 from Austin English austinenglish@gmail.com 2011-02-09 19:39:38 CST --- Created an attachment (id=33218) --> (http://bugs.winehq.org/attachment.cgi?id=33218) valgrind log
http://bugs.winehq.org/show_bug.cgi?id=26044
--- Comment #2 from Vincent Povirk madewokherd@gmail.com 2011-03-02 16:14:44 CST --- I think this is because GetClientRect fails for a NULL hwnd in IOCS_Init, so rect is uninitialized. We don't check for a NULL hwnd even though tests suggest it's a valid case, nor do we check for failure of GetClientRect.
I don't know what the appropriate fix is.
http://bugs.winehq.org/show_bug.cgi?id=26044
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #3 from Dan Kegel dank@kegel.com 2011-10-13 16:09:17 CDT --- Still happening.
http://bugs.winehq.org/show_bug.cgi?id=26044
--- Comment #4 from Dan Kegel dank@kegel.com 2011-10-13 16:19:35 CDT --- Created attachment 36895 --> http://bugs.winehq.org/attachment.cgi?id=36895 Patch to not use garbage rect
This shuts the error up, but it probably needs more tests.
http://bugs.winehq.org/show_bug.cgi?id=26044
--- Comment #5 from Austin English austinenglish@gmail.com 2012-09-26 15:01:12 CDT --- Still present: ==28551== Conditional jump or move depends on uninitialised value(s) ==28551== at 0x4B5AA7B: USER_SetWindowPos (winpos.c:2079) ==28551== by 0x4B5A499: SetWindowPos (winpos.c:2181) ==28551== by 0x56FE4B8: activate_inplace (oleobject.c:153) ==28551== by 0x56FE886: OleObject_DoVerb (oleobject.c:573) ==28551== by 0x4909115: AtlAxAttachControl (oleidl.h:3179) ==28551== by 0x48EB600: func_atl_ax (atl_ax.c:96) ==28551== by 0x48EAF96: main (test.h:557) ==28551== Uninitialised value was created by a stack allocation ==28551== at 0x4908F81: AtlAxAttachControl (atl_ax.c:1083)
wine-1.5.13-346-g0445393
https://bugs.winehq.org/show_bug.cgi?id=26044
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #33218|0 |1 is obsolete| |
--- Comment #6 from Austin English austinenglish@gmail.com --- Created attachment 48226 --> https://bugs.winehq.org/attachment.cgi?id=48226 valgrind log
still present in wine-1.7.17-42-g24c5728
https://bugs.winehq.org/show_bug.cgi?id=26044
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fracting@gmail.com
--- Comment #7 from Qian Hong fracting@gmail.com --- (In reply to Austin English from comment #6)
Created attachment 48226 [details] valgrind log
still present in wine-1.7.17-42-g24c5728
I was looking at it and found it needs some more tests, I'll take the bug once I have time. Focusing on other ATL bugs currently.
http://bugs.winehq.org/show_bug.cgi?id=26044
Qian Hong fracting@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |fracting@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=26044
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind
https://bugs.winehq.org/show_bug.cgi?id=26044
--- Comment #8 from Austin English austinenglish@gmail.com --- Still in 1.7.41.
https://bugs.winehq.org/show_bug.cgi?id=26044
--- Comment #9 from Austin English austinenglish@gmail.com --- Still seeing this in 4.0-rc3: ==31033== Syscall param writev(vector[...]) points to uninitialised byte(s) ==31033== at 0x43567D3: writev (writev.c:26) ==31033== by 0x7BC75457: send_request (server.c:228) ==31033== by 0x7BC76158: server_call_unlocked (server.c:288) ==31033== by 0x7BC761AD: wine_server_call (server.c:321) ==31033== by 0x52278D8: set_window_pos (winpos.c:2158) ==31033== by 0x5229850: USER_SetWindowPos (winpos.c:2314) ==31033== by 0x5227E66: SetWindowPos (winpos.c:2404) ==31033== by 0x605206C: activate_inplace (oleobject.c:175) ==31033== by 0x6052398: OleObject_DoVerb (oleobject.c:673) ==31033== by 0x4B87BB5: IOleObject_DoVerb (oleidl.h:2756) ==31033== by 0x4B87BB5: IOCS_Init (???:0) ==31033== by 0x4B87D1A: IOCS_Create (atl_ax.c:970) ==31033== by 0x4B88402: AtlAxAttachControl (atl_ax.c:1156) ==31033== by 0x42280A2: test_AtlAxAttachControl (atl_ax.c:101) ==31033== by 0x42282A7: func_atl_ax (atl_ax.c:142) ==31033== by 0x422957F: run_test (test.h:617) ==31033== by 0x4229FBD: main (test.h:701) ==31033== Address 0x4b6f9f8 is on thread 1's stack ==31033== in frame #4, created by set_window_pos (winpos.c:2095) ==31033== Uninitialised value was created by a stack allocation ==31033== at 0x4B87B5B: IOCS_Init (atl_ax.c:926) ==31033==
-
wine-bugs＠winehq.org