[Bug 28821] New: kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

http://bugs.winehq.org/show_bug.cgi?id=28821

Bug #: 28821
           Summary: kernel32/tests/time.ok: uninitialized memory read in
                    GetCalendarInfoA
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Running "make time.ok" in kernel32/tests causes Valgrind to complain:

Use of uninitialised value of size 4
    at wcstombs_sbcs (wctomb.c:152)
    by wine_cp_wcstombs (wctomb.c:456)
    by WideCharToMultiByte (locale.c:2010)
    by GetCalendarInfoA (time.c:620)
    by test_GetCalendarInfo (time.c:667)
  Uninitialised value was created by a client request
    at mark_block_uninitialized (heap.c:208)
    by initialize_block (heap.c:239)
    by RtlAllocateHeap (heap.c:1703)
    by HeapAlloc (heap.c:267)
    by GetCalendarInfoA (time.c:615)
    by test_GetCalendarInfo (time.c:667)

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

https://bugs.winehq.org/show_bug.cgi?id=28821

--- Comment #1 from Austin English  ---
==11650== Use of uninitialised value of size 4
==11650==    at 0x401E5DE: wcstombs_sbcs (wctomb.c:187)
==11650==    by 0x401EEF3: wine_cp_wcstombs (wctomb.c:456)
==11650==    by 0x7B850F4F: WideCharToMultiByte (locale.c:2142)
==11650==    by 0x7B87ECFB: GetCalendarInfoA (time.c:632)
==11650==    by 0x4D2E064: test_GetCalendarInfo (time.c:690)
==11650==    by 0x4D2E635: func_time (time.c:736)
==11650==    by 0x4D48640: run_test (test.h:584)
==11650==    by 0x4D48A2F: main (test.h:654)
==11650==  Uninitialised value was created by a client request
==11650==    at 0x7BC4C52C: mark_block_uninitialized (heap.c:209)
==11650==    by 0x7BC4C697: initialize_block (heap.c:240)
==11650==    by 0x7BC50FA3: RtlAllocateHeap (heap.c:1717)
==11650==    by 0x7B84586B: HeapAlloc (heap.c:271)
==11650==    by 0x7B87EC60: GetCalendarInfoA (time.c:626)
==11650==    by 0x4D2E064: test_GetCalendarInfo (time.c:690)
==11650==    by 0x4D2E635: func_time (time.c:736)
==11650==    by 0x4D48640: run_test (test.h:584)
==11650==    by 0x4D48A2F: main (test.h:654)
==11650==

still present.

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

https://bugs.winehq.org/show_bug.cgi?id=28821

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source, testcase,
                   |                            |valgrind

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

https://bugs.winehq.org/show_bug.cgi?id=28821

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

--- Comment #2 from Sagawa  ---
Created attachment 48724
  --> https://bugs.winehq.org/attachment.cgi?id=48724
proposed patch

Could you try this patch?
It works well on my PC with valgrind 3.8.1.

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

https://bugs.winehq.org/show_bug.cgi?id=28821

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

--- Comment #3 from Austin English  ---
(In reply to Sagawa from comment #2)
> Created attachment 48724 [details]
> proposed patch
>
> Could you try this patch?
> It works well on my PC with valgrind 3.8.1.

Works for me, thanks!

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

http://bugs.winehq.org/show_bug.cgi?id=28821

--- Comment #4 from Sagawa  ---
Sent the patch:
https://source.winehq.org/patches/data/105023

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

https://bugs.winehq.org/show_bug.cgi?id=28821

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |89a558fe8f0b9034b53c0443431
                   |                            |dab3739c6ddff
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Austin English  ---
(In reply to Sagawa from comment #4)
> Sent the patch:
> https://source.winehq.org/patches/data/105023

https://source.winehq.org/git/wine.git/commitdiff/89a558fe8f0b9034b53c044343...

Thanks Akihiro!

[Bug 28821] kernel32/tests/time.ok: uninitialized memory read in GetCalendarInfoA

https://bugs.winehq.org/show_bug.cgi?id=28821

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.20.