https://bugs.winehq.org/show_bug.cgi?id=54848
Bug ID: 54848 Summary: dnsapi:query - test_DnsQuery() fails on Rémi's Wine test machines Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: dnsapi Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com Distribution: ---
dnsapi:query - test_DnsQuery() fails on Rémi's Wine test machines:
query.c:66: Test failed: expected record name L"winehq.org", got L"." query.c:67: Test failed: expected record type 1, got 41 query.c:96: Test failed: unexpected CNAME chain
See https://test.winehq.org/data/patterns.html#dnsapi:query
test_DnsQuery() also has failures on the TestBot's VMs (see bug 54847) but the failures on Rémi's machines are different and not easily explained by the CDN used by winehq.org. They may instead be caused by the cloud environment these machines are running on.
These failures happen in new tests that were introduced by this commit:
commit 6e2efe54f17e72415b790edf6c9c1f9de5acb9f7 Author: François Gouget fgouget@codeweavers.com Date: Thu Apr 13 05:51:20 2023 +0200
dnsapi/tests: Test how DnsQuery() handles CNAMEs.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54819
https://bugs.winehq.org/show_bug.cgi?id=54848
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |6e2efe54f17e72415b790edf6c9 | |c1f9de5acb9f7 Keywords| |regression, source, | |testcase
https://bugs.winehq.org/show_bug.cgi?id=54848
--- Comment #1 from François Gouget fgouget@codeweavers.com --- Where 41 == DNS_TYPE_OPT, "a pseudo-record type needed to support EDNS".
https://bugs.winehq.org/show_bug.cgi?id=54848
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon@codeweavers.com
--- Comment #2 from Rémi Bernon rbernon@codeweavers.com --- This is the output with WINETEST_DEBUG=2. Fwiw I have the same kind of failures and output when running the tests locally in a docker environment, and it's probably also related to IPV6 not being configured.
---
dnsapi:query start dlls/dnsapi/tests/query.c query.c:91: DnsQuery DNS_TYPE_A: L"test.winehq.org" type=CNAME -> L"winehq.org" L"winehq.org" type=A -> 4.4.81.124 L"." type=41 query.c:113: Test failed: unexpected record type 41 query.c:134: DnsQuery DNS_TYPE_CNAME: L"test.winehq.org" type=CNAME -> L"winehq.org" L"winehq.org" type=A -> 4.4.81.124 L"." type=41 query.c:148: Test failed: did not expect a record for L"winehq.org" query.c:150: Test failed: unexpected record type 41 query.c:171: Tests skipped: computer is not in a domain
https://bugs.winehq.org/show_bug.cgi?id=54848
--- Comment #3 from Hans Leidekker hans@meelstraat.net --- (In reply to Rémi Bernon from comment #2)
dnsapi:query start dlls/dnsapi/tests/query.c query.c:91: DnsQuery DNS_TYPE_A: L"test.winehq.org" type=CNAME -> L"winehq.org" L"winehq.org" type=A -> 4.4.81.124 L"." type=41 query.c:113: Test failed: unexpected record type 41 query.c:134: DnsQuery DNS_TYPE_CNAME: L"test.winehq.org" type=CNAME -> L"winehq.org" L"winehq.org" type=A -> 4.4.81.124 L"." type=41
41 = DNS_TYPE_OPT. Can you post the output of this command?
$ dig test.winehq.org
https://bugs.winehq.org/show_bug.cgi?id=54848
--- Comment #4 from Rémi Bernon rbernon@codeweavers.com --- $ dig test.winehq.org
; <<>> DiG 9.16.37-Debian <<>> test.winehq.org ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 9136 ;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags:; udp: 65494 ;; QUESTION SECTION: ;test.winehq.org. IN A
;; ANSWER SECTION: test.winehq.org. 300 IN CNAME winehq.org. winehq.org. 300 IN A 4.4.81.124
;; Query time: 20 msec ;; SERVER: 127.0.0.11#53(127.0.0.11) ;; WHEN: Mon Apr 24 12:06:37 UTC 2023 ;; MSG SIZE rcvd: 74
---
I also have the same kind of output when running it on my computer, which is configured with a local dns cache.
https://bugs.winehq.org/show_bug.cgi?id=54848
--- Comment #5 from Hans Leidekker hans@meelstraat.net --- (In reply to Rémi Bernon from comment #4)
$ dig test.winehq.org
; <<>> DiG 9.16.37-Debian <<>> test.winehq.org ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 9136 ;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags:; udp: 65494 ;; QUESTION SECTION: ;test.winehq.org. IN A
So it's an EDNS record used to advertise max udp message size in this case. I think we should ignore this record type in the test.
I also have the same kind of output when running it on my computer, which is configured with a local dns cache.
Right, it's probably responsible for the extra record.
https://bugs.winehq.org/show_bug.cgi?id=54848
--- Comment #6 from François Gouget fgouget@codeweavers.com --- I sent a merge request which will hopefully fix these failures: https://gitlab.winehq.org/wine/wine/-/merge_requests/2825
https://bugs.winehq.org/show_bug.cgi?id=54848
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |477df6231a6175f10c0f37145f6 | |09932ed35ea2d Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #7 from Hans Leidekker hans@meelstraat.net --- The unexpected EDNS record failures are gone after 477df6231a6175f10c0f37145f609932ed35ea2d.
https://bugs.winehq.org/show_bug.cgi?id=54848
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.11.
-
WineHQ Bugzilla