[Bug 47379] New: ReactOS Calc help file does not work.

https://bugs.winehq.org/show_bug.cgi?id=47379

Bug ID: 47379
           Summary: ReactOS Calc help file does not work.
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: hhctrl.ocx
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

ReactOS Calc includes an HtmlHelp file for handling user's manual and runtime
help.
This help file must be copied under "%systemroot%\Help".
Unfortunately, it does not work.
I can see these issues:

1) The htmlhelp file is not found.
This happens because HHCTRL implementation for WINE does not seem to support
command lines including environment strings.
The program uses this command line:

"%systemroot%\Help\calc.chm::"

If I replace this string in my software with:

"c:\windows\Help\calc.chm::"

then the help file is open and it is shown.

2) If you press on a key with the right mouse button and select for help, the
tooltip does not appear and HHCTRL prints on the console:

002a:fixme:htmlhelp:HtmlHelpW HH case HH_DISPLAY_TEXT_POPUP not handled.

All tests have been made with the latest sources from repository at the time of
writing (last released version is 4.10).

A ready-to-use executable and help file can be found on my page at sourceforge:
https://sourceforge.net/projects/reactos-calc/

Sincerely.

[Bug 47379] ReactOS Calc help file does not work.

https://bugs.winehq.org/show_bug.cgi?id=47379

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
Can you please split this issue into one bugreport per problem?

[Bug 47379] ReactOS Calc help file does not work.

https://bugs.winehq.org/show_bug.cgi?id=47379

--- Comment #2 from Carlo Bramini  ---
Actually, there is already a bug report related to missing support for
HH_DISPLAY_TEXT_POPUP:

https://bugs.winehq.org/show_bug.cgi?id=43720

Is it ok to split or it would be a duplicate?

[Bug 47379] ReactOS Calc help file does not work

https://bugs.winehq.org/show_bug.cgi?id=47379

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ReactOS Calc help file does |ReactOS Calc help file does
                   |not work.                   |not work

--- Comment #3 from Fabian Maurer  ---
No need to open a duplicate then.

Regarding the other issue, did you make sure that hhctrl does the environment
expansion, and not something else?

[Bug 47379] ReactOS Calc help file does not work

https://bugs.winehq.org/show_bug.cgi?id=47379

--- Comment #4 from Carlo Bramini  ---
Well, I tested Windows XP, Windows 7 (32bit and 64 bit executable) and WINE.

* on Windows XP, I renamed my help file from "calc.chm" to "calc2.chm", just to
avoid conflicts with existing file, and I modified temporarily my calculator
with the new file name. HtmlHelp functions received the file name as described
in the first post and it worked fine.

* on Windows 7, it was a bit easier because the Help directory inside
%systemroot% is a bit different: the files are placed in sub-directories, so
the temp change made for XP was not needed. Again, I copied the file calc.chm
and I tested. It worked fine.

* on WINE, with sources downloaded from GIT, it did not work until I wrote the
patch that I have sent into the mailing list.

I could not test other versions of Windows.
At the moment, yes, it seems to me and to other people that HtmlHelp()
functions resolve environment variables. Perhaps, you may find interesting a
test program made by an user for testing the issue here:

https://jira.reactos.org/browse/CORE-15019