http://bugs.winehq.org/show_bug.cgi?id=28186
Summary: uninstaller has no proper usage message Product: Wine Version: 1.3.26 Platform: x86 OS/Version: All Status: NEW Severity: normal Priority: P2 Component: programs AssignedTo: wine-bugs@winehq.org ReportedBy: fgouget@codeweavers.com
First uninstaller uses WINE_ERR() to tell the user he got the usage wrong (like when he forgets a parameter). That's wrong as this is not a Wine error.
Second it never prints a usage message thus leaving the user guessing.
Finally if run in the wineconsole the user will see no output at all but that's a somewhat independent issue (see bug 28185).
http://bugs.winehq.org/show_bug.cgi?id=28186
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source
http://bugs.winehq.org/show_bug.cgi?id=28186
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- OS/Version|All |other Severity|normal |minor
http://bugs.winehq.org/show_bug.cgi?id=28186
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=28186
--- Comment #1 from Austin English austinenglish@gmail.com --- Still in wine-1.7.11
http://bugs.winehq.org/show_bug.cgi?id=28186
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |imwellcushtymelike@gmail.co | |m
http://bugs.winehq.org/show_bug.cgi?id=28186
--- Comment #2 from Hugh McMaster hugh.mcmaster@outlook.com --- Created attachment 47495 --> http://bugs.winehq.org/attachment.cgi?id=47495 Patch
This patch should address all of François's concerns. If I've missed something, please let me know.
Any and all feedback welcome.
http://bugs.winehq.org/show_bug.cgi?id=28186
Hugh McMaster hugh.mcmaster@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hugh.mcmaster@outlook.com
http://bugs.winehq.org/show_bug.cgi?id=28186
--- Comment #3 from Ken Sharp imwellcushtymelike@gmail.com --- static const WCHAR slashQW[] = {'/','?',0};
The command line should probably also accept -? for completeness, unless it breaks something of course...
http://bugs.winehq.org/show_bug.cgi?id=28186
--- Comment #4 from Hugh McMaster hugh.mcmaster@outlook.com --- (In reply to comment #3)
The command line should probably also accept -? for completeness, unless it breaks something of course...
Checking for -? is not a problem.
https://bugs.winehq.org/show_bug.cgi?id=28186
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #5 from super_man@post.com --- Some part of the patch was recently committed
Here is the recent commit
http://source.winehq.org/patches/data/113852
https://bugs.winehq.org/show_bug.cgi?id=28186
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #6 from Austin English austinenglish@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/fb01bc0428c9331ad3bcc53467...
https://bugs.winehq.org/show_bug.cgi?id=28186
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |fb01bc0428c9331ad3bcc53467a | |5a9f52058c4f6
https://bugs.winehq.org/show_bug.cgi?id=28186
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.51.
-
wine-bugs＠winehq.org