[Bug 28894] New: regression with patch 3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf (high cpu usage)

http://bugs.winehq.org/show_bug.cgi?id=28894

Bug #: 28894
           Summary: regression with patch
                    3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf (high cpu
                    usage)
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

I run a Borland Delphi program that prerfoms 2 seeks in an dbase database and
puts text from the found record into a richedit control.
With that patch included, there is a delay of several seconds before each info
gets displayed and the CPU goes to 100% busy.
Reverting the patch 3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf removes the delay.
The patch from 28889 has no effect.

[Bug 28894] regression with patch 3b5e14a9b0a925052e2b1b71f76a7f1eff6d84bf (high cpu usage)

http://bugs.winehq.org/show_bug.cgi?id=28894

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |3b5e14a9b0a925052e2b1b71f76
                   |                            |a7f1eff6d84bf

[Bug 28894] high cpu usage

http://bugs.winehq.org/show_bug.cgi?id=28894

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|regression with patch       |high cpu usage
                   |3b5e14a9b0a925052e2b1b71f76 |
                   |a7f1eff6d84bf (high cpu     |
                   |usage)                      |

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Version|unspecified                 |1.3.31
            Summary|high cpu usage              |High cpu usage in a Delphi
                   |                            |application
           Severity|normal                      |minor

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #1 from Aric Stewart  2011-10-25 13:31:44 CDT ---
Could you generate a +edit,+uniscribe log?

Are you sure it is a richedit control?  I have made no changes to richedit.

-aric

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #2 from Reinhard Karcher  2011-10-25 15:50:08 CDT ---
The delay is in the Delphi function TDataSet.Resync.
The requested log is located at www.frey.de/~rkarcher/bad.zip (55MByte),
a logfile without the patch is located at www.frey.de/~rkarcher/good.zip
(51kByte).

Reinhard(In reply to comment #1)
> Could you generate a +edit,+uniscribe log?
>
> Are you sure it is a richedit control?  I have made no changes to richedit.
>
> -aric

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #3 from Reinhard Karcher  2011-10-26 03:02:16 CDT ---
I suspect, that the problem is where you are looking for line breaks.
The program has about 10 windows, some with long lines and some without.
The windows without long lines are displayed without any delay, the other have
a delay that depends on the number of line breaks.

Reinhard

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #4 from Aric Stewart  2011-10-26 08:20:20 CDT ---
(In reply to comment #3)
> I suspect, that the problem is where you are looking for line breaks.
> The program has about 10 windows, some with long lines and some without.
> The windows without long lines are displayed without any delay, the other have
> a delay that depends on the number of line breaks.
>
> Reinhard

that would make sense.  the softbreaking in the edit control has slowed down
with the use of uniscribe.  Optimizing it is a second step. I will look closer
at the log.

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |performance

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #5 from Reinhard Karcher  2011-10-27 01:39:03 CDT ---
The time for one action changed from 3 seconds to 35 seconds. The program has
become unusable as an interactive program.

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #6 from Aric Stewart  2011-10-27 12:21:19 CDT ---
Created attachment 37155
  --> http://bugs.winehq.org/attachment.cgi?id=37155
edit.patch

Can you try the attached patch.  It should improve this issue dramatically.

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

--- Comment #7 from Reinhard Karcher  2011-10-27 14:51:33 CDT ---
The patch restores the old behavior.

Reinhard

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c83841ca0e08902bad88d1d9c3e
                   |                            |04db8b3097bcd
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Michael Stefaniuc  2011-10-31 12:39:32 CDT ---
Fixed by c83841ca0e08902bad88d1d9c3e04db8b3097bcd

[Bug 28894] High cpu usage in a Delphi application

http://bugs.winehq.org/show_bug.cgi?id=28894

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2011-11-04 14:15:31 CDT ---
Closing bugs fixed in 1.3.32.