[Bug 32292] New: Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

Bug #: 32292
           Summary: Railworks 3 Trainsimulator 2013 dependency on
                    ole32.dll
           Product: Wine
           Version: 1.5.18
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 42619
  --> http://bugs.winehq.org/attachment.cgi?id=42619
terminal output of trying to start Trainsimulator 2013 with built in ole32.dll

In order to run Trainsimulator 2013 it is mandatory to override ole32.dll. The
wine built in does not cut it.

[Bug 32292] Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bruno Jesus  2012-11-25 19:07:17 CST ---
Your log is lacking debug symbols, please install wine debug symbols for your
distribution or compile wine from source and get a new log.

[Bug 32292] Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

salamander purake  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42619|0                           |1
        is obsolete|                            |

--- Comment #2 from salamander purake  2012-11-25 21:32:54 CST ---
Created attachment 42621
  --> http://bugs.winehq.org/attachment.cgi?id=42621
terminal output with debug symbols

Here is wine built with the debug symbols enabled.

(In reply to comment #1)
> Your log is lacking debug symbols, please install wine debug symbols for your
> distribution or compile wine from source and get a new log.

[Bug 32292] Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #3 from Bruno Jesus  2012-11-25 21:53:39 CST ---
Created attachment 42622
  --> http://bugs.winehq.org/attachment.cgi?id=42622
check null rect

Please give this patch a try. I tested in windows and it gives the same error
code when the last parameter is null.

[Bug 32292] Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #4 from salamander purake  2012-11-25 22:54:37 CST ---
That fixed it. Thanks.

(In reply to comment #3)
> Created attachment 42622 [details]
> check null rect
>
> Please give this patch a try. I tested in windows and it gives the same error
> code when the last parameter is null.

[Bug 32292] Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|UNCONFIRMED                 |NEW
          Component|-unknown                    |ole32
     Ever Confirmed|0                           |1

--- Comment #5 from Bruno Jesus  2012-11-25 23:05:23 CST ---
Thanks for testing. I don't have time to play with this currently, proper tests
need to be written and the correct check for all parameters. Hopefully someone
else will work on this.

[Bug 32292] Railworks 3 Trainsimulator 2013 dependency on ole32.dll

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #6 from Nikolay Sivov  2012-11-26 03:23:55 CST ---
(In reply to comment #5)
> Thanks for testing. I don't have time to play with this currently, proper tests
> need to be written and the correct check for all parameters. Hopefully someone
> else will work on this.

I can do that.

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Railworks 3 Trainsimulator  |Railworks 3 Trainsimulator
                   |2013 dependency on          |2013 crashes in OleDraw
                   |ole32.dll                   |

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #7 from Nikolay Sivov  2012-11-26 04:00:05 CST ---
Could you try this patch instead:

http://www.winehq.org/pipermail/wine-patches/2012-November/120222.html

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #8 from Bruno Jesus  2012-11-26 06:46:09 CST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Thanks for testing. I don't have time to play with this currently, proper tests
> > need to be written and the correct check for all parameters. Hopefully someone
> > else will work on this.
>
> I can do that.

Thanks, Nikolay. I don't understand your patch but I trust your work =)

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #9 from salamander purake  2012-11-26 08:26:15 CST ---
Removed the previous patch and added yours, It works fine as far as I can tell.

(In reply to comment #7)
> Could you try this patch instead:
>
> http://www.winehq.org/pipermail/wine-patches/2012-November/120222.html

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

--- Comment #10 from Nikolay Sivov  2012-11-26 08:33:50 CST ---
(In reply to comment #9)
> Removed the previous patch and added yours, It works fine as far as I can tell.
>
> (In reply to comment #7)
> > Could you try this patch instead:
> >
> > http://www.winehq.org/pipermail/wine-patches/2012-November/120222.html

Thanks for testing.

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6a8b4f11a876f16090591f1c4b8
                   |                            |34e56cc783b4e
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Bruno Jesus  2012-11-26 15:27:08 CST ---
Nikolay's patch was commited:
http://source.winehq.org/git/wine.git/?a=commit;h=6a8b4f11a876f16090591f1c4b...

[Bug 32292] Railworks 3 Trainsimulator 2013 crashes in OleDraw

http://bugs.winehq.org/show_bug.cgi?id=32292

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2012-12-07 13:36:32 CST ---
Closing bugs fixed in 1.5.19.