[Bug 14846] New: Raising exception for SC_RPC_HANDLE being NULL

http://bugs.winehq.org/show_bug.cgi?id=14846

Summary: Raising exception for SC_RPC_HANDLE being NULL
           Product: Wine
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: tools
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15387)
 --> (http://bugs.winehq.org/attachment.cgi?id=15387)
Suggested patch

widl doesn't generate code for handling SC_RPC_HANDLE being NULL.

RPC_X_NULL_REF_POINTER is raised for NULL pointers on strins.
So it makes sense that RPC_X_SS_IN_NULL_CONTEXT should be raised for NULL
handle.

[Bug 14846] Raising exception for SC_RPC_HANDLE being NULL

http://bugs.winehq.org/show_bug.cgi?id=14846

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 14846] Raising exception for SC_RPC_HANDLE being NULL

http://bugs.winehq.org/show_bug.cgi?id=14846

--- Comment #1 from martinmnet   2008-08-14 09:00:44 ---
(In reply to comment #0)
> Created an attachment (id=15387)

--> (http://bugs.winehq.org/attachment.cgi?id=15387) [details]
> Suggested patch
>
> widl doesn't generate code for handling SC_RPC_HANDLE being NULL.
>
> RPC_X_NULL_REF_POINTER is raised for NULL pointers on strins.
> So it makes sense that RPC_X_SS_IN_NULL_CONTEXT should be raised for NULL
> handle.

More Info:

In windows, calling service functions with NULL for SC_HANDLE return
ERROR_INVALID_HANDLE regardless of what is passed for other parameters.
For example calling CreateService with all NULL's returns invalid handle.

The current widl source generates code to raise exception
RPC_X_SS_IN_NULL_CONTEXT for strings that are NULL and doesn't do any checks on
SC_HANDLE. Therefore the exception for the above example is
ERROR_INVALID_ADDRESS in ReactOS, but it should be checking the handle first
and returning ERROR_INVALID_HANDLE.

[Bug 14846] Raising exception for SC_RPC_HANDLE being NULL

http://bugs.winehq.org/show_bug.cgi?id=14846

Rob Shearman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tools                       |rpc

[Bug 14846] Raising exception for SC_RPC_HANDLE being NULL

http://bugs.winehq.org/show_bug.cgi?id=14846

Rob Shearman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Rob Shearman   2008-09-09 11:28:05 ---
Fixed by this commit:
http://source.winehq.org/git/wine.git/?a=commit;h=6f2687a389861fbedbbb8c8e3b...

[Bug 14846] Raising exception for SC_RPC_HANDLE being NULL

http://bugs.winehq.org/show_bug.cgi?id=14846

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard   2008-09-19 11:17:42 ---
Closing bugs fixed in 1.1.5.