[Bug 29033] New: multisampling hurts performance in Halflife 2

http://bugs.winehq.org/show_bug.cgi?id=29033

Bug #: 29033
           Summary: multisampling hurts performance in Halflife 2
           Product: Wine
           Version: 1.3.32
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: trivial
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail], [e-mail]
    Classification: Unclassified
   Regression SHA1: 8a2b435dd354cd4eac7a7286dfb8b08c539dbab8

Regression introduced by:
austin@aw21 ~/wine-git $ git bisect good
8a2b435dd354cd4eac7a7286dfb8b08c539dbab8 is the first bad commit
commit 8a2b435dd354cd4eac7a7286dfb8b08c539dbab8
Author: Henri Verbeet 
Date:   Thu Aug 25 21:05:04 2011 +0200

wined3d: Enable multisampling by default.

:040000 040000 62e7056a4af5f1b67220122f092fbad509d78af0
71aa80453a183a7e903cba8c29a9cb90049f9cc6 M    dlls

Without multisampling:
ptsdemo.dem,184.1,
22.1,116.1,21386,800,600,windowed,off,2,4,UNKNOWN,"c:\program
files\valve\steam\steamapps\austinenglish\half-life 2 demo\hl2.exe"  -steam 
-novid -console -nosound -window +cl_showfps 2 +timedemoquit ptsdemo -width 800
-height 600 -dxlevel 95,NVIDIA GeForce GTX
480,0x10de,0x6c0,off,off,on,on,off,on,

with multisampling:
ptsdemo.dem,172.9,
19.6,123.7,21386,800,600,windowed,off,2,4,UNKNOWN,"c:\program
files\valve\steam\steamapps\austinenglish\half-life 2 demo\hl2.exe"  -steam 
-novid -console -nosound -window +cl_showfps 2 +timedemoquit ptsdemo -width 800
-height 600 -dxlevel 95,NVIDIA GeForce GTX
480,0x10de,0x6c0,off,off,on,on,off,on,

Options used:
wine Steam.exe -applaunch 219 -novid -console -nosound -window +cl_showfps 2
+timedemoquit ptsdemo -width 800 -height 600 -dxlevel 95

this is using Stefan's time demo from his benchmarking test suite.

[Bug 29033] multisampling hurts performance in Halflife 2

http://bugs.winehq.org/show_bug.cgi?id=29033

--- Comment #1 from Stefan Dösinger  2011-11-09 03:31:21 CST ---
Thanks for bisecting this. My first thought is that with a feature like this
added a performance drop is normal. However, I believe that I have
multisampling disabled in the game and the GPU is vastly overpowered
considering the other rendering settings(one CPU core used only, 800x600 window
size)

Can you test two things:
1) Make sure multisampling is disabled in the game
2) See if turning multisampling off in the registry fixes the regression

If (1) is off, and (2) fixes the regression I'll see why the slowdown happens.

[Bug 29033] multisampling hurts performance in Halflife 2

http://bugs.winehq.org/show_bug.cgi?id=29033

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID
    Regression SHA1|8a2b435dd354cd4eac7a7286dfb |
                   |8b08c539dbab8               |

--- Comment #2 from Henri Verbeet  2011-11-09 06:18:10 CST ---
Not a bug, multisampling isn't free.

[Bug 29033] multisampling hurts performance in Halflife 2

http://bugs.winehq.org/show_bug.cgi?id=29033

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Henri Verbeet  2011-11-09 06:18:28 CST ---
Closing.

[Bug 29033] multisampling hurts performance in Halflife 2

http://bugs.winehq.org/show_bug.cgi?id=29033

--- Comment #4 from Austin English  2011-11-09 13:15:23 CST ---
(In reply to comment #1)
> Thanks for bisecting this. My first thought is that with a feature like this
> added a performance drop is normal. However, I believe that I have
> multisampling disabled in the game and the GPU is vastly overpowered
> considering the other rendering settings(one CPU core used only, 800x600 window
> size)
>
> Can you test two things:
> - Make sure multisampling is disabled in the game

It was set to 2xMSAA
> - See if turning multisampling off in the registry fixes the regression

It does.

Sorry for the spam Henri.

[Bug 29033] multisampling hurts performance in Halflife 2

http://bugs.winehq.org/show_bug.cgi?id=29033

--- Comment #5 from Stefan Dösinger  2011-11-13 17:04:21 CST ---
(In reply to comment #4)
> It was set to 2xMSAA

Same here. I know I made sure to disable multisampling when I set up my tests
to avoid situations like this one. I guess the game turned multisampling on
when it saw support for it.

So I agree, this bug is invalid.