http://bugs.winehq.org/show_bug.cgi?id=34801
Bug #: 34801 Summary: [Regression] Music stopped working in The Witcher Product: Wine Version: 1.7.5 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs@winehq.org ReportedBy: kmaterka@wp.pl CC: dmitry@baikal.ru, kmaterka@wp.pl Classification: Unclassified
Program: The Witcher (Steam version)
Commit causing regression: 4cc482bc0df758bec76ad1466abcba7f85e3cc5c Author: Dmitry Timoshkov dmitry@baikal.ru Date: Fri Jul 19 14:02:38 2013 +0900
kernel32: GetShortPathName for a non-existent short file name should fail.
Bug can be reproduced in demo: http://www.fileplanet.com/183167/180000/fileinfo/The-Witcher-Demo
Short description: Music stopped working in menu and in game. Other sound like ambient, UI clicks, voices etc are working correctly. I tried both PulseAudio and Alsa backends, using latest GIT version.
Reproducing the Bug: Install demo and run. Music is missing in menu and in game (it is working in movies so skip them).
Environment: Ubuntu 13.10 64bit Latest Wine from Ubuntu PPA repository + latest wine compiled from sources using this instruction: http://wiki.winehq.org/BuildingBiarchWineOnUbuntu
I don't know why exactly this commit breaks music in game. I've done full bisect to pin down this commit, then I used latest revision with this commit reverted - music was working correctly. Probably file path is incorrectly calculated, sample file path to music file (in 64 bit environment): /home/konrad/.wine/drive_c/Program Files (x86)/Steam/SteamApps/common/The Witcher Enhanced Edition/Data/Music/menu.ogg
In case of any problems while testing this I can do test on my computer - just provide a patch file.
http://bugs.winehq.org/show_bug.cgi?id=34801
Konrad Materka kmaterka@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=34801
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.fileplanet.com/1 | |83167/180000/fileinfo/The-W | |itcher-Demo CC|dmitry@baikal.ru, | |kmaterka@wp.pl | Summary|[Regression] Music stopped |Music stopped working in |working in The Witcher |The Witcher
http://bugs.winehq.org/show_bug.cgi?id=34801
Konrad Materka kmaterka@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|download | URL|http://www.fileplanet.com/1 | |83167/180000/fileinfo/The-W | |itcher-Demo |
--- Comment #1 from Konrad Materka kmaterka@wp.pl 2013-10-27 09:49:15 CDT --- I checked again and it looks that this bug is specific to steam version (or probably the latest version of The Witcher), so it cannot be reproduced in demo.
http://bugs.winehq.org/show_bug.cgi?id=34801
--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru 2013-10-27 10:08:51 CDT --- Please attach a compressed with 'bzip2 -9' +relay,+file,+tid log.
http://bugs.winehq.org/show_bug.cgi?id=34801
--- Comment #3 from Konrad Materka kmaterka@wp.pl 2013-10-28 17:22:00 CDT --- This files where too big to attach them here, so I had to use Dropbox. I uploaded logs for both working and broken wine:
https://www.dropbox.com/sh/bphafxzmkcd4zpn/biaHf0ENpx/log_working.bz2 https://www.dropbox.com/sh/bphafxzmkcd4zpn/YFp33C-znt/log_broken.bz2
After decompress they are huge - something about 700MB each. Wine source code differs only by patch I mentioned earlier.
I think that bug can be spotted after line 4 882 471 in log_broken and line 5 272 024 in log_working: Call shlwapi.PathFileExistsW(00ef9a10 L"..\data\music\menu.ogg") ret=00810012
In log_working in lines 5 272 037-5 272 038 you can see that short file name is returned:
0052:trace:file:GetShortPathNameW L"..\data\music\menu.ogg" 0052:trace:file:GetShortPathNameW returning L"..\data\music\menu.ogg"
in log_broken second log line is missing and no other error is returned.
http://bugs.winehq.org/show_bug.cgi?id=34801
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Regression SHA1| |4cc482bc0df758bec76ad1466ab | |cba7f85e3cc5c
--- Comment #4 from Dmitry Timoshkov dmitry@baikal.ru 2013-10-29 02:19:12 CDT --- (In reply to comment #3)
This files where too big to attach them here, so I had to use Dropbox. I uploaded logs for both working and broken wine:
https://www.dropbox.com/sh/bphafxzmkcd4zpn/biaHf0ENpx/log_working.bz2 https://www.dropbox.com/sh/bphafxzmkcd4zpn/YFp33C-znt/log_broken.bz2
Many thanks. It looks like that the GetLongPathName code which I reused for GetShortPathName implementation is broken for relative path names. I sent some tests for both GetLongPathName and GetShortPathName to wine-patches. I'll have a look what could be done to fix the revealed bug.
http://bugs.winehq.org/show_bug.cgi?id=34801
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru 2013-10-29 03:26:08 CDT --- Created attachment 46425 --> http://bugs.winehq.org/attachment.cgi?id=46425 Add special case for "." and ".." to GetShortPathName
Please try the attached patch.
http://bugs.winehq.org/show_bug.cgi?id=34801
--- Comment #6 from Konrad Materka kmaterka@wp.pl 2013-10-29 12:33:42 CDT --- After applying your patch everything works! Thanks! :) I think that this bug can be closed as resolved.
PS. For the record, I'll probably remove logs from my Dropbox soon, so these file will not be available.
http://bugs.winehq.org/show_bug.cgi?id=34801
--- Comment #7 from Dmitry Timoshkov dmitry@baikal.ru 2013-10-29 21:59:29 CDT --- http://www.winehq.org/pipermail/wine-patches/2013-October/128029.html
http://bugs.winehq.org/show_bug.cgi?id=34801
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d57444a62268ff6158f9c229509 | |3b713e6400f5b Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #8 from Dmitry Timoshkov dmitry@baikal.ru 2013-10-30 20:27:19 CDT --- Committed as d57444a62268ff6158f9c2295093b713e6400f5b.
http://bugs.winehq.org/show_bug.cgi?id=34801
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org 2013-11-08 12:32:57 CST --- Closing bugs fixed in 1.7.6.
-
wine-bugs＠winehq.org