[Bug 13864] New: F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Summary: F.E.A.R: Can't accept EULA
           Product: Wine
           Version: 1.0-rc4
          Platform: PC-x86-64
               URL: http://whatisfear.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: richedit
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=13935)
 --> (http://bugs.winehq.org/attachment.cgi?id=13935)
Regression test

When trying to install F.E.A.R with version 0.9.60 and later, the "I agree"
button that becomes active when you scroll down the EULA, stays greyed
out.Regression test and teminal output are attached.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #1 from DL   2008-06-11 20:50:38 ---
Created an attachment (id=13936)
 --> (http://bugs.winehq.org/attachment.cgi?id=13936)
Terminal output

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

DL  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #2 from James Hawkins   2008-06-11 22:04:53 ---
d10256f309e2f77b7a48594e5691899586150f3d is first bad commit
commit d10256f309e2f77b7a48594e5691899586150f3d
Author: Alex Villacís Lasso 
Date:   Thu Apr 24 10:04:23 2008 -0500

riched20: Implement ignoring of last \par for EM_STREAMIN - 1.0 emulation.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dmitry Timoshkov   2008-06-12 06:49:13 ---
Adding the author of the patch to the cc: list.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #4 from Alex Villacís Lasso   2008-06-12 13:10:53 ---
The behavior that is introduced by the patch is actually tested for. Maybe the
patch merely exposes a different bug that was hidden by the one fixed by the
patch.

Does this bug appear with the "F.E.A.R. Perseus Mandate Demo" single-player
demo, the one that is freely downloadable? (752 Mb)

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #5 from DL   2008-06-12 23:28:12 ---
(In reply to comment #4)
> The behavior that is introduced by the patch is actually tested for. Maybe the
> patch merely exposes a different bug that was hidden by the one fixed by the
> patch.
>
> Does this bug appear with the "F.E.A.R. Perseus Mandate Demo" single-player
> demo, the one that is freely downloadable? (752 Mb)

I don't see a 752mb version, only fearxp2_spdemo_en.exe , which is 734mb.I
assume you just forgot the exact filesize.I'm downloading this version now, and
will test it when it's done.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #6 from Alex Villacís Lasso   2008-06-13 14:25:24 ---
I am unable to reproduce this bug with fearxp2_spdemo_en.exe . Using
wine-1.0-rc5 fresh from git on Fedora 8, even without the boatload of held-up
richedit patches I have. Either this program does not exercise the code
required for the bug, or it has already been fixed in git.

Could you please indicate what is the latest wine version you are using that
exhibits the bug? If it is not a rc version, could you please update to the
latest  one (wine-1.0-rc5 as of this writing) and test again?

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #7 from DL   2008-06-13 22:30:52 ---
(In reply to comment #6)
> I am unable to reproduce this bug with fearxp2_spdemo_en.exe . Using
> wine-1.0-rc5 fresh from git on Fedora 8, even without the boatload of held-up
> richedit patches I have. Either this program does not exercise the code
> required for the bug, or it has already been fixed in git.
>
> Could you please indicate what is the latest wine version you are using that
> exhibits the bug? If it is not a rc version, could you please update to the
> latest  one (wine-1.0-rc5 as of this writing) and test again?

Bug still occurs with F.E.A.R Retail 1.08 on wine-1.0-rc5.Doesn't occur with
Perseus Mandate demo, like you said.
Perhaps you could try this demo :
http://www.gamershell.com/download_10167.shtml
which is for the original game, and hopefully shares the same code as the
retail version.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://whatisfear.com       |http://www.gamershell.com/do
                   |                            |wnload_10167.shtml
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #8 from Austin English   2008-06-14 16:39:46 ---
Con(In reply to comment #7)
> Bug still occurs with F.E.A.R Retail 1.08 on wine-1.0-rc5.Doesn't occur with
> Perseus Mandate demo, like you said.
> Perhaps you could try this demo :
> http://www.gamershell.com/download_10167.shtml
> which is for the original game, and hopefully shares the same code as the
> retail version.

Confirming in 1.0-rc5.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #9 from Austin English   2008-06-14 16:41:44 ---
Created an attachment (id=14028)
 --> (http://bugs.winehq.org/attachment.cgi?id=14028)
+richedit in 1.0-rc5

winetricks riched20 gets around the bug. +riched attached.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Alex Villacís Lasso  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #10 from Alex Villacís Lasso   2008-06-17 18:49:13 ---
As I suspected, this is not actually a regression, but a exposure of a
previously hidden bug. The installer uses EM_POSFROMCHAR to check on the
textbox. Richedit 1.0 seems to return 0 (for normal cases) as LRESULT for
EM_POSFROMCHAR, but builtin returns a composition of the client coordinates for
the character, as per 2.0, and this returned 0 before the problematic patch
just by accident. This needs a throughout test for EM_POSFROMCHAR (missing in
both 1.0 and 2.0 testsets). MSDN also mentions a return value of -1 for
characters beyond the last character in the control. This should be tested too.

--- Comment #11 from Alex Villacís Lasso   2008-06-19 12:19:32 ---
Created an attachment (id=14183)
 --> (http://bugs.winehq.org/attachment.cgi?id=14183)
richedit: Add tests for EM_POSFROMCHAR, make them pass under Wine

(In reply to comment #10)
> As I suspected, this is not actually a regression, but a exposure of a
> previously hidden bug. The installer uses EM_POSFROMCHAR to check on the
> textbox. Richedit 1.0 seems to return 0 (for normal cases) as LRESULT for
> EM_POSFROMCHAR, but builtin returns a composition of the client coordinates for
> the character, as per 2.0, and this returned 0 before the problematic patch
> just by accident. This needs a throughout test for EM_POSFROMCHAR (missing in
> both 1.0 and 2.0 testsets). MSDN also mentions a return value of -1 for
> characters beyond the last character in the control. This should be tested too.

Scratch that, the behavior difference, while in need of correction, is not the
actual cause of the regression. Patch attached for EM_POSFROMCHAR, but it does
not actually fix the bug.

I have noticed that with native riched20, the radio button to accept the EULA
does not get enabled until the EULA is scrolled to the very bottom. Before the
problematic patch, it would get enabled as soon as the EULA is scrolled a bit.
This difference might point to the true root cause of the bug.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #12 from Alex Villacís Lasso   2008-06-23 14:07:17 ---
Created an attachment (id=14307)
 --> (http://bugs.winehq.org/attachment.cgi?id=14307)
 richedit: EM_POSFROMCHAR should take into account scrollbar position. With
tests.

Finally, I found the root cause of the bug, as well as an explanation for the
regression. As usual, this is the typical case of a bugfix uncovering another
bug.

It turns out that the y-position of the very last member of the linked-list
structure in the builtin list control was not being updated, and remained with
a value of zero. Before the regression, this value was the one being reported
when the installed issued an EM_POSFROMCHAR on the position of the last line of
the text. After the regression,  the value being reported was the y-offset of
the last line, *uncorrected by the scrollbar position*, and therefore it did
not change when scrolling down. This patch adds the correction for the
scrollbar and tests for it. Please apply the previous patch, and then this one,
and report back whether it fixed the problem for you.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, testcase

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #13 from Alex Villacís Lasso   2008-06-24 12:45:46 ---
Patches have been accepted in current git. Still waiting for response of
submitter of bug.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

--- Comment #14 from DL   2008-06-25 22:58:41 ---
(In reply to comment #13)
> Patches have been accepted in current git. Still waiting for response of
> submitter of bug.

Yes, it's working correctly with current git, thanks.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from James Hawkins   2008-06-25 23:03:09 ---
Fixed.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2008-06-27 10:36:06 ---
Closing bugs fixed in 1.1.0.

[Bug 13864] F.E.A.R: Can't accept EULA

http://bugs.winehq.org/show_bug.cgi?id=13864

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2008-06-27 10:36:06 ---
Closing bugs fixed in 1.1.0.

--- Comment #17 from Alexandre Julliard   2008-06-27 10:36:24 ---
Closing bugs fixed in 1.1.0.