http://bugs.winehq.org/show_bug.cgi?id=22051
Summary: Supreme Commander patch 1.1.3280 crashes immediately Product: Wine Version: 1.1.40 Platform: x86-64 URL: http://games.softpedia.com/progDownload/Supreme-Comman der-103269-to-113280-Patch-Download-23484.html OS/Version: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: ben@xnode.org
Created an attachment (id=26844) --> (http://bugs.winehq.org/attachment.cgi?id=26844) Patch Crash Log
Trying to run the patch first results in a Windows error message and then a Wine crash dialogue, the patch doesn't appear or open at any point.
.NET 2 (dotnet20) is installed.
Patch linked in the download box because it may be possible to run it (and see the crash) without the game being installed) as it crashes before it appears to have even checked for the game.
http://bugs.winehq.org/show_bug.cgi?id=22051
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dotnet
http://bugs.winehq.org/show_bug.cgi?id=22051
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #1 from Wylda wylda@volny.cz 2010-03-17 22:13:13 ---
Smells like bug 21798, but with help of AJ who pointed out gdiplus in comment #8, i was able to do it this time :-D
1. Confirming, please consider KEYWORDS: +REGRESSION, COMPONENT: gdiplus
2. I did a regression test between 1.1.35 and 1.1.38:
commit db3d756c1e4b03b0fb33f2863ab3d2275dcf00c2 Author: Vincent Povirk vincent@codeweavers.com Date: Sun Jan 24 15:18:46 2010 -0600
gdiplus: Prefer the builtin version.
3. There is another bug report suffering from this commit, see bug 21798.
4. Revert of this patch on top of wine-1.1.40-224-g0498534 makes that problem go away.
5. Adding author of this patch to CC.
--private keyword: bisected
I did this by horrible way. Could someone guide me to easier way for next time, please? With the knowledge:
* 1.1.35 ~ Last working * 1.1.36 ~ crash during the startup * 1.1.37 ~ crash during the startup * 1.1.38 ~ runs, but App displays error window and UI is completelly broken
i knew that i'm unable to do proper regression test (crashing between good/bad because of other issues and no way to revert those commits), so i used qgit to filter gdiplus commits between 1.1.35 and 1.1.38. Then git checkout 1.1.38 and unapplied gdiplus commits one by one in reverse order... But there must be an easier way! Any advice for next time?
http://bugs.winehq.org/show_bug.cgi?id=22051
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=22051
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |gdiplus
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #2 from Vincent Povirk madewokherd@gmail.com 2010-03-17 22:27:04 --- Um, gdiplus isn't even loaded according to the crash log.
Does setting an override of native or builtin for gdiplus change the outcome? If so, can you get a +gdiplus log?
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #3 from Wylda wylda@volny.cz 2010-03-17 22:32:02 --- Created an attachment (id=26865) --> (http://bugs.winehq.org/attachment.cgi?id=26865) console log from vanilla wine-1.1.40-224-g0498534
Well my console log is different...
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #4 from Wylda wylda@volny.cz 2010-03-17 22:34:37 --- Created an attachment (id=26866) --> (http://bugs.winehq.org/attachment.cgi?id=26866) console log with reverted commit
With reverted commit runs flawlessly.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #5 from Vincent Povirk madewokherd@gmail.com 2010-03-17 22:37:39 --- I think you're looking at a different bug from the one originally reported.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #6 from Wylda wylda@volny.cz 2010-03-17 22:38:36 --- Created an attachment (id=26867) --> (http://bugs.winehq.org/attachment.cgi?id=26867) console log from vanilla wine-1.1.40-224-g0498534 with +gdiplus
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #7 from Wylda wylda@volny.cz 2010-03-17 22:47:26 --- (In reply to comment #5)
I think you're looking at a different bug from the one originally reported.
Believe me Vincent, i don't ;)
Original reporter screwed several thing together and i made it clear. He filled version 1.1.40, but the crash log is from .36 or .37... As i wrote:
* 1.1.35 ~ Last working * 1.1.36 ~ crash during the startup * 1.1.37 ~ crash during the startup * 1.1.38 ~ runs, but App displays error window and UI is completelly broken
.38 and later does not crash.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #8 from Vincent Povirk madewokherd@gmail.com 2010-03-17 22:50:06 --- So in other words, the original reported bug is fixed, and you're now looking at a different bug in gdiplus (which existed all along, but the program had been using native gdiplus).
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #9 from Wylda wylda@volny.cz 2010-03-17 23:00:20 --- (In reply to comment #8)
So in other words, the original reported bug is fixed,
No... In first half he says "Trying to run the patch first results in a Windows error" and this error _is_ still present in 1.1.40, but it is not present it 1.1.35 or reverted 1.1.40
and you're now looking at a different bug in gdiplus (which existed all along, but the program had been using native gdiplus).
Don't know what to say :-/
1. Clean wine environment 2. winetricks dotnet2 3. wine supcom_patch_1.1.3269_to_1.1.3280.exe <-worked till .35, till AJ let it crash in .36, .37, then came your patch which broke it, .38 fixed crashing but your "breaking" patch remain till .40
...probably better to download and try your self or close this as fixed and move to bug 21798, which also fails from your commit.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #10 from Vincent Povirk madewokherd@gmail.com 2010-03-17 23:08:32 --- The patch changes the default load order for gdiplus. Wine used to use the native gdiplus.dll if it's available, and now it always uses the builtin version unless you set an override. This likely never worked with builtin gdiplus.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #11 from Wylda wylda@volny.cz 2010-03-17 23:19:08 ---
vanilla wine-1.1.40 <--- ** broken UI and APP does not work ** vanilla wine-1.1.40 & gdi+=builtin <--- ** broken UI and APP does not work ** vanilla wine-1.1.40 & gdi+=native <--- ** works **
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #12 from Wylda wylda@volny.cz 2010-03-17 23:21:40 ---
If you want to test it, download from above URL. It's 7MB and free (you do not need to own the game for this test).
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #13 from Benjamin Hodgetts ben@xnode.org 2010-03-18 12:15:35 --- (In reply to comment #7)
(In reply to comment #5)
I think you're looking at a different bug from the one originally reported.
Believe me Vincent, i don't ;)
Original reporter screwed several thing together and i made it clear. He filled version 1.1.40, but the crash log is from .36 or .37... As i wrote:
- 1.1.35 ~ Last working
- 1.1.36 ~ crash during the startup
- 1.1.37 ~ crash during the startup
- 1.1.38 ~ runs, but App displays error window and UI is completelly broken
.38 and later does not crash.
This is completely wrong. My report WAS from 1.1.40, thank you.
Testing with native gdiplus (and current GIT) now.
http://bugs.winehq.org/show_bug.cgi?id=22051
Benjamin Hodgetts ben@xnode.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #26844|0 |1 is obsolete| |
--- Comment #14 from Benjamin Hodgetts ben@xnode.org 2010-03-18 12:22:52 --- Created an attachment (id=26877) --> (http://bugs.winehq.org/attachment.cgi?id=26877) Crashlog +gdiplus
Ok, I'm honestly not sure why the original log looked completely different as it looked like something was very broken in .NET.
Anyway, the patch window appears but is mangled and errors out the moment it opens, clicking Ok closes the patcher.
With native GDIPlus it works without issue. Full builtin +gdiplus log attached.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #15 from Wylda wylda@volny.cz 2010-03-19 15:15:10 ---
This bisected regression is still not fixed in wine-1.1.41.
http://bugs.winehq.org/show_bug.cgi?id=22051
Benjamin Hodgetts ben@xnode.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #26865|0 |1 is obsolete| | Attachment #26866|0 |1 is obsolete| | Attachment #26867|0 |1 is obsolete| | Attachment #26877|0 |1 is obsolete| |
--- Comment #16 from Benjamin Hodgetts ben@xnode.org 2010-03-20 06:25:13 --- Created an attachment (id=26906) --> (http://bugs.winehq.org/attachment.cgi?id=26906) Patch Log with Wine 1.1.41
Ok, just to clarify what is going on here, this looks like a mix of 2 bugs. The one I originally opened and one that Wylda thought I was referring to.
With Wine 1.1.41 I just created a new prefix, installed Supreme Commander and tried to run the patch. I was then faced with the originally reported bug again.
+gdiplus adds nothing to the output so it doesn't seem to be GDI related, the output all seems to for .NET (.NET 2 is installed when the game installs).
Marking the original attachments obsolete to avoid confusion as they aren't about this specific bug.
http://bugs.winehq.org/show_bug.cgi?id=22051
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|gdiplus |-unknown
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #17 from Wylda wylda@volny.cz 2010-04-18 06:01:55 ---
Shouln't be the component set to gdiplus?
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #18 from Vincent Povirk madewokherd@gmail.com 2010-04-18 09:11:15 --- No. The originally reported problem, which is apparently still present, is not in gdiplus.
http://bugs.winehq.org/show_bug.cgi?id=22051
Xavier Vachon xvachon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon@gmail.com
--- Comment #19 from Xavier Vachon xvachon@gmail.com 2010-07-11 09:12:13 --- In current git (1.2-rc7), I need to install the Windows version of Mono in order to execute the patch:
xavier@xavier-pc /media/Supcom/Patches $ wine 3280.exe wine: Install the Windows version of Mono to run .NET executables
Then I get the following output in the patch setup:
System.NotImplementedException: The requested feature is not implemented. at System.IO.DriveInfo.GetDrives () [0x00000] at System.IO.DriveInfo..ctor (System.String driveName) [0x00000] at GPG.Patch.ApplyPatch.Validate () [0x00000] at GPG.Patch.ApplyPatch.ThreadMethod () [0x00000]
The following fixmes appear in the console:
xavier@xavier-pc /media/Supcom/Patches $ wine 3280.exe fixme:gdiplus:GdipImageGetFrameCount returning frame count of 1 fixme:gdiplus:GdipDrawImagePointsRect Color transforms not implemented fixme:gdiplus:GdipCreateBitmapFromGraphics hacked stub
http://bugs.winehq.org/show_bug.cgi?id=22051
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #20 from Anastasius Focht focht@gmx.net 2010-07-11 09:47:39 --- Hello,
--- quote --- In current git (1.2-rc7), I need to install the Windows version of Mono in order to execute the patch:
xavier@xavier-pc /media/Supcom/Patches $ wine 3280.exe wine: Install the Windows version of Mono to run .NET executables
Then I get the following output in the patch setup:
System.NotImplementedException: The requested feature is not implemented. at System.IO.DriveInfo.GetDrives () [0x00000] at System.IO.DriveInfo..ctor (System.String driveName) [0x00000] at GPG.Patch.ApplyPatch.Validate () [0x00000] at GPG.Patch.ApplyPatch.ThreadMethod () [0x00000]
--- quote ---
Mono bugs don't belong here. This bug is about a Wine insufficiency unearthed by MS .NET Framework 2.0
In general, you're better off using MS .NET Framework - contrary to what builtin mscoree tells you ("Install the Windows version of Mono to run .NET executables").
Install MS .NET Framework 2.0 (using winetricks) as the other posters did. Optionally override builtin gdiplus to work around bug 23527 (winetricks gdiplus) When reinstalling, please start over with a clean WINEPREFIX, not polluted by other software (Mono, VC++ runtimes ...).
Regards
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #21 from Xavier Vachon xvachon@gmail.com 2010-07-11 10:08:56 --- Created an attachment (id=29529) --> (http://bugs.winehq.org/attachment.cgi?id=29529) patch log with dotnet20
(In reply to comment #20)
Hello,
Mono bugs don't belong here. This bug is about a Wine insufficiency unearthed by MS .NET Framework 2.0
In general, you're better off using MS .NET Framework - contrary to what builtin mscoree tells you ("Install the Windows version of Mono to run .NET executables").
Install MS .NET Framework 2.0 (using winetricks) as the other posters did. Optionally override builtin gdiplus to work around bug 23527 (winetricks gdiplus) When reinstalling, please start over with a clean WINEPREFIX, not polluted by other software (Mono, VC++ runtimes ...).
Regards
Tried again at your request and suggestions.
In a clean prefix, with dotnet20 the patch executes and installs fine. There is an error window about a missing implementation which if I click OK, it kills the patch process. Otherwise, if I just let the patch run it works fine.
Uploading what I got from the console.
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #22 from Anastasius Focht focht@gmx.net 2010-07-11 10:22:51 --- Hello,
--- quote --- In a clean prefix, with dotnet20 the patch executes and installs fine. There is an error window about a missing implementation which if I click OK, it kills the patch process. Otherwise, if I just let the patch run it works fine.
Uploading what I got from the console. --- quote ---
So are you saying the patch tool works? If yes, the bug can be closed.
--- quote --- There is an error window about a missing implementation which if I click OK, it kills the patch process. --- quote ---
That gdiplus insufficiency is covered by bug 23527 (can be worked around by preferring native over builtin -> winetricks gdiplusw).
Regards
http://bugs.winehq.org/show_bug.cgi?id=22051
--- Comment #23 from Xavier Vachon xvachon@gmail.com 2010-07-11 11:15:09 --- (In reply to comment #22)
Hello,
--- quote --- In a clean prefix, with dotnet20 the patch executes and installs fine. There is an error window about a missing implementation which if I click OK, it kills the patch process. Otherwise, if I just let the patch run it works fine.
Uploading what I got from the console. --- quote ---
So are you saying the patch tool works? If yes, the bug can be closed.
--- quote --- There is an error window about a missing implementation which if I click OK, it kills the patch process. --- quote ---
That gdiplus insufficiency is covered by bug 23527 (can be worked around by preferring native over builtin -> winetricks gdiplusw).
Regards
The patch tool works if dotnet20 is installed. winetricks gdiplus solves the error message. If this is what you are looking for then I believe yes that this bug is fixed.
http://bugs.winehq.org/show_bug.cgi?id=22051
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID
--- Comment #24 from Dmitry Timoshkov dmitry@codeweavers.com 2010-07-12 00:17:27 --- Invalid then, not a Wine bug.
http://bugs.winehq.org/show_bug.cgi?id=22051
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #25 from Dmitry Timoshkov dmitry@codeweavers.com 2010-07-12 00:17:38 --- Closing invalid.
http://bugs.winehq.org/show_bug.cgi?id=22051
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|dotnet | Status|CLOSED |RESOLVED Resolution|INVALID |DUPLICATE
--- Comment #26 from Anastasius Focht focht@gmx.net 2010-08-01 16:00:12 --- Hello,
just some more Mono dogfood (see comment #20). I remembered this one after tracking down bug 22259
Marking this one as dupe of 22259 so functionality can be retested with this app once bug 22259 gets fixed. Removing 'dotnet' as this is Mono-only bug (app works with .NET 2.0 from winetricks).
Regards
*** This bug has been marked as a duplicate of bug 22259 ***
http://bugs.winehq.org/show_bug.cgi?id=22051
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #27 from Dmitry Timoshkov dmitry@codeweavers.com 2010-08-01 22:06:37 --- Closing duplicate.