http://bugs.winehq.org/show_bug.cgi?id=15310
Summary: DVDShrink: Preview no longer works Product: Wine Version: 1.1.4 Platform: PC OS/Version: Linux Status: NEW Keywords: download, regression Severity: minor Priority: P2 Component: quartz AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Created an attachment (id=16141) --> (http://bugs.winehq.org/attachment.cgi?id=16141) +quartz
Regression, saw it reported in AppDB (feature I don't use much...)
Hangs on: err:ntdll:RtlpWaitForCriticalSection section 0x14a05c "videorenderer.c: VideoRendererImpl.csFilter" wait timed out in thread 0009, blocked by 0029, retrying (60 sec)
austin@austin-desktop:~/wine-git$ git bisect good 9985f2efc9d1e92932dd3d7f351ded3ae1db0b80 is first bad commit commit 9985f2efc9d1e92932dd3d7f351ded3ae1db0b80 Author: Maarten Lankhorst m.b.lankhorst@gmail.com Date: Fri Jul 4 01:33:04 2008 -0700
quartz: Implement state transitions in video renderer.
:040000 040000 e9d8793bdcec724b6a750908bc054baf329c8655 66c05bda331c3503e8d85b69303108d00d5830c6 M dlls
+quartz attached
http://bugs.winehq.org/show_bug.cgi?id=15310
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |m.b.lankhorst@gmail.com
--- Comment #1 from Austin English austinenglish@gmail.com 2008-09-17 17:47:00 --- CC'ing Maarten
http://bugs.winehq.org/show_bug.cgi?id=15310
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.afterdawn.com/sof | |tware/video_software/dvd_rip | |pers/dvd_shrink.cfm
http://bugs.winehq.org/show_bug.cgi?id=15310
--- Comment #2 from Maarten Lankhorst m.b.lankhorst@gmail.com 2008-09-17 18:32:44 --- Can you attach a debugger and get a backtrace of the 2 threads locked?
When it's locked:
wine winedbg bt all
http://bugs.winehq.org/show_bug.cgi?id=15310
--- Comment #3 from Austin English austinenglish@gmail.com 2008-09-17 19:54:25 --- Created an attachment (id=16146) --> (http://bugs.winehq.org/attachment.cgi?id=16146) backtrace in git
Here you go, let me know if you need anything else!
On a side note, is there any way to redirect winedbg's output?
http://bugs.winehq.org/show_bug.cgi?id=15310
--- Comment #4 from oneforall oneforall59@hotmail.com 2008-10-02 01:43:54 --- Created an attachment (id=16411) --> (http://bugs.winehq.org/attachment.cgi?id=16411) dvdshrink viewer work around or patch
Hope this helps
http://bugs.winehq.org/show_bug.cgi?id=15310
oneforall oneforall59@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |oneforall59@hotmail.com
--- Comment #5 from oneforall oneforall59@hotmail.com 2008-10-02 01:46:55 --- Hi I got that to with 1.1.5. I found out that it works with Preference > Built in Software Renderer and it was hanging for me with that error with System Default renderer But wine 1.1.0 worked with either regression test the offending patch is c959867510703a100106f292cd26cb8f489236bb git revert 9985f2efc9d1e92932dd3d7f351ded3ae1db0b80 failed to work its wine-1.1.5/dlls/quartz/videorenderer.c :)
THIS DIDN"T GO WITH THE ATTACHMENT
http://bugs.winehq.org/show_bug.cgi?id=15310
Maarten Lankhorst m.b.lankhorst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs@winehq.org |m.b.lankhorst@gmail.com
--- Comment #6 from Maarten Lankhorst m.b.lankhorst@gmail.com 2008-10-02 09:19:44 --- It sees to me that the deadlock is the initialization code. SetWindowPos never returns. Does adding ShowWindow(This->hWnd, SW_SHOW); before the SetWindowPos call at line 332 work?
http://bugs.winehq.org/show_bug.cgi?id=15310
--- Comment #7 from Austin English austinenglish@gmail.com 2008-10-05 19:55:47 --- (In reply to comment #6)
It sees to me that the deadlock is the initialization code. SetWindowPos never returns. Does adding ShowWindow(This->hWnd, SW_SHOW); before the SetWindowPos call at line 332 work?
diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c index c7d6582..95b13eb 100644 --- a/dlls/quartz/videorenderer.c +++ b/dlls/quartz/videorenderer.c @@ -322,6 +322,9 @@ static DWORD VideoRenderer_SendSampleData(VideoRendererImpl* This, LPBYTE data, This->WindowPos = This->SourceRect;
TRACE("WindowPos: %d %d %d %d\n", This->WindowPos.left, This->WindowPos.top, This->WindowPos.right, This->WindowPos.bottom); + + ShowWindow(This->hWnd, SW_SHOW); + SetWindowPos(This->hWnd, NULL, This->WindowPos.left, This->WindowPos.top,
Nope, still fails.
http://bugs.winehq.org/show_bug.cgi?id=15310
--- Comment #8 from Austin English austinenglish@gmail.com 2009-01-04 01:16:14 --- Still present in git.
http://bugs.winehq.org/show_bug.cgi?id=15310
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #9 from Austin English austinenglish@gmail.com 2009-04-27 02:12:28 --- Seems okay for me now.
http://bugs.winehq.org/show_bug.cgi?id=15310
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2009-05-08 12:47:40 --- Closing bugs fixed in 1.1.21.
-
wine-bugs＠winehq.org