https://bugs.winehq.org/show_bug.cgi?id=50096
Bug ID: 50096 Summary: Performance Regression in Secondhand Lands Product: Wine Version: 5.14 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs@winehq.org Reporter: escomk3@hotmail.com Distribution: ---
Created attachment 68573 --> https://bugs.winehq.org/attachment.cgi?id=68573 Good and Bad Terminal Output (+xranrd)
After 9905a5a8 [1], the maximum FPS reached in Secondhand Lands can be around 5, when it is around 30-120 (120 being the maximum limit) depending on the situation before this commit.
Running some quick profiling, there doesn't seem to be obvious (to me) differences between the good and the bad in that regard.
Adding some TRACEs into the new code, I couldn't notice yet if anything there was being called a lot, but I did notice something that may or may not be a bit odd:
In 'xrandr14_get_gpus2' [2] I'm seeing 'new_gpus: 4' and 'count: 3265744', which seems a "little bit" excessive (though I'm not sure if I'm doing things right at all, nor do I necessarily understand the code at all).
This is how I was counting them:
*new_gpus = gpus; TRACE("new_gpus: %d.\n"); *count = provider_resources->nproviders; TRACE("count: %d.\n", count); ret = TRUE;
Download (no account is needed as the issues is visible in the main title menu already):
- https://www.secondhandlands.com/download.php
Some Winetricks are required to get the game running at all:
- d3dx9_43 - d3dcompiler_43
Latest Wine version tested:
- wine-5.20-234-gb793799d3d5
1. https://source.winehq.org/git/wine.git/commitdiff/9905a5a81d6baf59e992c5b2a8... 2. https://source.winehq.org/git/wine.git/blob/9905a5a81d6baf59e992c5b2a8ea92ee...
https://bugs.winehq.org/show_bug.cgi?id=50096
Chiitoo escomk3@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |9905a5a81d6baf59e992c5b2a8e | |a92ee4054e5d6 Distribution|--- |Gentoo
https://bugs.winehq.org/show_bug.cgi?id=50096
soredake gi85qht0z@relay.firefox.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gi85qht0z@relay.firefox.com
https://bugs.winehq.org/show_bug.cgi?id=50096
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download CC| |o.dierick@piezo-forte.be URL| |https://www.secondhandlands | |.com/download.php
--- Comment #1 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
Just a note to say that the game is available free to play, if anyone is interested in testing this.
It can be downloaded from: - the vendor website: https://www.secondhandlands.com/download.php - the Steam store: https://store.steampowered.com/app/675230/Secondhand_Lands/
Both require an account (free) and a client installation.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=50096
--- Comment #2 from Chiitoo escomk3@hotmail.com --- (In reply to Olivier F. R. Dierick from comment #1)
Hello,
Just a note to say that the game is available free to play, if anyone is interested in testing this.
It can be downloaded from:
- the vendor website: https://www.secondhandlands.com/download.php
- the Steam store:
https://store.steampowered.com/app/675230/Secondhand_Lands/
Both require an account (free) and a client installation.
Regards.
Thanks, though as I mentioned in the report, no account is needed to see this issue (if using the non-Steam install), as the problem can be seen in the title menu already (before logging in). :]
https://bugs.winehq.org/show_bug.cgi?id=50096
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang@codeweavers.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW
--- Comment #3 from Zhiyi Zhang zzhang@codeweavers.com --- Confirmed. Expect a fix soon.
https://bugs.winehq.org/show_bug.cgi?id=50096
--- Comment #4 from Zhiyi Zhang zzhang@codeweavers.com --- Created attachment 68584 --> https://bugs.winehq.org/attachment.cgi?id=68584 patch
Please test this patch. It should fix the performance regression.
https://bugs.winehq.org/show_bug.cgi?id=50096
--- Comment #5 from Chiitoo escomk3@hotmail.com --- Yup, works for me.
Thanks!
https://bugs.winehq.org/show_bug.cgi?id=50096
Zhiyi Zhang zzhang@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d8c9671d4da1a3b2ae912bec2aa | |5ffef37ff8410 Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #6 from Zhiyi Zhang zzhang@codeweavers.com --- Fixed by d8c9671d4da1a3b2ae912bec2aa5ffef37ff8410
https://bugs.winehq.org/show_bug.cgi?id=50096
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.0-rc1.