[Bug 11991] New: Wine Windows OpenGL support regression

http://bugs.winehq.org/show_bug.cgi?id=11991

Summary: Wine Windows OpenGL support regression
           Product: Wine
           Version: 0.9.57.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Dear Wine developers,

This is wine version 0.9.56 and 0.9.57

There are two games that support OpenGL rendering as well as Direct3D redering.

Here are the games:

1. Hitmen 2 Silent Assasin
                   2. Hitmen 3 Contracts

When I have updated my wine version to 0.9.57, then these games are not playing
anymore with OpenGL rendering. But when I start these games with Direct3D
rendering they are playing fine.

These games played properly with wine version 0.9.55 with OpenGL rendering as
well as Direct3D rendering.

Then I have decided to reinstall wine 0.9.55.

Sorry for the err message printed in the command line. Because I do not have
Internet connection in my home PC.

Best regards,
DXL

[Bug 11991] Wine Windows OpenGL support regression

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #1 from Timo-Heikki Mäkelä   2008-03-11 08:26:36 ---
Once you've reinstalled 0.9.55 and tested those games again there, could you
first confirm they work normally and thus it's really a regression, please.

Thereafter, if it really is a regression, please, could you run a regression
test to find out what went wrong.
http://wiki.winehq.org/RegressionTesting

[Bug 11991] Wine Windows OpenGL support regression

http://bugs.winehq.org/show_bug.cgi?id=11991

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |opengl

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
            Summary|Wine Windows OpenGL support |OpenGL regression in Hitman
                   |regression                  |2 and Hitman 3

--- Comment #2 from Lei Zhang   2008-03-11 13:06:46 ---
Does the demo have the same problem?
http://www.eidosinteractive.com/downloads/search.html?gmid=118

severity is not critical

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #3 from Roderick Colenbrander   2008-03-31 15:30:32 ---
Any update on this?

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

killertux  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

--- Comment #4 from killertux   2008-04-20 21:12:37 ---
This is what I get from regression testing.

8ee07d49aeb096f5f91eced1cb969633d0decc32 is first bad commit
commit 8ee07d49aeb096f5f91eced1cb969633d0decc32
Author: Alexandre Julliard 
Date:   Thu Feb 21 12:29:36 2008 +0100

winex11: Re-introduce a separate X11 window for the client area of
top-level windows.

anyway bug 12212 has the same bad commit...
tested with Hitman 2 Demo and Hitman 1 retail
both have same PixelFormat errors then crash differently so I expect Hitman 1
has the same bug when running with OpenGL.

Also did not work in Wine 0.9.60 same error as usual.

added download and regression keywords.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

killertux  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #5 from Roderick Colenbrander   2008-04-29 14:32:26 ---
What sort of pixel format issues are there then? I don't know what is wrong. If
you can show the issue using a +wgl log then add it.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #6 from killertux   2008-05-04 14:29:43 ---
Created an attachment (id=12717)
 --> (http://bugs.winehq.org/attachment.cgi?id=12717)
+wgl debug from Hitman: Codename 47 Demo 2

I think it's the same issue with all hitman 1, 2 and 3(contracts) on OpenGL at
lest all those was broken by same regression and same PixelFormat errors
happened after that patch.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #7 from Roderick Colenbrander   2008-05-04 15:31:43 ---
It appears that X11DRV_SET_DRAWABLE overrides the pixel format set on the
physDev. This appears to cause the crash as for some reason the pixel format is
set to 0 which is an invalid value. I'm not sure yet why it is happening it
could be that no X11 window has been allocated yet or so.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #8 from Roderick Colenbrander   2008-05-04 15:45:31 ---
The GetDC code in winex11.drv isn't setting the fbconfig and gl_drawable for
some reason. After forcing it the game starts (I hear the music) but I don't
see any graphics likely the window has dimensions 1x1 or something like that.
Alexandre should take a look at it.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #9 from Roderick Colenbrander   2008-05-11 14:18:51 ---
The issue is related to the delayed creation of X11 windows. It is not trivial
to fix.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #10 from Roderick Colenbrander   2008-05-17 05:18:32 ---
Could you check if this issue is over? Some fixes have been added to
winex11.drv recently which might have fixed this as well.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Roderick Colenbrander   2008-05-18 06:18:10 ---
*** Bug 13293 has been marked as a duplicate of this bug. ***

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Roderick Colenbrander   2008-05-18 11:00:05 ---
*** Bug 13195 has been marked as a duplicate of this bug. ***

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Eric  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Eric   2008-05-18 17:28:29 ---
(In reply to comment #10)
> Could you check if this issue is over? Some fixes have been added to
> winex11.drv recently which might have fixed this as well.

Still broken.

$ wine hitman2
fixme:iphlpapi:NotifyAddrChange (Handle 0x7dbf4a08, overlapped 0x7dbf49ec):
stub
fixme:shell:DllCanUnloadNow stub
wine: configuration in '/home/eric/.wine' has been updated.
fixme:dinput:SysMouseAImpl_Acquire Clipping cursor to (0,0)-(800,600)
err:wgl:X11DRV_GetPixelFormat Unable to find a WineGLPixelFormat for
iPixelFormat=0
err:wgl:X11DRV_wglCreateContext Cannot get FB Config for iPixelFormat 0, expect
problems!
err:seh:setup_exception_record stack overflow 912 bytes in thread 0009 eip
7bc4f2bc esp 00230fa0 stack 0x230000-0x231000-0x330000

$ wine --version
wine-1.0-rc1

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Leszek Godlewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Leszek Godlewski   2008-05-24 06:02:20 ---
This bug also affects Medal of Honor Allied Assault since Wine 0.9.61 (game
worked OK in 0.9.60) up until now (1.0-rc2).

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #15 from Eric   2008-05-24 06:26:58 ---
Confirmed: Hitman 2 still borked.

$ wine hitman2
fixme:dinput:SysMouseAImpl_Acquire Clipping cursor to (0,0)-(1024,768)
err:wgl:X11DRV_wglCreateContext Cannot get FB Config for iPixelFormat 0, expect
problems!
err:seh:setup_exception_record stack overflow 912 bytes in thread 0009 eip
7bc4f2bc esp 00230fa0 stack 0x230000-0x231000-0x330000

$ wine --version
wine-1.0-rc2

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #16 from denis bonnenfant   2008-05-26 04:54:55 ---
No changes in rc2 for SolidWorks too.

I tried to investigate it a little bit, but I didn't understand how the hdc is
initialized.

When opening a new part, the opengl viewport is created, and everything is
displayed correctly in the graphics window.

Every time I do some operation in this window, have this messages :

trace:wgl:wglGetCurrentContext  returning 0xe8d6098
trace:wgl:wglGetCurrentContext  returning 0xe8d6098
trace:wgl:wglGetCurrentDC  found context: 0xe8d6098
trace:wgl:wglGetCurrentDC  returning hdc: 0x3530
trace:wgl:wine_glFlush ()
trace:wgl:wglMakeCurrent hdc: ((nil)), hglrc: ((nil))
trace:wgl:X11DRV_wglMakeCurrent (0x344,(nil))
trace:wgl:X11DRV_wglMakeCurrent  returning True

the strange thing is that wglMakeCurrent hdc: ((nil)) is not using what
wglGetCurrentDC returns

If i click on some toolbars, or menus, or anywhere except the graphics window,
i get this :

trace:wgl:wglMakeCurrent hdc: (0x3530), hglrc: (0xe8d6098)
trace:wgl:X11DRV_wglMakeCurrent (0x3530,0xe8d6098)
trace:wgl:X11DRV_wglMakeCurrent  make current for dis 0x7c03e618, drawable
(nil), ctx 0x7c1d96dc
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  128 (GLX)
  Minor opcode of failed request:  5 (X_GLXMakeCurrent)
  Serial number of failed request:  309209
  Current serial number in output stream:  309209

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Dan Kegel   2008-05-26 10:09:14 ---
What graphics card and X driver are you using?

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #18 from denis bonnenfant   2008-05-26 14:32:33 ---
(In reply to comment #17)
> What graphics card and X driver are you using?

a GForce 6800, with ubuntu 8.04 driver :

000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo GL version             : 2.1.2
NVIDIA 169.12.
000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo GL renderer            : GeForce
6800/AGP/SSE2.
000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo GLX version            : 1.3.
000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo Server GLX version     : 1.4.
000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo Server GLX vendor:     : NVIDIA
Corporation.
000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo Client GLX version     : 1.4.
000b:trace:wgl:X11DRV_WineGL_InitOpenglInfo Client GLX vendor:     : NVIDIA
Corporation.
0

complete log was attached with bug 13195

I tried with or without compiz, but i saw no changes.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #19 from Dan Kegel   2008-05-26 14:53:56 ---
I suppose you could try the latest nvidia driver...?
http://www.nvidia.com/object/linux_display_ia32_169.12.html

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #20 from denis bonnenfant   2008-05-26 15:12:28 ---
(In reply to comment #19)
> I suppose you could try the latest nvidia driver...?
> http://www.nvidia.com/object/linux_display_ia32_169.12.html

This is the one I run.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #21 from Dan Kegel   2008-05-26 15:37:34 ---
Sorry, I should have seen that.  I'll just go hide in a hole for a while....

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #22 from Vitaliy Margolen   2008-05-27 01:11:31 ---
Confirming. Same problem here as well. Last working version wine-0.9.55

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #23 from denis bonnenfant   2008-05-27 03:00:37 ---
Is there a way to trace more precisely than +wgl how the windows or offscreen
buffers are constructed ? I tried +x11drv, but I found nothing useable.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #24 from denis bonnenfant   2008-05-27 04:09:56 ---
Created an attachment (id=13386)
 --> (http://bugs.winehq.org/attachment.cgi?id=13386)
patch for X11DRV_wglCreateContext in SolidWorks

This hack allows SolidWorks to go a little bit further and experiment a little
bit, but i guess that it is not the good way to go !

Looks like contexts and child windows are not correctly created, as some
drawings are made outside of the graphics windows. I wonder how compositing is
used for multiple windows, but i guess that the problem may be here.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #25 from denis bonnenfant   2008-05-27 08:58:17 ---
Created an attachment (id=13397)
 --> (http://bugs.winehq.org/attachment.cgi?id=13397)
lines offset due to redraw in the main window

the screenshot shows that some redraws are done on the main windows, and not
the graphics one. When I attempt to resize the left panel, I have the BadMatch
crash

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

denis bonnenfant  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12582

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #26 from Alexandre Julliard   2008-05-28 08:42:02 ---
The problem is that the app is doing GL calls on a window DC instead of a
normal client DC. It's not clear how that is supposed to behave, it will need
some tests on Windows.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #27 from Alexandre Julliard   2008-05-28 14:47:32 ---
Should be fixed by 2d9b38133b292f01661a527f7aa0974c0ebc9278.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #28 from denis bonnenfant   2008-05-28 15:31:55 ---
Created an attachment (id=13439)
 --> (http://bugs.winehq.org/attachment.cgi?id=13439)
+wgl log

SolidWorks still crashes when opening a new window

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13439|application/octet-stream    |text/plain
          mime type|                            |

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #29 from Alexandre Julliard   2008-05-28 15:55:37 ---
That's a different issue, please file a new bug for it.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #30 from Alexandre Julliard   2008-05-31 04:18:37 ---
Closing bugs fixed in 1.0-rc3.

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

--- Comment #31 from denis bonnenfant   2008-06-02 02:48:59 ---
I reopened the initial bug 13195 for the SolidWorks issue.

Thanks

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

http://bugs.winehq.org/show_bug.cgi?id=11991

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2d9b38133b292f01661a527f7aa
                   |                            |0974c0ebc9278
                 CC|                            |[e-mail]
          Component|opengl                      |winex11.drv
    Regression SHA1|                            |8ee07d49aeb096f5f91eced1cb9
                   |                            |69633d0decc32

[Bug 11991] OpenGL regression in Hitman 2 and Hitman 3

https://bugs.winehq.org/show_bug.cgi?id=11991

Paula  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]