[Bug 48441] New: mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Bug ID: 48441
           Summary: mouse coordinates cannot exceed initial desktop size
                    during startup of wineserver
           Product: Wine
           Version: 5.0-rc4
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 66219
  --> https://bugs.winehq.org/attachment.cgi?id=66219
archive with a script and textfile demonstrating the problem

When starting a Windows application in Wine, with desktop dimensions of e.g.
800x600, and extending the desktop dimensions to e.g. 1280x1024 while
wineserver is still running, the desktop dimensions reported to the application
are correct since the support for XRandR device change notifications in Wine
4.17.

However, the mouse coordinates in e.g. WM_MOUSEMOVE never exceed the original
desktop dimensions of 800x600.

Only restarting wineserver resolves this.

The attachment demonstrates the problem, containing a small bash script and a
textfile for notepad.exe

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Zhiyi Zhang  ---
Confirmed with Wine-5.0-rc5. This is because of external resolution change
doesn't trigger a desktop size update. The following patch should be enough to
support it.

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #2 from Zhiyi Zhang  ---
Created attachment 66247
  --> https://bugs.winehq.org/attachment.cgi?id=66247
patch

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #3 from Diederik van Bochove  ---
(In reply to Zhiyi Zhang from comment #2)
> Created attachment 66247 [details]
> patch

Great, thanks!. I'm going to try to build Wine myself, to see if it solves my
problem, although I suppose it does. It will be the first time for me to
compile Wine. Can I checkout wine 5.0 rc5, apply the patch, compile wine and
copy winex11.drv.so over to my current wine installation?

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #4 from Zhiyi Zhang  ---
(In reply to Diederik van Bochove from comment #3)
> (In reply to Zhiyi Zhang from comment #2)
> > Created attachment 66247 [details]
> > patch
>
> Great, thanks!. I'm going to try to build Wine myself, to see if it solves
> my problem, although I suppose it does. It will be the first time for me to
> compile Wine. Can I checkout wine 5.0 rc5, apply the patch, compile wine and
> copy winex11.drv.so over to my current wine installation?

It would be better to use `make install` to install a newer version of Wine
instead of copying .so around because winex11.drv.so ABI backward compatibility
is not guaranteed. Note that the patch should fix your problem for now but it's
very experimental and might break other things. The fix that will end up
upstream maybe different.

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #5 from Diederik van Bochove  ---
Finally, I managed to compile wine with this patch and test it, it took me a
couple of days. (I've learned a lot, in the mean time) The patch solves my
problem. As far as I could see, it didn't break other things, but I would not
know how to test that properly.

Because I use wine in a Debian amd64 environment, I didn't succeed in compiling
and installing wine form sources in that environment, so I created a Debian
i386 virtual machine, installed the Debian source package (form winehq.org),
applied the patch and compiled it with "debuild". After the build succeeded, I
copied winex11.drv.so to my Debian amd64 environment.

Although I know it's not the recommended way to test, it was the only way in
which I succeeded.

Is there anything I can do to get this patch or a similar patch upstream?

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #6 from Zhiyi Zhang  ---
> Is there anything I can do to get this patch or a similar patch upstream?

No. I made some new changes and will get the fix upstream as soon as I can.

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #7 from Diederik van Bochove  ---
Any news regarding the final patch?

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #8 from Zhiyi Zhang  ---
(In reply to Diederik van Bochove from comment #7)
> Any news regarding the final patch?

https://source.winehq.org/patches/data/185019

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #9 from Diederik van Bochove  ---
(In reply to Zhiyi Zhang from comment #8)
> (In reply to Diederik van Bochove from comment #7)
> > Any news regarding the final patch?
>
> https://source.winehq.org/patches/data/185019

Great, thanks a lot!

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Zhiyi Zhang  ---
Fixed by fd6f50c0d3e96947846ca82ed0c9bd79fd8e5b80

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |fd6f50c0d3e96947846ca82ed0c
                   |                            |9bd79fd8e5b80

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

--- Comment #11 from Diederik van Bochove  ---
(In reply to Zhiyi Zhang from comment #10)
> Fixed by fd6f50c0d3e96947846ca82ed0c9bd79fd8e5b80

Thanks!

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  ---
Closing bugs fixed in 5.9.

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0.x

[Bug 48441] mouse coordinates cannot exceed initial desktop size during startup of wineserver

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48441

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|5.0.x                       |---

--- Comment #13 from Michael Stefaniuc  ---
Removing the 5.0.x milestone from bug fixes that didn't make it into 5.0.x.