[Bug 52736] New: Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

Bug ID: 52736
           Summary: Argentum 20 RPG Launcher has graphical glitches when
                    compiled with -O2
           Product: Wine
           Version: 7.3
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Split of from bug 52729. Aside from the there mentioned regression, there still
are graphical glitches. See screenshots. Although those only seem to happen
when compiling with -O2, -O0 doesn't reproduce them.

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |52729

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #1 from Fabian Maurer  ---
Created attachment 72096
  --> https://bugs.winehq.org/attachment.cgi?id=72096
Screenshot (Win7)

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #2 from Fabian Maurer  ---
Created attachment 72097
  --> https://bugs.winehq.org/attachment.cgi?id=72097
Screenshot (wine-7.2)

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #3 from Fabian Maurer  ---
Created attachment 72100
  --> https://bugs.winehq.org/attachment.cgi?id=72100
Hack to "work around" the issue

As noted, this is dependent on the optimizations. This hack makes it work even
with -O2, hopefully narrowing it a bit down...

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #4 from Dmitry Timoshkov  ---
(In reply to Fabian Maurer from comment #3)
> Created attachment 72100 [details]
> Hack to "work around" the issue
>
> As noted, this is dependent on the optimizations. This hack makes it work
> even with -O2, hopefully narrowing it a bit down...

Does it help if you add DECLSPEC_HOTPATCH to these methods enstead?

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #5 from Fabian Maurer  ---
> Does it help if you add DECLSPEC_HOTPATCH to these methods enstead?

Doesn't help, no.
On a side note, I thought DECLSPEC_HOTPATCH wasn't needed anymore due to
-fno-PIC?

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #6 from Dmitry Timoshkov  ---
(In reply to Fabian Maurer from comment #5)
> > Does it help if you add DECLSPEC_HOTPATCH to these methods enstead?
>
> Doesn't help, no.
> On a side note, I thought DECLSPEC_HOTPATCH wasn't needed anymore due to
> -fno-PIC?

PIC and hotpatch are different things.

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Zebediah Figura  ---
(In reply to Fabian Maurer from comment #5)
> > Does it help if you add DECLSPEC_HOTPATCH to these methods enstead?
>
> Doesn't help, no.
> On a side note, I thought DECLSPEC_HOTPATCH wasn't needed anymore due to
> -fno-PIC?

Not exactly. Many applications tried to patch the first few bytes of a
function, using engines that could recognize many different x86 instructions
but couldn't handle GOT loads, and so would be fixed by either one. But some
applications choked on GOT loads past the first five bytes (so they really do
need -fno-PIC), and some applications really do expect the verbatim hotpatch
prefix (so they really do need DECLSPEC_HOTPATCH).

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #8 from Dmitry Timoshkov  ---
(In reply to Fabian Maurer from comment #5)
> > Does it help if you add DECLSPEC_HOTPATCH to these methods enstead?
>
> Doesn't help, no.
> On a side note, I thought DECLSPEC_HOTPATCH wasn't needed anymore due to
> -fno-PIC?

Another thing you could try is removing 'static', and combining these two
things.

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

--- Comment #9 from Fabian Maurer  ---
> Another thing you could try is removing 'static', and combining these two
> things.

Doesn't help either.

[Bug 52736] Argentum 20 RPG Launcher has graphical glitches when compiled with -O2

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52736

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20220326025902/https://www
                   |                            |.elmesonhostigado.com/foro/
                   |                            |instalador/Instalador_AO20.
                   |                            |exe
           Keywords|                            |download, Installer