[Bug 42328] New: Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

Bug ID: 42328
           Summary: Wine does not build on macos os x if  --with-gnutls is
                    passed to configure and gnutls is installed
           Product: Wine-staging
           Version: 2.0
          Hardware: x86-64
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]

/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:891:5: error: unknown type
name 'gnutls_cipher_hd_t'
    gnutls_cipher_hd_t handle;
    ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:907:10: error: use of
undeclared identifier 'libgnutls_handle'
    if (!libgnutls_handle) return STATUS_INTERNAL_ERROR;
         ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:975:8: error: unknown type
name 'gnutls_cipher_algorithm_t'
static gnutls_cipher_algorithm_t get_gnutls_cipher( const struct key *key )
       ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:983:38: error: use of
undeclared identifier 'GNUTLS_CIPHER_AES_128_GCM'
            case MODE_ID_GCM: return GNUTLS_CIPHER_AES_128_GCM;
                                     ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:985:38: error: use of
undeclared identifier 'GNUTLS_CIPHER_AES_128_CBC'
            default:          return GNUTLS_CIPHER_AES_128_CBC;
                                     ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:989:16: error: use of
undeclared identifier 'GNUTLS_CIPHER_UNKNOWN'
        return GNUTLS_CIPHER_UNKNOWN;
               ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:995:5: error: use of
undeclared identifier 'gnutls_cipher_algorithm_t'
    gnutls_cipher_algorithm_t cipher;
    ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:996:5: error: use of
undeclared identifier 'gnutls_datum_t'
    gnutls_datum_t secret, vector;
    ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1001:9: warning: implicit
declaration of function 'pgnutls_cipher_deinit' is invalid in C99
[-Wimplicit-function-declaration]
        pgnutls_cipher_deinit( key->handle );
        ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1005:10: error: use of
undeclared identifier 'cipher'
    if ((cipher = get_gnutls_cipher( key )) == GNUTLS_CIPHER_UNKNOWN)
         ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1005:48: error: use of
undeclared identifier 'GNUTLS_CIPHER_UNKNOWN'
    if ((cipher = get_gnutls_cipher( key )) == GNUTLS_CIPHER_UNKNOWN)
                                               ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1008:5: error: use of
undeclared identifier 'secret'
    secret.data = key->secret;
    ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1009:5: error: use of
undeclared identifier 'secret'
    secret.size = key->secret_len;
    ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1012:9: error: use of
undeclared identifier 'vector'
        vector.data = iv;
        ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1013:9: error: use of
undeclared identifier 'vector'
        vector.size = iv_len;
        ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1016:16: warning: implicit
declaration of function 'pgnutls_cipher_init' is invalid in C99
[-Wimplicit-function-declaration]
    if ((ret = pgnutls_cipher_init( &key->handle, cipher, &secret, iv ? &vector
: NULL )))
               ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1016:74: error: use of
undeclared identifier 'vector'
    if ((ret = pgnutls_cipher_init( &key->handle, cipher, &secret, iv ? &vector
: NULL )))
                                                                         ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1016:51: error: use of
undeclared identifier 'cipher'
    if ((ret = pgnutls_cipher_init( &key->handle, cipher, &secret, iv ? &vector
: NULL )))
                                                  ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1016:60: error: use of
undeclared identifier 'secret'
    if ((ret = pgnutls_cipher_init( &key->handle, cipher, &secret, iv ? &vector
: NULL )))
                                                           ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1018:9: warning: implicit
declaration of function 'pgnutls_perror' is invalid in C99
[-Wimplicit-function-declaration]
        pgnutls_perror( ret );
        ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1029:16: warning: implicit
declaration of function 'pgnutls_cipher_add_auth' is invalid in C99
[-Wimplicit-function-declaration]
    if ((ret = pgnutls_cipher_add_auth( key->handle, auth_data, len )))
               ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1043:16: warning: implicit
declaration of function 'pgnutls_cipher_encrypt2' is invalid in C99
[-Wimplicit-function-declaration]
    if ((ret = pgnutls_cipher_encrypt2( key->handle, input, input_len, output,
output_len )))
               ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1057:16: warning: implicit
declaration of function 'pgnutls_cipher_decrypt2' is invalid in C99
[-Wimplicit-function-declaration]
    if ((ret = pgnutls_cipher_decrypt2( key->handle, input, input_len, output,
output_len )))
               ^
/Users/dave/src/wine-git/dlls/bcrypt/bcrypt_main.c:1070:16: warning: implicit
declaration of function 'pgnutls_cipher_tag' is invalid in C99
[-Wimplicit-function-declaration]
    if ((ret = pgnutls_cipher_tag( key->handle, tag, len )))
               ^
7 warnings and 17 errors generated.
make[1]: *** [bcrypt_main.o] Error 1
make: *** [dlls/bcrypt] Error 2

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

--- Comment #1 from Sebastian Lackner  ---
Thanks for the bug report. In the future, please provide build logs as
attachment instead of using the comment field.

Could you please show the content of config.log? I suspect that
HAVE_GNUTLS_HASH is set, although SONAME_LIBGNUTLS is not set (because the
gnutls library was not found, only headers). This combination suggests that
there is something wrong with your gnutls installation.

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

--- Comment #2 from Dave-C  ---
Created attachment 57079
  --> https://bugs.winehq.org/attachment.cgi?id=57079
config.log

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

--- Comment #3 from Sebastian Lackner  ---
(In reply to Dave-C from comment #2)
> Created attachment 57079 [details]
> config.log

Thanks! The log shows that my initial theory is wrong, the problem is that both
gnutls and commoncrypto are available and one check is not done correctly.
Could you test the following patch, please? http://ix.io/1Ron

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

--- Comment #4 from Dave-C  ---
(In reply to Sebastian Lackner from comment #3)
> (In reply to Dave-C from comment #2)
> > Created attachment 57079 [details]
> > config.log
>
> Thanks! The log shows that my initial theory is wrong, the problem is that
> both gnutls and commoncrypto are available and one check is not done
> correctly. Could you test the following patch, please? http://ix.io/1Ron

Build succeeded with the patch!

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail] ---
(In reply to Dave-C from comment #4)
> (In reply to Sebastian Lackner from comment #3)
> > (In reply to Dave-C from comment #2)
> > > Created attachment 57079 [details]
> > > config.log
> >
> > Thanks! The log shows that my initial theory is wrong, the problem is that
> > both gnutls and commoncrypto are available and one check is not done
> > correctly. Could you test the following patch, please? http://ix.io/1Ron
>
> Build succeeded with the patch!

Since the patch worked, it can be merged in next release? This is kinda
reminder note.

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

--- Comment #6 from Sebastian Lackner  ---
(In reply to winetest from comment #5)
> Since the patch worked, it can be merged in next release? This is kinda
> reminder note.

It already has been merged (in
https://github.com/wine-compholio/wine-staging/commit/8f474115cd537c03f88050...)
and will be available with the 2.1 release.

@Dave-C: Please retest after 2.1 has been pushed and let me know if everything
works.

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

--- Comment #7 from Dave-C  ---
Wine Staging 2.1 builds successfully on macOS!

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Sebastian Lackner  ---
(In reply to Dave-C from comment #7)
> Wine Staging 2.1 builds successfully on macOS!

Thanks for testing, marking FIXED.

[Bug 42328] Wine does not build on macos os x if --with-gnutls is passed to configure and gnutls is installed

https://bugs.winehq.org/show_bug.cgi?id=42328

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alistair Leslie-Hughes  ---
Closing Fixed Staging 3.14