[Bug 24325] New: MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Summary: MSXML Parser corrupts line breaks
           Product: Wine
           Version: 1.1.42
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=30657)
 --> (http://bugs.winehq.org/attachment.cgi?id=30657)
Corrupt xml file

If the parser is set to auto indent lines, the \r line breaks are replaced by
"
", resulting in an invalid XML file.

The \n breaks are written fine, though.

I wrote a testcase in delphi, i attached both the testcase and the resulting
XML file.

If I install winetricks msxml3, the problem disappears, and files are written
fine.

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #1 from Austin English  2010-09-09 14:34:30 CDT ---
Please attach a +msxml trace (with builtin, not native).

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #2 from Christopher Bittner  2010-09-09 14:34:56 CDT ---
Created an attachment (id=30659)
 --> (http://bugs.winehq.org/attachment.cgi?id=30659)
Testcase written in delphi

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #3 from Christopher Bittner  2010-09-09 14:47:01 CDT ---
Created an attachment (id=30661)
 --> (http://bugs.winehq.org/attachment.cgi?id=30661)
msxml trace

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Christopher Bittner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30661|application/octet-stream    |text/plain
          mime type|                            |

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Andrew Nguyen  2010-09-09 14:57:50 CDT ---
I see the problem in wine-1.3.2-157-g2c4b081.

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail] 2011-06-27 06:55:08 CDT ---
Still in 1.3.23

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #6 from [e-mail] 2011-07-03 10:58:19 CDT ---
Looked this and here is what I found.

First and last line of saved XML doesn't contain \r, it was stripped.

domdoc.c: domdoc_save

ctx = xmlSaveToIO(domdoc_save_writecallback, domdoc_save_closecallback, handle,
NULL, XML_SAVE_NO_DECL);

If change that to:

ctx = xmlSaveToIO(domdoc_save_writecallback, domdoc_save_closecallback, handle,
"UTF-8", XML_SAVE_NO_DECL);

-> 
 is replaced with 

Not sure if related, but read answer: 
http://mail.gnome.org/archives/xml/2011-June/msg00013.html

Maybe just strip remaining \r in "node_set_content"? Not exactly same XML as
Windows, but \r may not be possible using libxml2..

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30657|text/xml                    |text/plain
          mime type|                            |

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Hans Leidekker  2012-09-28 02:58:00 CDT ---
*** Bug 31215 has been marked as a duplicate of this bug. ***

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #8 from Nikolay Sivov  2012-10-08 00:21:57 CDT ---
Created attachment 42021
  --> http://bugs.winehq.org/attachment.cgi?id=42021
patch

Hans, could you try this one to see if it works for .net installer?

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #9 from Hans Leidekker  2012-10-08 03:04:57 CDT ---
(In reply to comment #8)
> Created attachment 42021 [details]
> patch
>
> Hans, could you try this one to see if it works for .net installer?

Yes, that works.

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

--- Comment #10 from Nikolay Sivov  2012-11-12 21:49:02 CST ---
Workaround is committed as 47d2f3caf56eb6c06b1d8f6d0f07b9815da685e6, please
retest.

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Bruno Jesus  2012-12-16 14:16:43 CST ---
The test case from comment 2 produces the following output:

Windows:
Line 1: <?xml version="1.0"?>
Line 2: <settings>
Line 3:   <setting/>
Line 4: </settings>
Line 5:

Line 5 is empty.

Wine:
Line 1: <settings>
Line 2:   <setting/>
Line 3: </settings>

The output is different but the &#xD; or &#13; is not present so I guess it's
fixed.

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]     |

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Bruno Jesus  2013-03-26 00:20:51 CDT ---
Still works in wine 1.5.26, assuming fixed as the testcase works and the other
bug closed as duplicate also works.

[Bug 24325] MSXML Parser corrupts line breaks

http://bugs.winehq.org/show_bug.cgi?id=24325

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2013-03-29 13:32:47 CDT ---
Closing bugs fixed in 1.5.27.