https://bugs.winehq.org/show_bug.cgi?id=38417
Bug ID: 38417 Summary: [EA] Origin self-updater fails to install updates Product: Wine Version: 1.7.40 Hardware: x86 URL: http://www.dm.origin.com/download OS: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: gyebro69@gmail.com CC: sebastian@fds-team.de Distribution: ---
Created attachment 51271 --> https://bugs.winehq.org/attachment.cgi?id=51271 terminal output
You don't need to have an Origin account to reproduce the problem.
I have this problem both with the Thin Installer (OriginThinSetup.exe) and the 'normal' installer (OriginSetup.exe). When installation of the client is finished it tries to update itself to the latest version. The updated files are downloaded in /drive_c/users/Public/Application Data/Origin/SelfUpdate/StagedUpdate however an error message is shown when Origin tries to perform the update: 'Something went wrong during the installation. Please reinstall Origin'
Re-running Origin.exe from the install directory results in the same error message so the client can't be installed properly.
The updater creates a log file (UpdateTool_Log.txt) which contains lots of these "SetFileAttributes failed.." errors (maybe related to the problem):
[2015/4/15 12:39:18.457] Starting ; Update System 2 ; UpdateTool v9.5.12.2862 [2015/4/15 12:39:18.572] Mutex acquired. [2015/4/15 12:39:18.573] Registry operations [2015/4/15 12:39:18.574] Setting ProgramData permissions succeeded [2015/4/15 12:39:18.585] Origin running at: C:\Program Files\Origin\Origin.exe [2015/4/15 12:39:18.586] Found Origin folder: C:\Program Files\Origin\ [2015/4/15 12:39:18.587] SelfUpdate data location: C:\users\Public\Application Data\Origin\SelfUpdate\StagedUpdate\ [2015/4/15 12:39:18.590] Found valid update data. [2015/4/15 12:39:18.599] FILE_ATTRIBUTE_ARCHIVE: C:\Program Files\Origin\Origin.VisualElementsManifest.xml. Last error: [32] [2015/4/15 12:39:18.600] SetFileAttributes failed.. Last error: [0] [2015/4/15 12:39:18.600] Attempting deletion operation: C:\Program Files\Origin\Origin.VisualElementsManifest.xml. Number of times: [1]. Last error: [0] [2015/4/15 12:39:18.651] FILE_ATTRIBUTE_ARCHIVE: C:\Program Files\Origin\Origin.VisualElementsManifest.xml. Last error: [32] [2015/4/15 12:39:18.652] SetFileAttributes failed.. Last error: [0] [2015/4/15 12:39:18.652] Attempting deletion operation: C:\Program Files\Origin\Origin.VisualElementsManifest.xml. Number of times: [2]. Last error: [0] ...
Tested in wine-1.7.40-129-gf2aa42d on Fedora 21 The same problem persists in Wine 1.7.39/1.7.40
OriginThinSetup.exe sha1: c4a6aae0949c00d45a7adb24f27b308d8ea8eef5
https://bugs.winehq.org/show_bug.cgi?id=38417
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michael@fds-team.de
--- Comment #1 from Sebastian Lackner sebastian@fds-team.de --- Michael already analyzed this problem a few days ago, a detailed analysis and a suggested patch will come soon.
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #2 from Sebastian Lackner sebastian@fds-team.de --- The following patchset (based on the analysis by Michael Müller) should fix the issue: https://github.com/wine-compholio/wine-staging/tree/master/patches/server-De...
https://bugs.winehq.org/show_bug.cgi?id=38417
jre.winesim@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jre.winesim@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=38417
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #3 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Sebastian Lackner from comment #2)
The following patchset (based on the analysis by Michael Müller) should fix the issue: https://github.com/wine-compholio/wine-staging/tree/master/patches/server- Delete_On_Close
Thanks for making the patch available, it works here ;)
https://bugs.winehq.org/show_bug.cgi?id=38417
Erik eangelle@sbcglobal.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |eangelle@sbcglobal.net
--- Comment #4 from Erik eangelle@sbcglobal.net --- Please forgive me as I am a noob. Can you provide how to apply the patch?
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #5 from Sebastian Lackner sebastian@fds-team.de --- The patch has to be applied on the Wine source code. You can find information about applying patches on http://wiki.winehq.org/Patching. Please note that it needs a working Wine build environment (see https://www.winehq.org/docs/wineusr-guide/installing-wine-source and http://wiki.winehq.org/WineOn64bit). If you need additional help with compiling/patching Wine please ask your questions on http://forum.winehq.org, this would be more a user question and not really related to this particular bug report.
If you do not mind using a Wine version with about 650 other patches applied, you can also use binary packages for Wine Staging, the latest version 1.7.41 includes the patch mentioned above. Take a look here for installation instructions: https://github.com/wine-compholio/wine-staging/wiki/Installation.
https://bugs.winehq.org/show_bug.cgi?id=38417
Paul The Tall paulthetall@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paulthetall@gmail.com
--- Comment #6 from Paul The Tall paulthetall@gmail.com --- Please fix this in next release. many users use origin in are now stuck. I can' patch it as well: iMac-van-Paul-3:wine12 Paulthetallest$ patch -p1 < origin.patch patching file dlls/kernel32/tests/file.c Reversed (or previously applied) patch detected! Assume -R? [n]
When I click "n" I get this "Apply anyway? [n]" When click "y" I get this: Hunk #1 FAILED at 28. Hunk #2 FAILED at 51. Hunk #3 FAILED at 79. Hunk #4 FAILED at 255. Hunk #5 FAILED at 320. 5 out of 5 hunks FAILED -- saving rejects to file dlls/kernel32/tests/file.c.rej
When I type "y" at te question "Reversed (or previously applied) patch detected! Assume -R? [n]" then I get this error:
Reversed (or previously applied) patch detected! Assume -R? [n] y Hunk #4 FAILED at 243. Hunk #5 FAILED at 287. 2 out of 5 hunks FAILED -- saving rejects to file dlls/kernel32/tests/file.c.rej
So if someone can fix this in Wine then this would be great!
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #7 from Paul The Tall paulthetall@gmail.com --- Ow extra info: Tried Wine 1.7.41 and 1.7.44 both fails
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #8 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Paul The Tall from comment #6)
So if someone can fix this in Wine then this would be great!
Hello,
I don't see big chances that it will be accepted in its current form. Whereas Wine-Staging is more user-oriented, Wine will only accept it when its a "perfect" solution - as you might have seen the patch contains a "FIXME:" for a case which isn't solved properly yet (but not important in case of Origin).
I will check if I have any ideas how to improve it and give it a try, but if you want a solution as fast as possible, just install Wine-Staging. Packages are available for various distributions, if you are using MacOS you can also download and use it via PlayOnLinux. If you prefer patching vanilla Wine, you can also ask for help via IRC in #wine-staging on Freenode.
Regards, Sebastian
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #9 from Paul The Tall paulthetall@gmail.com --- Hey Sebastian, thanks for your reply. No problem that it won't get in directly, but it would be great if I could have the patch applied in Wine. I get the error messages mentioned in the former post.
Cna you help me with that?
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #10 from Nikolay Sivov bunglehead@gmail.com --- (In reply to Sebastian Lackner from comment #8)
(In reply to Paul The Tall from comment #6)
So if someone can fix this in Wine then this would be great!
Hello,
I don't see big chances that it will be accepted in its current form. Whereas Wine-Staging is more user-oriented, Wine will only accept it when its a "perfect" solution - as you might have seen the patch contains a "FIXME:" for a case which isn't solved properly yet (but not important in case of Origin).
Was it actually ever submitted? Or you're aware of some problems in its current form?
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #11 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Paul The Tall from comment #9)
Hey Sebastian, thanks for your reply. No problem that it won't get in directly, but it would be great if I could have the patch applied in Wine. I get the error messages mentioned in the former post.
Cna you help me with that?
The error messages you provided are not sufficient to know whats going wrong, and discussion about how to apply patches should be avoided here on bugzilla (because it has nothing to do with the bug itself, and if a lot of people ask, then the whole bug report quickly gets messy). Please ask either on IRC, the winehq forums, or the wine-staging bugtracker. You are probably trying to apply the patch on a wrong wine version, or have other patches applied which conflict with this one.
(In reply to Nikolay Sivov from comment #10)
Was it actually ever submitted? Or you're aware of some problems in its current form?
As mentioned above, there is even a "FIXME" in the patch for a situation which isn't solved properly yet, so no. Nevertheless, I have a lot more patches in this area, which got all ignored so far, although they were correct and probably the best way to fix it....
https://bugs.winehq.org/show_bug.cgi?id=38417
--- Comment #12 from Henri Verbeet hverbeet@gmail.com --- (In reply to Paul The Tall from comment #6)
Please fix this in next release. many users use origin in are now stuck. I can' patch it as well: iMac-van-Paul-3:wine12 Paulthetallest$ patch -p1 < origin.patch
On a only slightly related note, "git apply" is much better for applying patches than "patch".
https://bugs.winehq.org/show_bug.cgi?id=38417
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Component|-unknown |kernel32 Summary|[EA] Origin self-updater |[EA] Origin self-updater |fails to install updates |fails to install updates | |('kernel32.DeleteFileW' | |shall only open the file | |for delete access as | |callers might not have | |read/write rights)
--- Comment #13 from Anastasius Focht focht@gmx.net --- Hello folks,
--- quote --- a detailed analysis and a suggested patch will come soon. --- quote ---
It seems the first part got lost ;-)
Adding logs/trace for completeness here.
App log file 'UpdateTool_Log.txt':
--- snip --- [2015/7/30 20:7:18.508] Starting ; Update System 2 ; UpdateTool v9.7.2.53208 [2015/7/30 20:7:18.509] Mutex acquired. [2015/7/30 20:7:18.509] Registry operations [2015/7/30 20:7:18.510] Setting ProgramData permissions succeeded [2015/7/30 20:7:18.516] Origin running at: C:\Program Files (x86)\Origin\Origin.exe [2015/7/30 20:7:18.516] Found Origin folder: C:\Program Files (x86)\Origin\ [2015/7/30 20:7:18.516] SelfUpdate data location: C:\users\Public\Application Data\Origin\SelfUpdate\StagedUpdate\ [2015/7/30 20:7:18.521] Found valid update data. [2015/7/30 20:7:18.521] Set origin folder permissions [2015/7/30 20:7:18.521] Open permissions for: C:\Program Files (x86)\Origin\ [2015/7/30 20:7:18.521] Permissions modified successfully. [2015/7/30 20:7:18.562] FILE_ATTRIBUTE_ARCHIVE: C:\Program Files (x86)\Origin\EACore_App.ini. Last error: [32] [2015/7/30 20:7:18.563] SetFileAttributes failed.. Last error: [0] [2015/7/30 20:7:18.563] Attempting deletion operation: C:\Program Files (x86)\Origin\EACore_App.ini. Number of times: [1]. Last error: [0] [2015/7/30 20:7:18.613] FILE_ATTRIBUTE_ARCHIVE: C:\Program Files (x86)\Origin\EACore_App.ini. Last error: [32] [2015/7/30 20:7:18.614] SetFileAttributes failed.. Last error: [0] ... [2015/7/30 20:9:53.601] Attempting deletion operation: C:\Program Files (x86)\Origin\EACore_App.ini. Number of times: [200]. Last error: [0] [2015/7/30 20:9:53.653] Deletion operation FAILED for : C:\Program Files (x86)\Origin\EACore_App.ini. Number of times: [200]. Last error: [0] --- snip ---
Relevant part of trace log (+server to make it obvious):
--- snip --- ... 0032:Call KERNEL32.SetFileAttributesW(0042b5b0 L"C:\Program Files (x86)\Origin\EACore_App.ini",00000080) ret=0040e04a 0032:trace:ntdll:FILE_CreateFile handle=0x33d780 access=00000000 name=L"\??\C:\Program Files (x86)\Origin\EACore_App.ini" objattr=00000040 root=(nil) sec=(nil) io=0x33d784 alloc_size=(nil) attr=00000000 sharing=00000000 disp=1 options=00000020 ea=(nil).0x00000000 0032: create_file( access=00000000, attributes=00000040, sharing=00000000, create=1, options=00000020, attrs=00000000, objattr={rootdir=0000,sd={},name=L""}, filename="/home/focht/wine-games/wineprefix-ea-origin/dosdevices/c:/Program Files (x86)/Origin/EACore_App.ini" ) 0032: create_file() = 0 { handle=01f8 } 0032:trace:ntdll:NtSetInformationFile (0x1f8,0x33d784,0x33d758,0x00000028,0x00000004) 0032: get_handle_fd( handle=01f8 ) 0032: *fd* 01f8 -> 334 0032: get_handle_fd() = 0 { type=1, cacheable=1, access=00000000, options=00000020 } 0032: close_handle( handle=01f8 ) 0032: close_handle() = 0 0032:Ret KERNEL32.SetFileAttributesW() retval=00000001 ret=0040e04a 0032:Call KERNEL32.CreateFileW(0042b5b0 L"C:\Program Files (x86)\Origin\EACore_App.ini",c0000000,00000004,00000000,00000003,00000080,00000000) ret=0040e09e 0032:trace:ntdll:FILE_CreateFile handle=0x33d718 access=c0000000 name=L"\??\C:\Program Files (x86)\Origin\EACore_App.ini" objattr=00000040 root=(nil) sec=(nil) io=0x33d71c alloc_size=(nil) attr=00000080 sharing=00000004 disp=1 options=00000060 ea=(nil).0x00000000 0032: create_file( access=c0000000, attributes=00000040, sharing=00000004, create=1, options=00000060, attrs=00000080, objattr={rootdir=0000,sd={},name=L""}, filename="/home/focht/wine-games/wineprefix-ea-origin/dosdevices/c:/Program Files (x86)/Origin/EACore_App.ini" ) 0032: create_file() = 0 { handle=01f8 } 0032:Ret KERNEL32.CreateFileW() retval=000001f8 ret=0040e09e ... 0032:Call KERNEL32.DeleteFileW(004308c0 L"C:\Program Files (x86)\Origin\EACore_App.ini") ret=0040bc28 0032:trace:ntdll:FILE_CreateFile handle=0x33d728 access=c0010000 name=L"\??\C:\Program Files (x86)\Origin\EACore_App.ini" objattr=00000040 root=(nil) sec=(nil) io=0x33d720 alloc_size=(nil) attr=00000000 sharing=00000007 disp=1 options=00001040 ea=(nil).0x00000000 0032: create_file( access=c0010000, attributes=00000040, sharing=00000007, create=1, options=00001040, attrs=00000000, objattr={rootdir=0000,sd={},name=L""}, filename="/home/focht/wine-games/wineprefix-ea-origin/dosdevices/c:/Program Files (x86)/Origin/EACore_App.ini" ) 0032: create_file() = SHARING_VIOLATION { handle=0000 } 0032:Ret KERNEL32.DeleteFileW() retval=00000000 ret=0040bc28 0032:Call KERNEL32.GetLastError() ret=0040bc3a 0032:Ret KERNEL32.GetLastError() retval=00000020 ret=0040bc3a 0032:Call KERNEL32.GetFileAttributesW(004308c0 L"C:\Program Files (x86)\Origin\EACore_App.ini") ret=00409f51 0032:Ret KERNEL32.GetFileAttributesW() retval=00000020 ret=00409f51 ... 0048:Call gdi32.TextOutW(0016002e,00000000,00000180,00148e88 L"Deletion operation FAILED for : C:\Program Files (x86)\Origin\EACore_App.ini \0099",00000050) ret=7ed3f5c5 ... 0032:Call KERNEL32.CloseHandle(000001f8) ret=0040e6ca 0032: close_handle( handle=01f8 ) 0032: close_handle() = 0 0032:Ret KERNEL32.CloseHandle() retval=00000001 ret=0040e6ca ... --- snip ---
$ wine --version wine-1.7.48-30-g5bd9d58
Regards
https://bugs.winehq.org/show_bug.cgi?id=38417
Maik Wagner maiktapwagner@aol.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |maiktapwagner@aol.com
--- Comment #14 from Maik Wagner maiktapwagner@aol.com --- Still happening in 1.7.49 (Slackware 14.1). This is not meant as a complaint but just to let everybody know.
https://bugs.winehq.org/show_bug.cgi?id=38417
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/server-Delete_ | |On_Close
https://bugs.winehq.org/show_bug.cgi?id=38417
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |71581f71d5b1155b056a8d815fe | |0036479dd54fd Status|STAGED |RESOLVED Resolution|--- |FIXED
--- Comment #15 from Sebastian Lackner sebastian@fds-team.de --- Fixed with http://source.winehq.org/git/wine.git/patch/71581f71d5b1155b056a8d815fe00364....
https://bugs.winehq.org/show_bug.cgi?id=38417
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.55.
https://bugs.winehq.org/show_bug.cgi?id=38417
ky kyrill.schilow.x@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kyrill.schilow.x@gmail.com
-
wine-bugs＠winehq.org