[Bug 16752] New: winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

Summary: winhlp32/hlp_file.c: comparison is always false due to
                    limited range of data type
           Product: Wine
           Version: 1.1.12
          Platform: Macintosh
        OS/Version: Linux
            Status: NEW
          Keywords: source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

gcc -c -I. -I. -I../../include -I../../include   -D_REENTRANT -fPIC -Wall -pipe
-fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wtype-limits -Wpointer-arith  -g -O2  -o hlpfile.o hlpfile.c
hlpfile.c: In function ‘HLPFILE_RtfAddText’:
hlpfile.c:646: warning: comparison is always false due to limited range of data
type

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

Kirill K. Smirnov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Kirill K. Smirnov   2009-01-13 07:46:35 ---
$ gcc -c -I../../../programs/winhlp32 -I. -I../../../include -I../../include  
-D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith  -g -O2  -o
hlpfile.o ../../../programs/winhlp32/hlpfile.c -Wtype-limits
cc1: error: unrecognized command line option "-Wtype-limits"

$ gcc -dumpversion
4.2.3

What version of gcc should be used to handle -Wtype-limits option?

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

--- Comment #2 from Dmitry Timoshkov   2009-01-13 08:44:49 ---
(In reply to comment #1)
> What version of gcc should be used to handle -Wtype-limits option?

-Wtype-limits should be detected by a configure script, have a look at your
config.log (after re-running configure just in case).

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

--- Comment #3 from Kirill K. Smirnov   2009-01-13 09:20:11 ---
configure tried to detect it but failed - my gcc is just too old.

Ah, I've just found, that -Wextra can be used instead of -Wtype-limit for
gcc-4.2

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

--- Comment #4 from Austin English   2009-08-30 15:22:11 ---
Still present in git.

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Macintosh                   |ppc32

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

--- Comment #5 from Austin English  2010-12-02 16:10:59 CST ---
Still in wine-1.3.8-153-g27d2b9b

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from André H.  2011-04-01 13:36:44 CDT ---
for easier finding, it's line:
if (*p < 0) /* escape non ASCII chars */

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from joaopa  2013-04-20 23:37:36 CDT ---
still a bug in current wine?

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |147d4bc88a4059e129073effa30
                   |                            |bd615eef54632
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Nikolay Sivov  2013-04-21 02:00:16 CDT ---
This was likely fixed with 147d4bc88a4059e129073effa30bd615eef54632.

[Bug 16752] winhlp32/hlp_file.c: comparison is always false due to limited range of data type

http://bugs.winehq.org/show_bug.cgi?id=16752

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2013-04-26 13:16:35 CDT ---
Closing bugs fixed in 1.5.29.