[Bug 18030] New: Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

Summary: Images not show (or flickering) in old app
           Product: Wine
           Version: 1.1.18
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=20419)
 --> (http://bugs.winehq.org/attachment.cgi?id=20419)
Screendump #1

I have purchased an old windows program that is intended for the training of
people handicapped with afasia. The program is written in (some) BASIC and runs
on anything from Windows98 and higher. It runs nicely with Wine, except for one
thing: The program displays images and these are most of the time not visible,
or flicker quickly before disappearing.

The program can be dowloaded from  http://www.desmidt.eu/digitaal.html (click
on "Klik hier om de complete versie gratis te downloaden").

Install the program as usual and start it up (you need to be in the directory
where the program is installed, most likely .wine/drive_c/Program
Files/DigitAal).

Click on "Oefeningen op woordniveau" and "Benoemen".

You see something similar to Screendump #1.

The big grey area should show an image of a chicken. The grey area below should
contain the text "k . ." (where the name of the object is to be filled in). The
right grey area should show a star.

When the window has been obscured by another window, the non-obscured parts
appear, as can be seen in Screendump #2.

Also, when I move around the window, the image of the chicken appears. The "k .
." and star still do not show.

[Bug 18030] Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

--- Comment #1 from Johan Vromans   2009-04-13 09:32:45 ---
Created an attachment (id=20420)
 --> (http://bugs.winehq.org/attachment.cgi?id=20420)
Screendump #2

[Bug 18030] Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 18030] Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

Rein Klazes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]              |
           Severity|major                       |normal
             Status|UNCONFIRMED                 |ASSIGNED
          Component|-unknown                    |user32
     Ever Confirmed|0                           |1
           Keywords|                            |regression

--- Comment #2 from Rein Klazes   2009-04-13 10:40:01 ---
I found the problem. The program does the bitblitting of the picture's itself,
and is not much helped when wine erases the picture right after that.

I fixed the same bug years ago:

2004-05-20
        * controls/static.c: Rein Klazes 
        When repainting a static control, with SS_BITMAP style, do not erase
        the background. Keep sending the WM_CTLCOLORSTATIC notification as
        Windows does.

but regressed:

commit 1de825f746c6f4873a54ab21c16d728695c9a1e8
Author: Michael Kaufmann 
Date:   Wed Jan 25 13:14:44 2006 +0100

static control: SS_CENTERIMAGE fixes.
    - Stretch bitmaps and icons to the whole control size if
      SS_CENTERIMAGE is absent
    - Draw the background of centered bitmaps and icons with the
      background brush (like Windows XP for applications with a manifest)

I will have a look. Testcase is clearly needed.

[Bug 18030] Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

--- Comment #3 from Rein Klazes   2009-04-13 12:27:34 ---
Patch submitted:

http://www.winehq.org/pipermail/wine-patches/2009-April/071822.html

[Bug 18030] Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

Rein Klazes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Rein Klazes   2009-04-16 23:09:24 ---
Fix has been committed.

http://source.winehq.org/git/wine.git/?a=commit;h=dbfbce975d6d8aeefc045cc58c...

Marking the bug fixed.

[Bug 18030] Images not show (or flickering) in old app

http://bugs.winehq.org/show_bug.cgi?id=18030

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard   2009-04-24 12:22:40 ---
Closing bugs fixed in 1.1.20.