[Bug 24978] New: Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Summary: Assertion error in winegstreamer
           Product: Wine
           Version: 1.3.6
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When using Wine 1.3.6 to play Oblivion I get consistent crashes after a couple
minutes of playing. This works fine with Wine 1.3.5. The error is always the
following:
amapps\common\oblivion\Oblivion.exe: filesource.c:1181:
FileAsyncReader_WaitForNext: La declaración `rtStop == rtSampleStop' no se
cumple (that's an assertion error).

I've done a bisection, and it leads to the patchset by Aric Stewart. I can't
pinpoint it to a single change because the first four patches cause Oblivion to
freeze when it tries to play its intro video, I assume because the feature is
incomplete without the fifth patch. Git's bisect output:
There are only 'skip'ped commits left to test.
The first bad commit could be any of:
30c1fe5836482d3a57f0f69cba4bac6ffba7ce9a
d53cdf7325c0faa90cc2312606bb7ab0b66417db
85c2ebc563a8098b9002e5a2330a2e692851fe87
a2916f3a0bfe7e4d2157c5a7413358391d00ba71
af927de18bcd6a11a3d6c156cea5da2fe29c95bf
We cannot bisect more!

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Javier Kohen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

--- Comment #1 from Aric Stewart  2010-11-01 08:11:00 CDT ---
(In reply to comment #0)
> When using Wine 1.3.6 to play Oblivion I get consistent crashes after a couple
> minutes of playing. This works fine with Wine 1.3.5. The error is always the
> following:
> amapps\common\oblivion\Oblivion.exe: filesource.c:1181:
> FileAsyncReader_WaitForNext: La declaración `rtStop == rtSampleStop' no se
> cumple (that's an assertion error).
>
> I've done a bisection, and it leads to the patchset by Aric Stewart. I can't
> pinpoint it to a single change because the first four patches cause Oblivion to
> freeze when it tries to play its intro video, I assume because the feature is
> incomplete without the fifth patch. Git's bisect output:
> There are only 'skip'ped commits left to test.
> The first bad commit could be any of:
> 30c1fe5836482d3a57f0f69cba4bac6ffba7ce9a
> d53cdf7325c0faa90cc2312606bb7ab0b66417db
> 85c2ebc563a8098b9002e5a2330a2e692851fe87
> a2916f3a0bfe7e4d2157c5a7413358391d00ba71
> af927de18bcd6a11a3d6c156cea5da2fe29c95bf
> We cannot bisect more!

Could you generate a +gstreamer,+quartz,+strmbase log?

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

--- Comment #2 from Javier Kohen  2010-11-01 08:27:24 CDT ---
Created an attachment (id=31647)
 --> (http://bugs.winehq.org/attachment.cgi?id=31647)
Wine 1.3.6 +gstreamer,+quartz,+strmbase

(In reply to comment #1)
> Could you generate a +gstreamer,+quartz,+strmbase log?

Attached.

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Vit Hrachovy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Vit Hrachovy  2010-11-01 09:54:24 CDT ---
I can see the error too with 1.3.6. Will check if 1.3.5 is ok.

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

--- Comment #4 from Javier Kohen  2010-11-01 09:59:25 CDT ---
(In reply to comment #3)
> I can see the error too with 1.3.6. Will check if 1.3.5 is ok.

It does work with 1.3.5. Read the initial comment, I've already done the
regression check, and the author of the patchset that introduced the issue is
already aware of it.

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

--- Comment #5 from Aric Stewart  2010-11-03 07:46:13 CDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > I can see the error too with 1.3.6. Will check if 1.3.5 is ok.
>
> It does work with 1.3.5. Read the initial comment, I've already done the
> regression check, and the author of the patchset that introduced the issue is
> already aware of it.

Humm, much of the code around those asserts seems pretty nonsensical to me,
completely unrelated to gstreamer.

Unfortunately, my understanding of quarts does not extend to here very well. 
It appears to be reading less bytes from the file than is expected and as a
result asserting that the sample is shorter than expected.

Could you test with the given patch, that simply removes the odd asserts, and
see what the behavior is like?

thanks
-aric

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

--- Comment #6 from Aric Stewart  2010-11-03 07:47:46 CDT ---
Created an attachment (id=31703)
 --> (http://bugs.winehq.org/attachment.cgi?id=31703)
remove asserts

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Maarten Lankhorst  2010-11-03 08:31:24 CDT ---
Ok it seems that it tries to read beyond EOF, which is causing it to trip over
the assertion, fixing this requires some changes :)

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winegstreamer

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Carlton Hobbs  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #8 from Maarten Lankhorst  2010-11-07 08:36:15 CST ---
Created an attachment (id=31778)
 --> (http://bugs.winehq.org/attachment.cgi?id=31778)
Patch that calls end of stream

Simple patch to push a end of stream notification, does this fix things?

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

--- Comment #9 from Javier Kohen  2010-11-07 13:41:46 CST ---
I applied this patch to Wine 1.3.6 and compiled it. Then I played the game for
about half an hour and didn't see get crashes. This should have been more than
enough (it was usually a couple minutes until the crash), so I think this
particular issue is solved.

Thanks!

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Maarten Lankhorst  2010-11-10 05:22:03 CST ---
fix is in wine now

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Maarten Lankhorst  2010-11-10 05:26:22 CST ---
*** Bug 25004 has been marked as a duplicate of this bug. ***

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Dmitry Timoshkov  2010-11-12 08:27:03 CST ---
*** Bug 25122 has been marked as a duplicate of this bug. ***

[Bug 24978] Assertion error in winegstreamer

http://bugs.winehq.org/show_bug.cgi?id=24978

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2010-11-12 13:34:58 CST ---
Closing bugs fixed in 1.3.7.