[Bug 57424] New: msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57424

Bug ID: 57424
           Summary: msys2-64/cygwin64: mintty.exe not able to show
                    bash.exe output.
           Product: Wine
           Version: 9.21
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wineserver
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Cygwin in version 3.5.4 or later relies in having the WriteQuotaAvailable
member of a NtQueryInformationFile(FilePipeLocalInformation) query
to be non-zero.

This causes mintty.exe not being able to show the bash.exe output
when running in wine.

A bisect of cygwin1.dll led to this cygwin commit:
  49018bf5774fc90ddddc762a8462030c5d528643 is the first broken commit
  commit 49018bf5774fc90ddddc762a8462030c5d528643
  Author: Takashi Yano 
  Date:   Mon Jul 1 17:44:53 2024 +0900
    Cygwin: pty: Avoid client deadlock when pty master stops to read.

https://www.cygwin.com/cgit/newlib-cygwin/commit/?h=cygwin-3_5-branch&id...

https://www.cygwin.com/cgit/newlib-cygwin/commit/?id=c4fb5da2787693ea3bf20b2...

Installing cygwin/msys2 or reproducing this issue
might need several other patches from this tree:
https://gitlab.winehq.org/bernhardu/wine/-/commits/msys2-cygwin_2024-11-16/?...

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57424

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]
       Distribution|---                         |Debian

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57424

nicolas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57424

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57424

--- Comment #1 from Bernhard Übelacker  ---
Created attachment 78508
  --> http://bugs.winehq.org/attachment.cgi?id=78508
server: Return some non-zero value in member WriteQuotaAvailable. (rebased
wine-10.7)

Still present with wine-10.7.

The patches from bug #55138 and bug #53574 need to be applied
to reach below issue.

Finishing the installion of msys2-x86_64-20250221.exe
and starting a MSYS2 shell, the mintty window shows just
a blinking cursor.

Applying attached patch makes the output from bash visible
and the terminal usable.

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57424

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78508|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernhard Übelacker  ---
Created attachment 78522
  --> http://bugs.winehq.org/attachment.cgi?id=78522
server: Return some non-zero value in member WriteQuotaAvailable. (rebased
wine-10.7)

Refined patch by returning value depending on value in NamedPipeEnd.

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57424

--- Comment #3 from Joel Holdsworth  ---
This version of the patch looks very reasonable to me. Much better to set
WriteQuotaAvailable to a real value instead of 1. Would you submit it upstream?

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57424

--- Comment #4 from Bernhard Übelacker  ---
(In reply to Joel Holdsworth from comment #3)
> This version of the patch looks very reasonable to me. Much better to set
> WriteQuotaAvailable to a real value instead of 1. Would you submit it
> upstream?

I created a MR for it:
https://gitlab.winehq.org/wine/wine/-/merge_requests/7998

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57424

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4cbb92cfb93949a89cd997815a1
                   |                            |0829bc4c700fa
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Bernhard Übelacker  ---
Fixed by commit:
https://gitlab.winehq.org/wine/wine/-/commit/4cbb92cfb93949a89cd997815a10829...

[Bug 57424] msys2-64/cygwin64: mintty.exe not able to show bash.exe output.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=57424

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 10.8.