[Bug 51296] New: Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Bug ID: 51296
           Summary: Cogmind: Mouse cursor is a black square
           Product: Wine
           Version: 6.10
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: db2b266c57b73e1a16785213ce923b749c84400e
      Distribution: ArchLinux

Cogmind (a 2D SDL 1.2 game) sets a custom, monochrome mouse cursor. Since Wine
6.10, this cursor is broken and displays as a black square.

Cogmind Beta 10.2
Wine 6.9 (good), 6.10 (bad), 6.11 (bad)
GNOME 40.2 (no difference between Xorg and Wayland)
Arch Linux

db2b266c57b73e1a16785213ce923b749c84400e (user32: Handle monochrome icons in
CreateIcon() and CreateCursor() instead of CreateIconIndirect().) is the first
bad commit.

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
same problem here with wine-staging on Arch Linux, using a commercial 2D CAD.

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
Same problem on Ubuntu 20.04 (same broken commit
db2b266c57b73e1a16785213ce923b749c84400e) in the German chess game "Fritz und
Fertig", a demo version of that game can be downloaded here if this is needed
to reproduce: https://www.chip.de/downloads/Fritz-Fertig-Folge-1_42308782.html

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Fabian Maurer  ---
*** Bug 51611 has been marked as a duplicate of this bug. ***

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #4 from Fabian Maurer  ---
@Leseratte10
I can't seem to get the demo to work, it crashes when playing "Try". Anything
I'm missing here?

FWIW, here an internet archive link to the game, just in case:
https://web.archive.org/web/20210819181726/https://securedl.cdn.chip.de/down...

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #5 from [e-mail] ---
Damnit, looks like I stupidly didn't actually test if the demo version even
works. I thought I had done that before posting it here. The demo is also
crashing for me when I try to run it, so the bug can probably only be
reproduced in the full version of the game.

Is there any logs I can provide (from the full game) to help find and fix the
bug?

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #6 from [e-mail] ---
Putting this executable into the same folder as the game and then running that
instead of the main "Fritz und Fertig.exe" executable should get the demo
running.

The audio is playing weird and it will probably crash once there's actual
gameplay because it's not the correct executable, but it does get you to the
"welcome" screen where you have to enter your name and you can see the cursor
being broken.

https://web.archive.org/web/20210819191744/https://download1589.mediafire.co...

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #7 from [e-mail] ---
Hm. That seems to not work either on a fresh install. I hate games where copy
protections break everything even in a demo version ...

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #8 from Jan Alexander Steffens (heftig)  ---
@zfigura: I'm sure the developer of Cogmind would be happy to send you a copy
if you need it for debugging: [e-mail]

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Fabian Maurer  ---
Created attachment 70507
  --> https://bugs.winehq.org/attachment.cgi?id=70507
Test cases

Attaching a patch containing a few interesting test cases.
As I see it, there's two issues here:

1) create_masked_bitmap fails to create working bitmaps on wine at all (the
first window that is shown using paint_window)
2) create_masked_bitmap needs to be line by line (because of DWORD alignment)
and probably the lines in reverse.

@Zebediah Figura
I'll continue to look at this, although I wouldn't mind some advice from you :)

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #10 from Fabian Maurer  ---
Created attachment 70517
  --> https://bugs.winehq.org/attachment.cgi?id=70517
Potential fix

Attaching a potential that fixes the issues I found.
Would you mind testing with the real program/game to see if that works as well?
Please also check if the cursor actually looks like it should, not
distorted/flipped/etc.

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70517|0                           |1
        is obsolete|                            |

--- Comment #11 from Fabian Maurer  ---
Created attachment 70518
  --> https://bugs.winehq.org/attachment.cgi?id=70518
Potential fix, try 2

Correction: This should be the correct approach. Please test this if you have
time.

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #12 from [e-mail] ---
This second bugfix does fix the mouse cursor in "Fritz und Fertig". Thanks!

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, regression, testcase

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #13 from [e-mail] ---
Yep, that patch also fixes the black square mouse cursor bug in Poser 7.

Great job !

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #14 from Jan Alexander Steffens (heftig)  ---
(In reply to Fabian Maurer from comment #11)
> Created attachment 70518 [details]
> Potential fix, try 2
>
> Correction: This should be the correct approach. Please test this if you
> have time.

The patch (applied to 6.15) also fixes Cogmind. Thanks!

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Artem S. Tashkinov  ---
*** Bug 51497 has been marked as a duplicate of this bug. ***

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #16 from Artem S. Tashkinov  ---
(In reply to Fabian Maurer from comment #11)
> Created attachment 70518 [details]
> Potential fix, try 2
>
> Correction: This should be the correct approach. Please test this if you
> have time.

Fixes Adobe Photoshop cursors as well. Please merge.

[Bug 51296] Cogmind: Mouse cursor is a black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Fabian Maurer  ---
*** Bug 51737 has been marked as a duplicate of this bug. ***

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cogmind: Mouse cursor is a  |Multiple applications
                   |black square                |(Cogmind, Photoshop, ...)
                   |                            |render mouse cursor as
                   |                            |black square
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #18 from Fabian Maurer  ---
New patchset is in review...

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Fabian Maurer  ---
*** Bug 51448 has been marked as a duplicate of this bug. ***

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #20 from Artem S. Tashkinov  ---
(In reply to Fabian Maurer from comment #18)
> New patchset is in review...

Where can it be found?

Wine 6.19 has just been released and it's still affected.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #21 from Fabian Maurer  ---
> Where can it be found?

Patch 1: https://source.winehq.org/patches/data/214036
Patch 2: https://source.winehq.org/patches/data/214035
Patch 3: https://source.winehq.org/patches/data/214038
> Wine 6.19 has just been released and it's still affected.

Sorry, nothing I can do - I'm waiting and waiting but the patchset is seemingly
ignored.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Artem S. Tashkinov  ---
Alexandre, this is quite a serious regression, why is not getting the required
attention?

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #23 from Artem S. Tashkinov  ---
If these patches need to revised, can we at least revert the bad commit for a
while? Of course I've done that locally but thousands of other people cannot
and will not.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #24 from Fabian Maurer  ---
Latest answer I got is here:
https://www.winehq.org/pipermail/wine-devel/2021-October/198150.html

Now idea what to make with that though.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Andrey Gusev  ---
*** Bug 51830 has been marked as a duplicate of this bug. ***

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #26 from Artem S. Tashkinov  ---
Alexandre Julliard wrote:
> If we have to do that sort of thing, I think it shows that using a DIB

was not the right choice here.

Two dozen of applications have been identified to be broken by the original
commit, can we please do something about that?

Maybe revert it since there's no consensus how to proceed from here?

Pretty much all Adobe image editing applications are now broken. Multiple games
are broken.

This is the first time in my life such a drastic regression in Wine has not
been addressed or reverted more than four months in a row.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #27 from Fabian Maurer  ---
I could provide a different patch, if I knew what was needed... Until then, I
don't think my patches are a bad solution, FWIW.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #28 from Fabian Maurer  ---
Any news on how to proceed?

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

--- Comment #29 from Artem S. Tashkinov  ---
(In reply to Fabian Maurer from comment #28)
> Any news on how to proceed?

I hope Alexander won't mind me citing his reply from a private email:
> > Hello Alexandre!
> >
> > Could you please do something about bug 51296?
> >
> > The corresponding regression breaks quite a large number of applications.
> >
> > Two sets of patches have been offered, looks like you've rejected both.
> Well yes, someone will have to fix this correctly. Probably it's one of the regression that will be addressed during code freeze.

Honestly I've no idea what it means and what to do.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Guilherme S.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Debucquoy Anthony  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Илья Индиго  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #30 from Илья Индиго  ---
I noticed today the same problem with the cursors in the game Plants vs
Zombies.
This patch fixed the problem.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |197f2ee6c0e2dd70cfac6e15ede
                   |                            |7fc0e38948188
         Resolution|---                         |FIXED

--- Comment #31 from Zebediah Figura  ---
Should be fixed upstream by
https://source.winehq.org/git/wine.git/commitdiff/197f2ee6c0e2dd70cfac6e15ede7fc0e38948188.

[Bug 51296] Multiple applications (Cogmind, Photoshop, ...) render mouse cursor as black square

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51296

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #32 from Alexandre Julliard  ---
Closing bugs fixed in 7.0-rc2.