[Bug 48757] New: Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

Bug ID: 48757
           Summary: Multiple Direct3D 7 games crash with Wine Staging 5.4
           Product: Wine
           Version: 5.4
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 66664
  --> https://bugs.winehq.org/attachment.cgi?id=66664
Crash log obtained after running Blood 2

Multiple Direct3D 7 (and possibly 6) games crash on startup with the following
common/similar trace after upgrading Wine Staging from 5.3 to 5.4:

=>0 0x7d579dc2 wined3d_texture_release_dc+0x61a2() in wined3d (0x0032dae8)
  1 0x7d50fa83 wined3d_check_device_format+0x52() in wined3d (0x0032db48)

Among the affected games I can mention (the list is not exhaustive):
- Blood 2 - The Chosen
- Legacy Of Kain - Soul Reaver
- GTA2
- Emperor - Battle For Dune
- Battle Realms
- Dungeon Keeper 2
- Praetorians
- Re-Volt
- Sacrifice

I've tested on a clean prefix and on multiple machines to confirm the
behaviour, on both intel and nvidia graphics hardware.

Unfortunately I'm not knowledgeable enough to do a bisect, but I'm hoping it
will be easy enough to track down what has caused this issue.

If you need any other details please do let me know.

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Mint

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from joaopa  ---
Does it happen with vanilla wine-5.4?
If yes, does it happen with the demo
https://www.gamepressure.com/download.asp?ID=2345

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

WinterSnowfall  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Wine                        |Wine-staging
          Component|-unknown                    |-unknown
                 CC|                            |[e-mail]
                   |                            |, [e-mail]

--- Comment #2 from WinterSnowfall  ---
(In reply to joaopa from comment #1)
> Does it happen with vanilla wine-5.4?

No, just staging. I'll update the bug accordingly.
> If yes, does it happen with the demo
> https://www.gamepressure.com/download.asp?ID=2345

It does happen with this demo on staging.

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

--- Comment #3 from WinterSnowfall  ---
Created attachment 66665
  --> https://bugs.winehq.org/attachment.cgi?id=66665
Crash log for the Praetorians demo

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

--- Comment #4 from Alistair Leslie-Hughes  ---
Can you please create a +ddraw log
WINEDEBUG=ddraw wine <program> >& log.txt

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

Paul Gofman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Paul Gofman  ---
Should be fixed by
https://github.com/wine-staging/wine-staging/commit/cd7d77fe367aa0018333565c...

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

--- Comment #6 from WinterSnowfall  ---
(In reply to Paul Gofman from comment #5)
> Should be fixed by
> https://github.com/wine-staging/wine-staging/commit/
> cd7d77fe367aa0018333565cafcfe068cf9c70df

Thanks so much for the fix!

I'm still halfway through figuring out how to actually build wine (the main
hurdle) with the staging patches, since it's the first time I'm doing it, but
I'll report back to confirm if it's fixed as soon as I get anywhere.

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

WinterSnowfall  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from WinterSnowfall  ---
One thing I never thought I'd get to do in this lifetime later, I can confirm
the above commit fixes the issue. Thanks again!

[Bug 48757] Multiple Direct3D 7 games crash with Wine Staging 5.4

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48757

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Zebediah Figura  ---
Closing bugs fixed in Wine-Staging 5.5.