http://bugs.winehq.org/show_bug.cgi?id=27985
Summary: Starcraft 2 Editor: The data editor listviews which show the attribute names have each a horizontal scrollbar Product: Wine Version: 1.3.25 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: florian@fkoeberle.de
Created an attachment (id=35820) --> (http://bugs.winehq.org/attachment.cgi?id=35820) Unreadable tokenfield because of the horizontal scrollbar. (Wine 1.3.25)
The data editor listviews which show the attribute names have each a horizontal scrollbar, which can be used to scroll by about 1-3 pixel. On windows, or with native comctl32 there is no horizontal scrollbar.
On windows it looks like this: http://www.staredit.net/starcraft2/File:Actor_-_Right_Panel.jpg (Ignore the red markers)
Workaround: Resize the single column in the listview with the horizontal scrollbar.
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com 2011-09-17 09:39:49 CDT --- Please attach +listview,+win,+tid. If it's possible use empty data files that only show problematic field - to reduce log size and time to figure out what's going on. Also specify a text that should be displayed in this row.
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #2 from Florian florian@fkoeberle.de 2011-10-02 14:23:00 CDT --- Created attachment 36667 --> http://bugs.winehq.org/attachment.cgi?id=36667 Testcase (patch)
Not a log but something more usefull: I wrote a small testcase which demonstrates the problem.
I am not that familiar to the code as you are, so I will first give you the chance to fix the bug.
Do you have any comments on the testcase-patch before I send it to the mailing list?
http://bugs.winehq.org/show_bug.cgi?id=27985
Florian florian@fkoeberle.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2011-10-19 12:57:44 CDT --- This test case is not very useful actually. Scrollbar is supposed to be added automatically when client area doesn't fit window size, and this has nothing to do with common control itself, it's a general window thing.
Does is use LVS_NOSCROLL by any chance or other way to disable scrollbar? I feel like the problem is in column width miscalculation which is based on text metrics usually.
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #4 from Florian florian@fkoeberle.de 2011-10-20 16:17:37 CDT --- Well the idea of the test is to show that having a column with the same size as the listview should not result in a visible scrollbar. I used the test bot to validate that windows does indeed behave that way.
I am not sure what you are asking about with "Does is use LVS_NOSCROLL", but as the test shows that windows doesn't show a scrollbar in that particular case even without any LVS_NOSCROLL flags.
I think too that the width calculation is wrong, but I kept the test that way since I am unsure of how to get the calculated width. It's propably totally easy but I don't know how to do it and would have to dig trough MSDN documentation.
So should I try to find out how to get the calculated width or do you want to write a proper test and patch?
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2011-10-25 13:32:49 CDT --- (In reply to comment #4)
Well the idea of the test is to show that having a column with the same size as the listview should not result in a visible scrollbar. I used the test bot to validate that windows does indeed behave that way.
I tested with ControlSpy just now and one-column list with no vertical scrollbar still gets a horizontal one if I set column width to whole control width. So some padding/nonclient size matters and gives scrollbar on native too, it's hard to tell what's going on with it.
I am not sure what you are asking about with "Does is use LVS_NOSCROLL", but as the test shows that windows doesn't show a scrollbar in that particular case even without any LVS_NOSCROLL flags.
If it uses LVS_NOSCROLL it probably disables scrollbar that's what I mean.
I think too that the width calculation is wrong, but I kept the test that way since I am unsure of how to get the calculated width. It's propably totally easy but I don't know how to do it and would have to dig trough MSDN documentation.
You mean width calculation is wrong in described case or in general?
So should I try to find out how to get the calculated width or do you want to write a proper test and patch?
Width calculation depends on text width, so tests will not be very reliable. What we need is a short enough log (+listview) that shows how control is created, column added etc.
I can't get trial version of this application I guess?
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #6 from Florian florian@fkoeberle.de 2011-10-28 14:32:36 CDT --- Actually you can download the editor for yourself. The FAQ of [0] states that you can access with the Starcraft 2 Starter Edition "many functions of the map editor". This Starter Edition is free and can be downloaded at [1].
I was refering to the case which gets reproduced in attachment #36667:
Basically my argument is that the following code of attachment 36667 detects that there is a scrollbar in wine where there is no scrollbar in windows:
ok(scrollbarInfo.rgstate[0] & STATE_SYSTEM_INVISIBLE, "scrollbar should not be visible\n");
If I insert a sleep command after that check it's possible to see that there is a visible horizontal scrollbar in wine.
So either: 1. I have reproduced the same case I see in the Starcraft 2 Editor 2. This is another bug which results also in an unwanted scrollbar.
[0] http://us.battle.net/sc2/en/blog/3250656 [1] https://us.battle.net/account/sc2/starter-edition/
http://bugs.winehq.org/show_bug.cgi?id=27985
Sylvain Petreolle spetreolle@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spetreolle@yahoo.fr
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com 2013-05-21 12:01:01 CDT --- Wiki says starter version is still 7 GB, I don't have enough bandwidth to get it right now. Could you attach +listview,+tid log and tell me what is the item text that's covered with scrollbar?
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #8 from Florian florian@fkoeberle.de 2013-05-26 06:24:59 CDT --- Created attachment 44561 --> http://bugs.winehq.org/attachment.cgi?id=44561 +listview,+tid log made with wine 1.5.31
Here are the first 10000 lines of a +listview,+tid log. The listviews with the columns Token and Field hae scrollbars when they should not.
The full log is compressed 1.2MB large, so that I can't attach it.
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #9 from Florian florian@fkoeberle.de 2013-05-26 06:31:13 CDT --- Created attachment 44562 --> http://bugs.winehq.org/attachment.cgi?id=44562 How the application looked while I recoreded the log
http://bugs.winehq.org/show_bug.cgi?id=27985
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.delanoy@gmail.com
--- Comment #10 from Frédéric Delanoy frederic.delanoy@gmail.com --- Is this still an issue in latest wine (1.7.17 or later)?
http://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #11 from Florian florian@fkoeberle.de --- It is still an issue in wine-1.7.16, the latest wine that is in the package repository of Fedora 19.
http://bugs.winehq.org/show_bug.cgi?id=27985
Florian florian@fkoeberle.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.3.25 |1.7.16
http://bugs.winehq.org/show_bug.cgi?id=27985
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.16 |1.3.25
--- Comment #12 from Frédéric Delanoy frederic.delanoy@gmail.com --- (In reply to Florian from comment #11)
It is still an issue in wine-1.7.16, the latest wine that is in the package repository of Fedora 19.
Please don't change bug version, it should be the earliest known wine version that had the bug.
https://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #13 from Ken Sharp imwellcushtymelike@gmail.com --- Does this still occur in Wine 1.7.44 or later?
https://bugs.winehq.org/show_bug.cgi?id=27985
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Abandoned?
--- Comment #14 from Frédéric Delanoy frederic.delanoy@gmail.com --- Is this still an issue in latest wine (1.7.17 or later)?
Please retest or this bug will be adandoned.
https://bugs.winehq.org/show_bug.cgi?id=27985
Adam Bolte abolte@systemsaviour.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |abolte@systemsaviour.com
--- Comment #15 from Adam Bolte abolte@systemsaviour.com --- I tried to take a look at this, but was blocked by bug #41398.
https://bugs.winehq.org/show_bug.cgi?id=27985
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41398
https://bugs.winehq.org/show_bug.cgi?id=27985
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #16 from winetest@luukku.com --- (In reply to Adam Bolte from comment #15)
I tried to take a look at this, but was blocked by bug #41398.
There is a workaround explaned now at final comment (#23).
https://bugs.winehq.org/show_bug.cgi?id=27985 Bug 27985 depends on bug 41398, which changed state.
Bug 41398 Summary: Starcraft 2 Editor: Crashes when Battle.net login dialog is presented https://bugs.winehq.org/show_bug.cgi?id=41398
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Resolution|--- |FIXED
https://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #17 from Ken Sharp imwellcushtymelike@gmail.com --- Please retry in Wine 3.9 or later.
https://bugs.winehq.org/show_bug.cgi?id=27985
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=27985
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ABANDONED Status|UNCONFIRMED |RESOLVED
--- Comment #18 from Ken Sharp imwellcushtymelike@gmail.com --- No answer.
https://bugs.winehq.org/show_bug.cgi?id=27985
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|ABANDONED |--- Ever confirmed|0 |1
--- Comment #19 from Nikolay Sivov bunglehead@gmail.com --- Reopening.
https://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #20 from Ken Sharp imwellcushtymelike@gmail.com --- Why?
https://bugs.winehq.org/show_bug.cgi?id=27985
--- Comment #21 from Nikolay Sivov bunglehead@gmail.com --- Because it's unlikely got fixed accidentally, and closing when application is known just because some time passed is not useful.
https://bugs.winehq.org/show_bug.cgi?id=27985
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |ABANDONED
--- Comment #22 from Ken Sharp imwellcushtymelike@gmail.com --- That's why it isn't marked as fixed, just like all bugs marked abandoned.
Abandoned. NO REPORT of any issue since 2014.
https://bugs.winehq.org/show_bug.cgi?id=27985
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #23 from Austin English austinenglish@gmail.com --- Closing.