http://bugs.winehq.org/show_bug.cgi?id=9838
Summary: Input Method's output overruns the buffer of wine keyboard input Product: Wine Version: 0.9.46. Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-x11driver AssignedTo: wine-bugs@winehq.org ReportedBy: fygar256@ybb.ne.jp
Typing and entering over 8 letters in Japanese with input method, wine outputs an error which says 'buffer overflow need n*3!' (n is the number of Japanese letters here) , when input ignored and/or occationally the application will be down.
There may be a patch for it somewhere on the Net but the patch's version is very old and the patch I found may differ to what I want. So patching it is awful for me.
Is there good information? I hope the next or the near version of wine will be fixed that bug.
My best regards.
http://bugs.winehq.org/show_bug.cgi?id=9838
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor
http://bugs.winehq.org/show_bug.cgi?id=9838
Taisuke Maekawa fygar256@ybb.ne.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |REMIND
--- Comment #1 from Taisuke Maekawa fygar256@ybb.ne.jp 2007-10-01 07:04:20 --- Now I'm using the applications which need Input Method with a little patch.
The patch I have done is the following: ------------start-------------------- In wine-0.9.46/dlls/winex11.drv/keyboard.c
(1) at Line 1355
char Str[24];
change the buffer size to
char Str[1024];
(2) at line 2390
char lpChar[10];
change the buffer size to
char lpChar[1024];
----------END------------------------ and recompile wine.
I don't know how long Japanese or Chinese letter string can be inputed by the changes. However I could input the sentence long enough for practical use at once.
This patch cannot resolve the problem that the application will be down when the long sentence inputed over the buffer.
Good News?
http://bugs.winehq.org/show_bug.cgi?id=9838
Taisuke Maekawa fygar256@ybb.ne.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|REMIND |WORKSFORME
--- Comment #2 from Taisuke Maekawa fygar256@ybb.ne.jp 2007-10-02 11:09:51 --- I tested how many Japanese character can be inputed through IM after applied the patch, then 64 characters could be inputed.
And when over 64 characters are inputed, the inputs are just ignored without errors because I was watching wine's behavior from a terminal ,when the application seemed not to be down.
Perhaps ,if the input is over 64 characters,the inputs are discarded inside wine.
For me Japanese,64 characters are a little short. At least, 256 characters long input could be for practical use for example MSWORD, Homepage builder etc.
Anyway it works for me.
Was it proper that I changed the status UNCONFIRMED to the other of my own accord? If not so, I say sorry.
http://bugs.winehq.org/show_bug.cgi?id=9838
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Dan Kegel dank@kegel.com 2008-01-28 05:50:45 --- Closing all RESOLVED WORKSFORME bugs older than four weeks.
http://bugs.winehq.org/show_bug.cgi?id=9838
Taisuke Maekawa fygar256@ybb.ne.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |UNCONFIRMED Resolution|WORKSFORME | Version|0.9.46. |0.9.57.
--- Comment #4 from Taisuke Maekawa fygar256@ybb.ne.jp 2008-03-08 18:14:53 --- I tested this bug on wine-0.9.57 but this bug still persist.
Would you please distribute the patched or fixed winex11.drv in wine? In the environment of fedora 8 64bit version, nobody can compile so well with the way on the site (http://wiki.winehq.org/WineOn64bit) and there may be many people who are using input method and who cannot compile wine with the patch.
http://bugs.winehq.org/show_bug.cgi?id=9838
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com Keywords| |patch
--- Comment #5 from Dan Kegel dank@kegel.com 2008-03-20 16:41:09 --- Kusanagi sent a patch: http://www.winehq.org/pipermail/wine-patches/2008-March/051858.html
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #6 from Taisuke Maekawa fygar256@ybb.ne.jp 2008-04-05 19:10:13 --- Mr.Kusanagi's patch worked.
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #7 from Taisuke Maekawa fygar256@ybb.ne.jp 2008-05-02 17:23:55 --- Created an attachment (id=12650) --> (http://bugs.winehq.org/attachment.cgi?id=12650) patch for xim.c
Now Mr.Kusanagi's patch will not be applied to xim.c because xim.c was modified on wine-0.9.60 and 0.9.61. The part of patch for keyboard.c can be applied. So I'm using the Mr.Kusanagi's patch with modifing like the attatchment patch.
http://bugs.winehq.org/show_bug.cgi?id=9838
Liu Qishuai lqs.buaa@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #8 from Liu Qishuai lqs.buaa@gmail.com 2008-06-25 11:39:13 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #9 from Muneyuki Noguchi nogu.dev@gmail.com 2008-09-06 02:45:30 --- Created an attachment (id=15859) --> (http://bugs.winehq.org/attachment.cgi?id=15859) a patch for dlls/winex11.drv/keyboard.c
I sent a patch for dlls/winex11.drv/keyboard.c to wine-patches in August 2008.
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #10 from Dan Kegel dank@kegel.com 2008-09-06 04:44:18 --- Here's a link to that patch: http://www.winehq.org/pipermail/wine-patches/2008-August/060444.html He was very persistent, and sent in five successively improved versions of the patch, but it was still not committed; nobody knows why. It might help to ask Alexandre on IRC ( irc://irc.freenode.net/winehackers ).
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #11 from Austin English austinenglish@gmail.com 2008-09-06 18:02:17 --- (In reply to comment #10)
Here's a link to that patch: http://www.winehq.org/pipermail/wine-patches/2008-August/060444.html He was very persistent, and sent in five successively improved versions of the patch, but it was still not committed; nobody knows why. It might help to ask Alexandre on IRC ( irc://irc.freenode.net/winehackers ).
Fixing the e-mail in the patch may help: From: Muneyuki Noguchi noguchi@localhost.localdomain
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #12 from Muneyuki Noguchi nogu.dev@gmail.com 2008-09-12 10:19:26 --- The bug in xim.c remains unfixed, but the bug in keyboard.c was fixed.
http://source.winehq.org/git/wine.git/?a=commitdiff;h=18d2653c3b15a22ad0c00d...
http://bugs.winehq.org/show_bug.cgi?id=9838
--- Comment #13 from Muneyuki Noguchi nogu.dev@gmail.com 2008-09-15 11:57:49 --- The bug in xim.c was also fixed. http://source.winehq.org/git/wine.git/?a=commitdiff;h=f8446f260651739f8374bc...
I think this bug 9838 was fixed.
http://bugs.winehq.org/show_bug.cgi?id=9838
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #14 from Lei Zhang thestig@google.com 2008-09-15 12:12:30 --- marking this fixed.
http://bugs.winehq.org/show_bug.cgi?id=9838
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Alexandre Julliard julliard@winehq.org 2008-09-19 11:16:39 --- Closing bugs fixed in 1.1.5.